apt/apt-pkg/tagfile.h, branch 1.0.9.4Debians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=1.0.9.42014-03-21T15:26:01Zmark optional (private) symbols as hidden2014-03-21T15:26:01ZDavid Kalnischkiesdavid@kalnischkies.de2014-03-21T15:26:01Zurn:sha1:ce62f1def6565375ce9c56eb1237ccdc0ca138ba
This methods should not be used by anyone expect the library itself as
they are helpers for the specific class and therefore perfect candidates
for hidding.
Git-Dch: Ignore
warning: type qualifiers ignored on function return type [-Wignored-qualifiers]2014-03-13T12:58:45ZDavid Kalnischkiesdavid@kalnischkies.de2014-03-01T12:55:20Zurn:sha1:d64e130aa333837a8fda0f1bba51f2867ca520f7
Reported-By: gcc -Wignored-qualifiers
Git-Dch: Ignore
Merge remote-tracking branch 'mvo/bugfix/coverity' into debian/sid2013-08-22T20:24:27ZMichael Vogtmvo@debian.org2013-08-22T20:24:27Zurn:sha1:fbe0969131dc2472bcefbceaf390015ba68e1327
Conflicts:
apt-pkg/tagfile.h
ensure that pkgTagFile isn't writing past Buffer length2013-08-15T15:39:24ZDavid Kalnischkieskalnischkies@gmail.com2013-08-15T14:49:51Zurn:sha1:0aae6d14390193e25ab6d0fd49295bd7b131954f
In 91c4cc14d3654636edf997d23852f05ad3de4853 I removed the +256 from
the pkgTagFile call parsing Release files as I couldn't find a
mentioning of a reason for why and it was marked as XXX which suggested
that at least someone else was suspicious.
It turns out that it is indeed "documented", it just didn't found it at
first but the changelog of apt 0.6.6 (29. Dec 2003) mentions:
* Restore the ugly hack I removed from indexRecords::Load which set the
pkgTagFile buffer size to (file size)+256. This is concealing a bug,
but I can't fix it right now. This should fix the segfaults that
folks are seeing with 0.6.[45].
The bug it is "hiding" is that if pkgTagFile works with a file which doesn't
end in a double newline it will be adding it without checking if the Buffer
is big enough to store them. Its also not a good idea to let the End
pointer be past the end of our space, even if we don't access the data.
Closes: 719629
fix -Wall errors2013-08-08T13:40:15ZMichael Vogtmvo@debian.org2013-08-08T13:40:15Zurn:sha1:f52037d629aea696f938015e7f1ec037eb079af8memset() pkgTagSections data to make coverity happy2013-08-06T07:13:27ZMichael Vogtmvo@debian.org2013-08-06T07:13:27Zurn:sha1:b40394c0ff509954c37254b0993a985ea3ff1467fix some unitialized data members2013-08-05T20:40:28ZMichael Vogtmvo@debian.org2013-08-05T20:40:28Zurn:sha1:4ccd3b3ce69d6a6598e1773689a44fdec78a85ccfix pkgTagSection::Exists() and add test2013-03-18T11:10:35ZMichael Vogtmichael.vogt@ubuntu.com2013-03-18T11:10:35Zurn:sha1:c8b860fb8d0f1531f99db4fad74f5892c6806f1brevert 2184.1.3: forward declaration instead of headers2011-12-13T00:22:38ZDavid Kalnischkieskalnischkies@gmail.com2011-12-13T00:22:38Zurn:sha1:b9dadc24b9477b466bc8058c765d76c65ecc7125
The breakage is just to big for now, so guard the change with
#ifndef APT_8_CLEANER_HEADERS and be nice to library users
use forward declaration in headers if possible instead of includes2011-09-19T17:14:19ZDavid Kalnischkieskalnischkies@gmail.com2011-09-19T17:14:19Zurn:sha1:472ff00ef2e48383805d281c6364ec27839e3f4d