apt/apt-pkg/tagfile.h, branch 2.7.9Debians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=2.7.92022-07-22T12:49:45Zapt-pkg: (re)export pkgTagSection::Key to fix FTBFS in python-apt2022-07-22T12:49:45ZMichael Vogtmvo@ubuntu.com2022-07-22T12:49:45Zurn:sha1:04109c847a30c9637cc93d929a1d2be64be057e6
With apt 2.5.1 python-apt fails to build with:
```
...
x86_64-linux-gnu-gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O2 -Wall -g -fstack-protector-strong -Wformat -Werror=format-security -g -fwrapv -O2 -g -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -I/usr/include/python3.10 -c python/acquire-item.cc -o build/temp.linux-x86_64-3.10/python/acquire-item.o -std=c++11 -Wno-write-strings -DAPT_8_CLEANER_HEADERS -DAPT_9_CLEANER_HEADERS -DAPT_10_CLEANER_HEADERS -DPY_SSIZE_T_CLEAN
In file included from python/python-apt.h:30,
from python/apt_pkgmodule.h:211,
from python/acquire-item.cc:25:
/usr/include/apt-pkg/deblistparser.h:48:65: error: ‘pkgTagSection::Key’ has not been declared
48 | bool ParseDepends(pkgCache::VerIterator &Ver, pkgTagSection::Key Key,
| ^~~
```
This commit adds a small fix by (re)exporting `pkgTagSection::Key`.
Document tagfile-keys.h as internal to apt2022-04-01T12:15:26ZDavid Kalnischkiesdavid@kalnischkies.de2022-03-28T13:19:11Zurn:sha1:f6438ea9e726a1c13ce8d90ac78cc272346ab0f8
The previous regime of the file was to sort it on insert, but that
changes the values in the generated enum, which is fine as long as we
only use it in libapt itself, but breaks on other users.
The header was always intended to be private to apt itself, so we just
document this here now and lay the ground work to have the file in the
future only appended to, so that it remains sufficiently ABI stable that
we can use it outside the library in our apt tools.
We also remove some fields apt is unlikely to need or only uses in
certain cases outside of any (speed) critical path to have enough room
to add more fields soon as currently we are limited to 128 fields max
and it would be sad if we use up that allowance entirely already.
apt-pkg: default visibility to hidden2020-02-26T19:34:54ZJulian Andres Klodejulian.klode@canonical.com2019-08-13T17:15:19Zurn:sha1:db678df196ccd8f9f6fb336706cf5701d1e53aa6Run unifdef -DAPT_{8,9,10,15}_CLEANER_HEADERS2019-06-12T13:02:55ZJulian Andres Klodejulian.klode@canonical.com2019-05-11T15:17:20Zurn:sha1:daa1352ed3d2bb4bc6aa0f0e7f22be3f0908942dUpdate symbols and hide some pkgTagSection ABI2019-06-11T12:45:55ZJulian Andres Klodejulian.klode@canonical.com2019-06-11T12:38:54Zurn:sha1:8a9c4ad6a3621296c62e1708886140e765b23be2
Gbp-Dch: ignore
Make APT::StringView public2019-06-11T12:45:55ZJulian Andres Klodejulian.klode@canonical.com2019-02-04T18:50:16Zurn:sha1:a6e86d51a0e32cdc91f2902b0d6b483af884dccatagfile: Remove deprecated pkgUserTagSection and TFRewrite2019-02-26T15:31:20ZJulian Andres Klodejulian.klode@canonical.com2019-02-26T11:14:59Zurn:sha1:975316780b2ba3d4e60592fac9d4eb99ffc4c924Fix typos reported by codespell & spellintian2018-08-29T15:51:43ZDavid Kalnischkiesdavid@kalnischkies.de2018-08-29T15:01:25Zurn:sha1:c4862d49bbc30c37f4fca966ac515692e26d93be
No user-visible change as it effects mostly code comments and
not a single error message, manpage or similar.
Reported-By: codespell & spellintian
Gbp-Dch: Ignore
Reformat and sort all includes with clang-format2017-07-12T11:57:51ZJulian Andres Klodejak@debian.org2017-07-12T11:40:41Zurn:sha1:87274d0f22e1dfd99b2e5200e2fe75c1b804eac3
This makes it easier to see which headers includes what.
The changes were done by running
git grep -l '#\s*include' \
| grep -E '.(cc|h)$' \
| xargs sed -i -E 's/(^\s*)#(\s*)include/\1#\2 include/'
To modify all include lines by adding a space, and then running
./git-clang-format.sh.
fix various typos reported by spellintian2017-01-19T14:59:38ZDavid Kalnischkiesdavid@kalnischkies.de2017-01-19T14:14:19Zurn:sha1:93cff633a830e222693fc0f3d78e6e534d1126ee
Most of them in (old) code comments. The two instances of user visible
string changes the po files of the manpages are fixed up as well.
Gbp-Dch: Ignore
Reported-By: spellintian