apt/apt-pkg, branch 1.2.3

get dpkg lock in build-dep if cache was invalid again

2016-02-10T12:03:00Z

Regression introduced in a249b3e6fd798935a02b769149c9791a6fa6ef16, which in the case of an invalid cache would build the first part unlocked and later pick up the (still unlocked) cache for further processing, so the system got never locked and apt would end up complaining about being unable to release the lock at shutdown. The far more common case of having a valid cache worked as expected and hence covered up the problem – especially as tests who would have noticed it are simulations only, which do not lock. Closes: 814139 Reported-By: Balint Reczey Reported-By: Helmut Grohne on IRC

Set seekpos to 0 after reopening files in Seek()

2016-02-10T11:48:37Z

If we just reopened the file, we also need to reset the current seek position when we reset the buffer, otherwise the code will not try to seek to the position given to Skip (from 0), but will try to seek to old offset + the position given to skip. Closes: #812994, #813000

Use some semantically more correct buffer operations

2016-02-04T17:34:42Z

When writing into the buffer write to free() bytes starting at getend(), instead of buffersize_max bytes at get() -> get() is a read pointer. This makes no difference in practice though, as we reset the buffer before the call, so start = end = 0. Gbp-Dch: ignore

Correctly report write errors when flushing buffered writer

2016-02-04T17:00:42Z

We cannot just return false without setting an error, as InternalWrite does not set one itself.

Merge branch 'master' of github.com:adrian17/apt

2016-02-04T00:08:50Z

edspsystem.cc: include for mkdtemp

2016-02-03T22:46:19Z

Include to ensure that mkdtemp(3) is defined to improve general portability and fix a specific build failure on Android. Closes: #807367

Avoid temporary strings in SubstVar.

2016-02-03T14:54:10Z

Microoptimization, but still gives a measurable 2-3% improvement when using commands with lots of output like `apt list`.

Do not buffer writes larger than the buffer if possible

2016-02-01T15:50:48Z

It makes no sense to split a large block into multiple small blocks, so when we have the chance to write them unbuffered, do so.

BufferedWriteFileFdPrivate: Simplify InternalWrite()

2016-02-01T15:29:13Z

We do not need the loop, FileFd::Private() handles this for us. Gbp-Dch: ignore

simple_buffer::write: Use free() instead of maxsize - size()

2016-02-01T15:25:03Z

We want to check whether the amount of free space is smaller than the requested write size. Checking maxsize - size() is incorrect for bufferstart >= 0, as size() = end - start. Gbp-Dch: ignore