apt/apt-pkg, branch 1.2.9

Do not mark packages for keep that we want to remove

2016-03-27T00:09:14Z

If the package is marked for removal, keep it marked for removal and do not mark it for keep. If we mark it for keep, we some how later get to a different stage where it is marked for unpack instead of removal. In the example in the bug report, we would get a: SmartUnPack maas-region-controller-min:amd64 (replace version 2.0.0~alpha3+bzr4810-0ubuntu1 with Segmentation fault maas-region-controller-min:amd64 was marked for removal, but we changed it to keep and somehow it thinks that this is to be replaced now instead of removed (probably because the InstallVer != CandidateVer [with InstallVer = 0]). This fixes a regression introduced in release 1.2.7, commit: 0390edd5452b081f8efcf412f96d535a1d959457 Reported-by: LaMont Jones on IRC LP: #1562402

drop confusing comma from no strong hash message

2016-03-25T08:31:42Z

Set hidden visibility for StringView

2016-03-24T14:16:00Z

This avoids templates using StringView to be exported, such as std::vector::emplace_back(). Gbp-Dch: ignore

refactor loading of previous release file

2016-03-19T08:48:44Z

There is really no need to have the same code three times. Git-Dch: Ignore

cachefile: Only set members that were initialized successfully

2016-03-19T06:19:24Z

Otherwise, things will just start failing later down the stack, because (a) the lazy getters do not check if building was successful and (b) any further getter call would return the invalid object anyway. Also initialize VS in pkgCache to nullptr by default. Closes: #818628

do not strip epochs from state version strings

2016-03-16T22:29:45Z

The epoch stripping in this code is done since day one, but in other places we show a version epochs are not stripped. If epochs are present in packages they tend to be an important information which we can't just drop and especially can't drop "sometimes" as that confuses users and tools alike – so even if removing code in use for (close to) 18 years feels wrong, it is probably the right choice for consistency. Closes: 818162

Use descriptive URIs in 104 Warning messages

2016-03-16T17:34:47Z

This makes the new GPG related warnings much nicer to read, for example, the second one here replaces the first one: W: gpgv:/var/lib/apt/lists/example.com_dists_stable_InRelease: Weak ... W: http://example.com/dists/stable/InRelease: Weak ...

Report non-transient errors as errors, not as warnings

2016-03-16T16:56:50Z

This makes it easier to understand what really is an error and what not.

Get accurate progress reporting in apt update again

2016-03-16T16:52:40Z

For the non-pdiff case, we have can have accurate progress reporting because after fetching the {,In}Release files we know how many IndexFiles will be fetched and what size they have. Therefore init the filesize early (in pkgAcqIndex::Init) and ensure that in Acquire::Pulse() looks at already downloaded bits when calculating the progress in Acquire::Pulse. Also improve debug output of Debug::acquire::progress

Fix bug where the problemresolve can put a pkg into a heisenstate

2016-03-15T17:55:02Z

The problemresolver will set the candidate version for pkg P back to the current version if it encounters an impossible to satisfy critical dependency on P. However it did not set the State of the package back as well which lead to a situation where P is neither in Keep,Install,Upgrade,Delete state. Note that this can not be tested via the traditional sh based framework. I added a python-apt based test for this. LP: #1550741 [jak@debian.org: Make the test not fail if apt_pkg cannot be imported]