Debians commandline package manager https://git.kalnischkies.de/apt/atom?h=1.9.5 2019-12-02T14:49:07Z 2019-12-02T14:49:07Z Julian Andres Klode jak@debian.org 2019-12-02T14:49:07Z urn:sha1:b59be3af284d13988182d99fcd2ab5948a0f6a83 Pu/patterns phase2 See merge request apt-team/apt!85 2019-12-02T13:27:38Z Julian Andres Klode julian.klode@canonical.com 2019-12-02T10:46:49Z urn:sha1:93f33052de84e9aeaf19c92291d043dad2665bbd This avoids downgrade attacks where an attacker could inject Location: http://private.example/ and then (having access to raw data to private.example, for example, by opening a port there, or sniffing network traffic) read the credentials for the private repository. Closes: #945911 2019-11-27T21:00:43Z David Kalnischkies david@kalnischkies.de 2019-11-27T11:10:31Z urn:sha1:1690c3f87ae45a41e8d3e09bf0b1021c008460b9 While passing the combi Release and Release.gpg to the gpgv method for verification the filename of Release is placed where usually Release.gpg is assumed in the rest of the code. The "usual" cases like passing verification and failing verification ending in an error are taking care of this, but the code path dealing with a failed verification, but ignoring said failure (e.g. due to trusted=yes) was not which results in the wrong file being removed later on (in case the index happens to be unmodified since the last update call) leading us into the abyss of strange failures (fixed in the previous commit) were nothing should have changed. This is not a security issue in this form as the repository needs to fail verification & the user forcing apt to ignore the failure and carry on anyhow. It does show however how complicated the code and its various interconnected paths can become. Reported-By: Val "pinkieval" Lorentz on IRC 2019-11-27T20:56:33Z David Kalnischkies david@kalnischkies.de 2019-11-27T18:57:08Z urn:sha1:62bfe5b6ca3ccfba6313d3f9ab4cb75a24a5557a If we have no old Release file, but old indices we can't compare hashsums with the new Release file and hence must request the indices again and have to react to IMS hits if they didn't change. We used to symlink the old index file to the partial directory, but that usually meant that we linked an uncompressed file to a compressed file, which not all uncompressors can deal with transparently resulting in strange failures. We could do without the symlink, but that would require changes in the codepaths dealing with failure as they would rename the file to FAILED. 2019-11-26T11:36:46Z David Kalnischkies david@kalnischkies.de 2019-09-13T10:01:47Z urn:sha1:35012abf30ec1cfc9b5ee29647d4b1e25d98e99f Unused variable, std::algorithms instead of raw for-loops. There should be no observeable difference in behaviour. Reported-By: cppcheck Gbp-Dch: Ignore 2019-11-26T11:01:42Z Julian Andres Klode julian.klode@canonical.com 2019-11-26T11:01:42Z urn:sha1:a93b4443c18ee211691f7b336b161fea7d1df699 2019-11-26T10:56:28Z Julian Andres Klode julian.klode@canonical.com 2019-11-26T10:56:28Z urn:sha1:96f795bce665a1907b885bd2d57d6ab22b0a4199 2019-11-26T10:46:06Z Julian Andres Klode julian.klode@canonical.com 2019-11-26T10:45:44Z urn:sha1:94b185bb738e063bcc387e31b39dcd041f283766 This is pure syntactic sugar - ?narrow does not exist in the abstract syntax. 2019-11-26T10:34:34Z Julian Andres Klode julian.klode@canonical.com 2019-11-26T10:34:34Z urn:sha1:6801e6d2c63d4ff087024fc84a0feb8aef86886b 2019-11-25T16:03:10Z Алексей Шилин rootlexx@mail.ru 2019-11-22T22:04:45Z urn:sha1:2497198e9599a6a8d4d0ad08627bcfc7ea49c644 When using locale in which symbols occupy more than 1 byte (for example, ru_RU.UTF-8), the progress bar width was calculated incorrectly because std::string::size() returns the number of bytes rather than the number of actual characters. Use the newly introduced APT::String::DisplayLength() to calculate the width instead.