apt/apt-pkg, branch 2.0.0

Show absolute time while waiting for lock instead of %, rework message

2020-03-06T12:14:37Z

Showing a percentage for a timeout is pretty non-standard. Rework the progress class so it can show an absolute progress (currently hardcoded to use seconds as a unit). If there is a timeout (aka if it's not the maximum long long unsigned -1llu), then show the timeout, otherwise just count up seconds, e.g. Waiting for cache lock: Could not get lock /var/lib/dpkg/lock-frontend. It is held by process 33842 (apt)... 1/120s or Waiting for cache lock: Could not get lock /var/lib/dpkg/lock-frontend. It is held by process 33842 (apt)... 1s Also improve the error message to use "Waiting for cache lock: %s" instead of "... (%s)", as having multiple sentences inside parenthesis is super weird, as is having two closing parens. We pass the information via _config, as that's reasonably easy and avoids ABI hackage. It also provides an interesting debugging tool for other kinds of progress.

GetLock: No strerror if it's just another process holding the lock

2020-03-06T12:07:55Z

This improves the locking message, getting rid of useless details. If we have a process holding the lock, we got that because the lock is being hold by it, so there's no point telling the people the reason for not getting the lock is the EAGAIN error and displaying its strerrror().

(temporarily) unhide pkgDPkgPM again to have python-apt compile

2020-02-27T08:45:50Z

pkgcache: Add operator bool() to map_pointer

2020-02-27T08:45:11Z

apt(8): Wait for frontend and cache lock

2020-02-26T19:36:52Z

This is a rework of !6 with additional stuff for the frontend lock, so we can lock the frontend lock and then keep looping over dpkg lock.

apt-pkg: default visibility to hidden

2020-02-26T19:34:54Z

cacheset: Fix -Wdeprecated-copy warnings

2020-02-26T17:59:39Z

Remove the operator= from Container_iterator, as it was basically just the default anyway, and add copy constructors to *Interface that match their operator=. Tried adding copy constructor to Container_iterator, but that only made things worse.

Fix various compiler warnings

2020-02-26T17:59:31Z

Parse records including empty tag names correctly

2020-02-26T17:12:18Z

No sensible file should include these, but even insensible files do not gain unfair advantages with it as this parser does not deal with security critical files before they haven't passed other checks like signatures or hashsums. The problem is that the parser accepts and parses empty tag names correctly, but does not store the data parsed which will effect later passes over the data resulting e.g. in the following tag containing the name and value of the previous (empty) tag, its own tagname and its own value or a crash due to an attempt to access invalid memory depending on who passes over the data and what is done with it. This commit fixes both, the incidient of the crash reported by Anatoly Trosinenko who reproduced it via apt-sortpkgs: | $ cat /tmp/Packages-null | 0: | PACKAGE:0 | | : | PACKAGE: | | PACKAGE:: | $ apt-sortpkgs /tmp/Packages-null and the deeper parsing issue shown by the included testcase. Reported-By: Anatoly Trosinenko References: 8710a36a01c0cb1648926792c2ad05185535558e

cache: Swap locations of hashtables, hide them from non-apt users

2020-02-26T13:42:35Z

Only expose the locations of the hasthables if APT_COMPILING_APT is set.