apt/apt-pkg, branch 2.1.6Debians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=2.1.62020-06-03T11:41:14ZDeal with duplicates in the solution space of a dep2020-06-03T11:41:14ZDavid Kalnischkiesdavid@kalnischkies.de2020-06-03T11:03:37Zurn:sha1:96359a576f59eb8bc461bdd4c5eadeb17fe8f0ca
While we process the possible solutions we might modify other solutions
like discarding their candidates and such, so that then we reach them
they might no longer be proper candidates. We also try to drop
duplicates early on to avoid the simple cases of these which
test-explore-or-groups-in-markinstall triggers via its explicit
duplication but could also come via multiple provides.
It only worked previously as were ignoring current versions which
usually is okay expect if they are marked for removal and we want to
reinstate them so the ProblemResolver can decide which one later on.
Allow 20 instead of 10 loops for pkgProblemResolver2020-06-03T10:55:02ZDavid Kalnischkiesdavid@kalnischkies.de2020-06-03T10:55:02Zurn:sha1:771ddb195586c638cbfc635fa6726733532bcfd0
Especially if a lot packages have to be removed due to not to explicitly
expressed conflicts the problem resolver can take a few turns to remove
them all. Allowing it to try a little longer if needed seems beneficial
as the worst which can happen is that we now take two times as long to
present an error message to the user.
Consider if a fix is successful before claiming it is2020-06-02T11:14:30ZDavid Kalnischkiesdavid@kalnischkies.de2020-06-02T10:47:12Zurn:sha1:8218c642342e431d7e69831bd1a6741b40345bf1
For protected packages the "Fixing" done via KillList in the
ProblemResolver will usually not happen as the state change is not
allowed, so the debug message is just confusing and the resolver is
needlessly looping here (which might push it over the edge), so if we
didn't do our thing successfully here we short-circuit a bit to help the
next iteration come to a solution.
Consider protected packages for removal if they are marked as such2020-05-29T10:46:59ZDavid Kalnischkiesdavid@kalnischkies.de2020-05-29T10:46:59Zurn:sha1:33e19f1fe1655e2d6883ff8d30226fb7db02dd45
The pkgProblemResolver incorrectly skips protected packages while
considering packages for removal, which was always wrong but is now a
lot more visible as (potentially) far more packages are considered
protected in their state.
Note that the testcase shows that we need more changes to make this
proper.
Fix small memory leak in MethodConfig2020-05-27T09:14:44ZDavid Kalnischkiesdavid@kalnischkies.de2020-05-27T08:27:16Zurn:sha1:1941515e1c96f9c33d63e426049d9dad5420c580
We are leaking a d-pointer currently weighting a boolean in size and
MethodConfig is instantiated in small numbers only, so nobody will
actually notice a difference, but proper cleanup is important.
Reported-By: clang LeakSanitizer
References: 04ab37fecaf286f724bef2e0969d2b67ab5ac1b1
Mark PatternTreeParser::Node destructor as virtual2020-05-25T10:05:00ZDavid Kalnischkiesdavid@kalnischkies.de2020-05-14T09:24:28Zurn:sha1:10f87f7e3f08335421fd60a2b49840289cd737de
The non-virtual base-destructor causes its derivate classes to leak
tiny bits of memory otherwise. The header is private and not to be
used outside of APT, so we can perform this tiny ABI break as there
is no ABI to break.
Reported-By: valgrind and clang -fsanitize=leak
Allow FMV SSE4.2 detection to succeed on clang2020-05-25T10:05:00ZDavid Kalnischkiesdavid@kalnischkies.de2020-05-21T20:17:42Zurn:sha1:574249cd721a3cdbb79b6e457384a55827856b6a
As the builtins were used in the feature test also in the default branch
clang fails to compile the test helpfully complaining that you need to
compile with sse4.2 to use that while on gcc it is optimized out as
unused code and produces only a warning for that… removing the code from
the default branch fixes this problem, but we adapt the code some more to
avoid compilers optimizing it out in the future just in case.
Silence clang warning -Wstring-plus-int2020-05-25T10:05:00ZDavid Kalnischkiesdavid@kalnischkies.de2020-05-24T14:36:03Zurn:sha1:c3bfdbfa3ae868515a67142d2df6200a3cb34d35
../apt-pkg/init.cc:137:39: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int]
Cnf.CndSet("Dir::State", STATE_DIR + 1);
../apt-pkg/init.cc:137:39: note: use array indexing to silence this warning
We have a few instances of that & it should be reasonably clear that we are not
actually trying to append here, but ignoring or silencing this warning with an
override is far more costly than just using what clang suggests here.
Reported-By: clang
Gbp-Dch: Ignore
Ensure EDSP doesn't use a dangling architecture string2020-05-25T10:05:00ZDavid Kalnischkiesdavid@kalnischkies.de2020-05-24T14:27:15Zurn:sha1:90a7a5e32643a67f4245460e7659d9dee230e9e7
../apt-pkg/edsp.cc:861:23: error: object backing the pointer will be destroyed at the end of the full-expression [-Wdangling-gsl]
const char *arch = _config->Find("APT::Architecture").c_str();
Compilers are probably optimizing it the way the patch does by hand now. Small
string optimisation helps likely as well. Othwise that should have failed left
and right as EDSP is used by experimental and such builders to talk to aspcud.
Reported-By: clang
Don't update candidate provides map if the same as current2020-05-25T10:05:00ZDavid Kalnischkiesdavid@kalnischkies.de2020-05-23T15:15:32Zurn:sha1:c77566fd8f21a1a44efb4092c90996d1cc8eaf24