Debians commandline package manager https://git.kalnischkies.de/apt/atom?h=2.3.1 2021-04-13T14:00:41Z 2021-04-13T14:00:41Z Julian Andres Klode julian.klode@canonical.com 2021-04-09T16:16:10Z urn:sha1:1412cf51403286e9c040f9f86fd4d8306e62aff2 Repositories without Size information for packages are not proper and need fixing. This ensures people see an error in CI, and get notifications and hence the ability to fix it. It can be turned off by setting Acquire::AllowUnsizedPackages to true. 2021-03-09T12:44:30Z David Kalnischkies david@kalnischkies.de 2021-03-09T12:26:05Z urn:sha1:676f716717b7f138661ee5cb01edb0051f96ca49 Having three different vectors littered over the method to manage various parts of the lifetime of the argument vector we are creating is a bit dangerous as it means a simple code change could result in a desync of these three, so by moving the functionality of them all into a wrapper class should prevent us from making such mistakes. 2021-03-09T12:38:13Z David Kalnischkies david@kalnischkies.de 2021-03-09T10:40:35Z urn:sha1:302b1edcb1afe8098ddc2ddd576e56b898c1d90b 2021-03-09T12:36:52Z David Kalnischkies david@kalnischkies.de 2021-03-09T10:40:59Z urn:sha1:3312607159410eda3c634a0c6fe3c2b1a4fd3cc3 One less thing to remember to do in all branches. 2021-03-09T10:45:08Z David Kalnischkies david@kalnischkies.de 2021-03-09T10:39:29Z urn:sha1:a5346a50c4f3ef15e71c16a9bf88723ae1153776 It is easy to make mistakes while dealing with such macros regardless of how much you guard them, so just using a lambda removes a lot of concerns here basically for free. 2021-03-07T01:55:07Z David Kalnischkies david@kalnischkies.de 2021-03-06T15:11:34Z urn:sha1:2a81f98b124d8fe551b160df55db1d3bf79a77c1 The mirror method can distribute requests for files based on various metadata bits, but some – the main index files – weren't actually passing those on to the methods as advertised in the manpage. This is hidden both by mirror usually falling back to other sources which will eventually hit the right one and that if the repository does not support by-hash apt will automatically stick to the mirror which was used for the Release file. 2021-03-07T01:55:07Z David Kalnischkies david@kalnischkies.de 2021-03-06T23:47:26Z urn:sha1:59933938f51105066161a6eb88253006826336a2 Especially in small sections of an archive it can happen that an index returns to a previous state (e.g. if a package was first added and then removed with no other changes happening in between). The result is that we have multiple patches which start from the same hash which if we perform clientside merging is no problem although not ideal as we perform needless work. For serverside merging it would not matter, but due to rred previously refusing to merge zero-size patches but dak ignoring failure letting it carry these size-zero patches until they naturally expire we run into a problem as these broken patches won't do and force us to fall back to downloading the entire index. By always starting from the last patch instead of the first with the starter hash we can avoid this problem and behave optimally in clientside merge cases, too. 2021-03-07T01:55:07Z David Kalnischkies david@kalnischkies.de 2021-03-06T18:55:09Z urn:sha1:246f66561e23911b9615bd337b3b6f6f25b6cd31 The rred method expects the patches to have a certain name, which we have to rename the file to before calling the method, but by delaying the rename we ensure that if the download of one of them fails and a successful fallback occurs they are all properly cleaned up as no longer useful while in the error case the next apt run can potentially pick them up as already downloaded. Our test-pdiff-usage test was encountering this every other run, but did not fail as the check for unaccounted files in partial/ was wrapped in a subshell so that the failure produced failing output, but did not change the exit code. 2021-03-01T20:43:54Z Julian Andres Klode julian.klode@canonical.com 2021-03-01T20:43:03Z urn:sha1:0d51cf142884801c903df0cddaec5545f0174553 Conflicts do require removing the package temporarily, so they really should not be used. We need to improve that eventually such that we can deconfigure packages when we have to remove their dependencies due to conflicts. 2021-03-01T20:26:24Z Julian Andres Klode julian.klode@canonical.com 2021-03-01T20:26:24Z urn:sha1:8eccb902aa3be22a151943286fb376759a2b3585 This caused python-apt to unset the Python signal handler when running update or install commands, breaking KeyboardInterrupt amongst possibly other things. We do not set those signal handlers in this functions, and the calling functions restore signal handlers to previous ones. LP: #1898026