apt/apt-pkg, branch 2.9.12

Handle Retry-After by default

2024-11-18T13:54:19Z

Let's get some feedback here. This is capped to 30s per retry, so a maximum of 90s per item that we delay the failure case. In the worst case, we hence have 90n seconds delay for n items. In a more realistic worse case however, the server likely does not collapse per-item, and we end up trying all items in a short burst so it seems more realistic we hit a 90s total delay. The bursty behavior may be suboptimal; we don't quite know, but it seems the specification of Retry-After is per-entity rather than per-host, so technically speaking it seems correct.

http: use Retry-After HTTP header to optimize retries

2024-11-18T12:44:49Z

Some mirrors like snapshot.debian.org apply strict http rate limits. While apt already has an exponential backoff mechanism implemented, this is not sufficient due to the following reasons: 1. all retries happen roughly at the same time 2. the retry-after information from the server is not used We fix this by improving the algorithm: First, if present, the timestamp or duration of the Retry-After header is added to the exponential backoff, optimizing for success-on-second-try. Second, a random delay is added (delay += [0, delay]) to distribute the retries to not immediately run into the limit again. To avoid super-long delays, this is capped by the configured maximum delay. This logic only becomes active if the option Acquire::Retries::HandleRetryAfter is enabled. Signed-off-by: Felix Moessbauer

string_view: Include missing headers

2024-11-17T15:41:33Z

Specifically the lack of the `string_view` include is causing compilation failures for rust-rust-apt. Running iwyu also adds `algorithm` for our use of `std::min`, and `iosfwd` for our use of `std::ostream` none of which seem to be causing build failures so far.

Merge branch 'reefer' into 'main'

2024-11-14T19:17:16Z

DEFER See merge request apt-team/apt!392

Merge branch 'noref' into 'main'

2024-11-14T19:02:57Z

std::string_view const & -> std::string_view See merge request apt-team/apt!397

Merge branch 'append' into 'main'

2024-11-14T19:02:34Z

(+=)+= -> append().append() See merge request apt-team/apt!398

fdopen() failing does not close the fd

2024-11-14T18:23:26Z

DEFER() more

2024-11-14T18:22:39Z

(+=)+= -> append().append()

2024-11-14T18:08:42Z

DEFER

2024-11-14T17:45:16Z