apt/apt-pkg, branch 2.9.18Debians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=2.9.182024-12-17T18:21:21Zgpgv: Extract VerifyDetachedSignatureFile()2024-12-17T18:21:21ZJulian Andres Klodejak@debian.org2024-12-17T18:20:50Zurn:sha1:f54a561bc81d1bcbce6a107ad535f0c6d6e88d38
This is a pretty standalone function, extract it for later
reuse.
Fix out-of-bounds read in `apt show :`2024-12-16T12:15:28ZJulian Andres Klodejak@debian.org2024-12-16T12:15:28Zurn:sha1:19000fab15ab0b30c95a1bf6e034aa3c6bdc36cb
We tried to access str.size() - 1 on a 0-sized string, which
does not work, and now that we build with assertions triggers
it.
Closes: #1090068
gpgv: Drop references to apt-key2024-12-07T14:14:33ZJulian Andres Klodejulian.klode@canonical.com2024-12-04T10:12:34Zurn:sha1:2f9775ed580656214e62e7916ee896776fabc9e7gpgv: Merge all keyrings into a single one again2024-12-04T09:14:44ZJulian Andres Klodejulian.klode@canonical.com2024-12-04T08:56:58Zurn:sha1:48e5af8b5df391e62657b604b2b54885f7ce1c02
gpgv is quite picky, it takes at most 40 keyrings but it also doesn't
even take keyrings with : in the name, generating an ERROR message
instead.
So instead let's always merge the configured keyrings for the source
into a single one.
While we are at it, since we are merging now, let's also add some
rudimentary error checking to what we write into the merged keyring:
If copying into it fails, we should abort.
Reported-by: SuShY on IRC
solver3: Reject all non-candidates outright for strict pinning2024-12-03T08:44:18ZJulian Andres Klodejulian.klode@canonical.com2024-11-02T11:45:07Zurn:sha1:8f317d97c9fb821e839342ae445c824207678eb7
Reimplement strict pinning by rejecting the non-candidates when
translating the problem from the depcache to the solver. This is
substantially better than restricting the list of alternatives for
an or group to only include allowed ones for debugging purposes,
albeit a bit slower.
solver3: Add a missing debug level check2024-12-03T08:44:18ZJulian Andres Klodejulian.klode@canonical.com2024-12-03T08:43:34Zurn:sha1:3e5977ed7b4e6291fcd67df193a501754ec1de7fsolver3: Fix intransitivity of version comparison on upgrade2024-12-02T10:37:16ZJulian Andres Klodejulian.klode@canonical.com2024-12-02T09:25:44Zurn:sha1:63721d8271430c1a0996c08cc96a3a7e6f69dc52
We only compared candidate to installed version, but candidate
should dominate all versions, otherwise we end up in the fancy
problem of elpa-notmuch in
upgrade-noble-t64-remove-desktop-2024-03-29.edsp
Where we had three versions:
not-installable 0.38.3-1ubuntu1
candidate 0.38.2-1.1ubuntu2
installed 0.38.2-1ubuntu2
And received an ordering:
installed > non-installable > candidate
despite
candidate > installed
This is only visible with no-strict-pinning right now, as we are
otherwise filtering out invalid choices (and hence we only have
candidate and installed otherwise).
Avoid extension check for .gpg2024-11-29T08:38:00ZJulian Andres Klodejulian.klode@canonical.com2024-11-29T08:38:00Zurn:sha1:00b4aa9c1d7f50a6e45c72e7a7c417975932cabb
We only ever documented .gpg and .asc and have ensured that
only such files exist in the keyring, but people can set the
Signed-By option to keys with any random extension, as that
was not validated before by apt-key.
This doesn't change the behavior for trusted.gpg.d: We filter
the directory listing and only look at .gpg and .asc files.
Closes: #1088656
Detect working gpgv using gpgv --dump-options2024-11-28T18:01:36ZJulian Andres Klodejak@debian.org2024-11-28T08:55:57Zurn:sha1:86f8353ce7a343db7b19422db0d37379ac45ff4e
This gains us support for not using an absolute path, which
is nice, and we can now cache the invocation across fork() in
the method.
Still keep preferring absolute paths, this avoids execvp() having
to iterate the path and reduces bug potential with custom gpgv in
/usr/local.
Fix the last entry in the list of gpgvs to say gpgv1
fileutl: Use execvp() in Popen() instead of execv()2024-11-28T18:01:36ZJulian Andres Klodejak@debian.org2024-11-28T08:49:58Zurn:sha1:7038347919d59b2f96a8f51f994889a5b4d66cba