Debians commandline package manager https://git.kalnischkies.de/apt/atom?h=2.9.3 2024-05-14T09:56:18Z 2024-05-14T09:56:18Z Julian Andres Klode julian.klode@canonical.com 2024-05-06T13:34:33Z urn:sha1:89dcc342e17dd2439d97a5d27200cf5c26ba35bc This is a simple backtracking brute-force solver with heurisitcs, this initial version has the following known gaps: - Errors are not kept from branches, the error reporting after backtracking isn't particularly useful. - We cannot show automatically removed packages - We cannot replace packages with others - We do not have conflict-driven clause learning yet Untested: - Multi-arch This solver is fundamentally different in key aspects: - It solves smaller dependency groups before larger ones, leading us to avoid installing A in A|B if B is installed more often and more consistently. - It only keeps the automatic packages reachable via the strongest path. Currently it only implements autoremoval, but not display of autoremoval as we simply enqueue all automatically installed packages at the end when not doing automatic removal. This will need some translation where we Solve() first, and then Solve() again with the automatically installed packages added such that we can mark them as Garbage for display purposes. - It does not remove manually installed packages. Hook the solver in via the EDSP framework, this allows us to achieve easy initial integration without lots of issues. A lot of this work was planned and executed in my free time and then some leaked into work time I suppose. Implementation notes: - Restore the full backlog of items The annoying thing is that we record only when an item was enqueued and not the level at which it was installed, so when going back a decision level we might have to reinstall packages that were queued at an earlier decision level because they were only installed at a later decision level. - When picking one version, reject the others - Propagate conflicts up to reverse dependencies This will recursively mark every reverse dependency that can no longer be satisfied as MUSTNOT. Also make sure to recursively call Reject(Ver) from Reject(Pkg) to make sure we trigger the Rejections there. This means we now end up having Recursion in the algorithm. An alternative approach would be to push *reject* items to the heap and then do them, but this is not entirely straight forward and it may simply not be necessary. - Sort upgrades before other optional installs containing subsets If I want to upgrade a package A, I schedule A3|A2|A1; if another thing depends specifically on A1; we'd not be installed. Hence we need to sort upgrades first. This only is needed for optional packages; manual packages will figure this out naturally. - Rescoring is lazily implemented. Instead of calling make_heap() after rescoring items, we just mark the items as dirty and reinsert them. We also only rescore from the main solve loop, Reject() marks the heap as needing a rescore due to a Conflict (as some versions will no longer be installable), and RescoreWorkIfNeeded() then will do the rescoring. - Recursive unit propagation: Install() and Reject() recursively call each other to promote decisions across single-version dependencies (or across not-anymore satisfiable reverse-depends). - Make Reason constructors explicit, this enhances readability This makes calls like the one in here be Reject(object, Reason(otherObject)) Ensuring that it's clear that the 2nd argument is a reason at the caller side. - Split Decision into Decision and Hint vs. first draft When branching/deciding, we do not want to override SHOULD and MAY. We do not actually use them yet, and we do actually clean them when backtracking, but let's at least keep the data structure correct. Convert the enum to a 16-bit integer so we can still fit in the same space as before. 2024-04-26T20:10:30Z David Kalnischkies david@kalnischkies.de 2024-04-26T18:50:49Z urn:sha1:c98bcdf00e5366fec101dd17094d36be21872a02 If dpkg-gencontrol was involved in the creation of a package we will not usually encounter empty or otherwise useless fields, but apparently not everyone is using it. It isn't recommended to have these empty lines, but it isn't too hard to ignore for Provides as we did for dependencies already and apt-ftparchive can be convinced to produce empty files (if you feed it such a package) as well, so lets be nice and provide users with a more accepting parser. Closes: #1069874 2024-04-24T13:16:21Z David Kalnischkies david@kalnischkies.de 2024-03-14T20:59:10Z urn:sha1:d030a1041b243c45dcd41e34d3c2b21cf1a533ba We schedule reverse dependencies for an upgrade, but we shouldn't do it if we have ear-marked this package for removal later on. Usually the solver will end up doing the right thing like it already did in the included testcase in the end, but given that before it reaches the right end it explored a bad path which can lead to more installs and removals influencing later decisions or are just too hard for the resolver to undo later on, we can just not explore this path to begin with. References: e077370ffcb3669a50a600e80356c2002e6b176d 2024-04-24T13:16:21Z David Kalnischkies david@kalnischkies.de 2024-04-05T14:02:39Z urn:sha1:3e24f431d9527816820e103df7db9f39062b551d Ignoring errors might lead to failures later on anyhow, but especially with triehash it could also lead to broken builds or other crazy stuff, so lets better be save than sorry. 2024-04-23T19:02:30Z Julian Andres Klode julian.klode@canonical.com 2024-04-23T19:01:45Z urn:sha1:edfbc3869361f709d70794a794199ac2076ea9f1 This turned out to be a bit too bold for most of them, given their informational nature. 2024-04-22T17:39:08Z Julian Andres Klode julian.klode@canonical.com 2024-04-22T17:39:08Z urn:sha1:cbb6f72b868cf7f50bd148479f7604f21964d239 2024-04-22T17:31:46Z Julian Andres Klode jak@debian.org 2024-04-22T17:31:46Z urn:sha1:20ab001670226e92ca8a74f1e2308197111a8420 UI changes for 2.9.2 See merge request apt-team/apt!343 2024-04-19T18:54:54Z Julian Andres Klode julian.klode@canonical.com 2024-01-23T18:01:34Z urn:sha1:858a551b50ea3871748d9196896e54b361c3d545 2024-04-19T18:49:05Z Julian Andres Klode julian.klode@canonical.com 2024-04-15T15:51:26Z urn:sha1:ae1ff72fbee8b3f5d063e8baa86a64e3da11aeb2 We should pass this properly to the TagSection.write() 2024-04-19T18:49:05Z Julian Andres Klode julian.klode@canonical.com 2024-04-15T14:51:32Z urn:sha1:dc3f3ec100f275e5a802e59fd160f75cd262845f This allows these bits to be localized, improving user experience for users in different languages.