apt/apt-pkg, branch 3.1.9Debians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=3.1.92025-10-20T18:26:49ZCorrectly append or remove FD_CLOEXEC2025-10-20T18:26:49ZJulian Andres Klodejak@debian.org2025-10-20T18:26:49Zurn:sha1:bb1e6834e8a1cd6fd5b88b5a1962e9d813a080fc
Rather than just setting the flags to 0 or FD_CLOEXEC, read
the current value and append or remove as needed.
ExecFork: Simplify closing and make it safe2025-10-20T18:06:50ZJulian Andres Klodejak@debian.org2025-10-20T18:02:17Zurn:sha1:3dea3434bf2003b757d7ecdb5a8194c8a0c7023f
Implement a wrapper around FD_CLOEXEC and use it in place of
the raw fcntl(). This wrapper _Exit()s the child if the operation
failed.
Restructure the close_range() handling to simply mark all fds for
closing first and then "reopen" the ones we should keep.
Add some comments and tests around Keep-Fd ordering2025-10-20T17:42:57ZJulian Andres Klodejak@debian.org2025-10-20T17:41:57Zurn:sha1:cb8df17ff8e59192ae2ab864006eea120d408a7aExecFork: Use close_range() if available2025-10-20T15:16:45ZJulian Andres Klodejak@debian.org2025-10-20T15:14:31Zurn:sha1:6aca3716f051b5b6bff63d51fff68b9c7ebc7474
Use close_range() if we have it in preference to iterating
over /proc/self/fd and falling back to closing all possible
fds.
This builds sets of ranges to close that take into account
the APT::Keep-Fds vector, and a test case is provided to
ensure correctness of the splitting logic.
Preference is given to close_range() over /proc as in the
optimal case, this results in a single system call!
Move "Tried to start delayed item […], but failed" to debugging2025-10-04T12:29:17ZJulian Andres Klodejak@debian.org2025-10-04T12:28:01Zurn:sha1:02ee82958b5caef9efb49992870d149907869893
We don't quite know why a stuck queue cannot get unstuck here,
and it's possible that this is causing the queue to stall, but
shrug.
Closes: #1111554
Add history undo, redo, and rollback features2025-10-02T10:49:58ZSimon Johnssonsimon.johnsson@canonical.com2025-10-02T10:49:58Zurn:sha1:a65dca5d5e9b4bc71722bc91a5641126a1b0ec61History Command and Parsing2025-09-26T16:18:42ZSimon Johnssonsimon.johnsson@canonical.com2025-09-26T16:18:42Zurn:sha1:66962bee233b617e4a9ce436f9b26875511b35e6edsp: Do not skip lines (fixes Architecture reading)2025-08-26T11:52:57ZJulian Andres Klodejak@debian.org2025-05-25T12:46:45Zurn:sha1:171c469927b1b7c5a4f81f113081985e7dc84597
We skipped the Architecture: line because when the outer
loop got to it, the inner loop started and read the next
line after it.
Get rid of the nested loop instead, and first run a loop
to find the request line, and then a second loop to parse
the request flags.
An alternative would be to use a combined loop that
supports non-compliant protocol implementations, but
that's harder to read and we don't expect there to be
any especially on the request side.
edsp: Clear architecture cache2025-08-26T11:52:57ZJulian Andres Klodejak@debian.org2025-05-25T12:16:53Zurn:sha1:82cc584ee916df6bc558559b62863b34b069a710
We need to actually use the architecture values we set
Fix indentation compiler warning with clang2025-08-26T11:51:04ZBiswapriyo Nathnathbappai@gmail.com2025-06-18T19:39:15Zurn:sha1:f3c5d176d6d0c91ff2cc80f12eed43a664d3d779
This commit fixes the following compiler warning.
cacheiterators.h:423:54: warning: misleading indentation;
statement is not part of the previous 'if' [-Wmisleading-indentation]