apt/apt-pkg, branch 3.3.0Debians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=3.3.02026-05-01T16:39:24ZAvoid ABI break for transaction cancellation2026-05-01T16:39:24ZJulian Andres Klodejak@debian.org2026-05-01T16:21:41Zurn:sha1:186ea76de09ef2f298f62d518a57d0567d2c0075apt-pkg: methods: fixed many minor memleaks2026-05-01T16:27:11ZHerman SemenoffGermanAizek@yandex.ru2026-04-08T10:09:52Zurn:sha1:e79f9bb22375fd72330b534e17dcd3ceace432e8
Static analysis has shown that there are many minor memleaks.
pkgAcqMetaBase: Commit InRelease after other transaction items2026-05-01T16:12:00ZSebastian Krzyszkowiaksebastian.krzyszkowiak@puri.sm2026-03-19T19:20:01Zurn:sha1:244bf4d107d7f17eb7a21b036717a161618387ae
If apt update is interrupted during transaction commit, the system may
end up with updated InRelease that does not match the other list files,
which can cause apt to believe that the lists are already up-to-date when
they are in fact not.
Closes: #1078608
pkgAcqMetaClearSig: Abort transaction when pkgAcquire::Run has been cancelled2026-05-01T16:12:00ZSebastian Krzyszkowiaksebastian.krzyszkowiak@puri.sm2026-03-19T19:13:55Zurn:sha1:dcc690d7e08f6d54fc10ee372510875a41ec9a3b
Ongoing Run can be cancelled by returning false from ::Pulse(). In this case
the items would still be called pkgAcquire::Item::Finished() as usual, causing
pkgAcqMetaClearSig to commit the incomplete transaction anyway as at that
point it's still Started and has no errors.
Add a pkgAcquire::Item::Cancelled() method and use it in pkgAcqMetaClearSig
to abort the transaction.
Closes: #1078608
acquire-item: Fix up the error message on committing aborted transaction2026-05-01T16:12:00ZSebastian Krzyszkowiaksebastian.krzyszkowiak@puri.sm2026-03-19T19:07:57Zurn:sha1:98cfa47c7437da0cf3fbb89aec9f38ea70d0a5deapt: modernize to make_unique C++172026-04-08T10:41:43ZHerman SemenoffGermanAizek@yandex.ru2026-04-08T09:58:55Zurn:sha1:23dba65f031954df896bc3c6dfb1a9705574886b
References:
- https://stackoverflow.com/questions/79700634/pros-and-cons-of-make-unique-vs-direct-constructor-call-in-c17
- https://towardsdev.com/why-std-make-unique-beats-new-in-modern-c-7e2ba653737e
- https://www.sololearn.com/en/Discuss/3334779/where-make_unique-is-better-than-unique_ptrraw-pointer
apt: push to emplace C++11 if possible2026-04-08T10:40:55ZHerman SemenoffGermanAizek@yandex.ru2026-04-08T08:51:08Zurn:sha1:ef70431f02e2ec13ecedab7ac342574e52d1877b
References:
- https://www.reddit.com/r/cpp_questions/comments/pm63yx/why_clangtidy_says_use_emplace_back_instead_of/
- https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-emplace.html
apt-pkg/acquire: use range based for loop C++172026-04-08T10:26:20ZHerman SemenoffGermanAizek@yandex.ru2026-04-08T08:11:41Zurn:sha1:df63b982447f1a8f699e6547352cd04d00242c9bapt: funcs called with a string literal consisting of a single character2026-04-08T08:37:24ZHerman SemenoffGermanAizek@yandex.ru2026-04-08T08:37:24Zurn:sha1:af5b9453a1908021cf75c348522c1a12eeb0dee4
Benchmark:
- https://stackoverflow.com/questions/62058906/why-my-performance-benchmark-gives-me-wrong-results
References:
- https://clang.llvm.org/extra/clang-tidy/checks/performance/prefer-single-char-overloads.html
hashes: Use std::span instead of std::basic_string_view2026-04-07T09:46:07ZJulian Andres Klodejak@debian.org2026-04-07T09:46:07Zurn:sha1:f2c87504c4c3517a8420d789e40411f74fe45e19
std::basic_string_view should not be initialized locally, only
in the std library. Replace it with a simple span instead.
This should fix compilation with LLVM 18+.
Supersedes: https://salsa.debian.org/apt-team/apt/-/merge_requests/511