apt/apt-private/acqprogress.cc, branch 1.2.10Debians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=1.2.102015-11-05T11:21:33Zapply various suggestions made by cppcheck2015-11-05T11:21:33ZDavid Kalnischkiesdavid@kalnischkies.de2015-11-04T20:08:55Zurn:sha1:258b9e512c4001e806c5c0966acecd3d742ec6e9
Reported-By: cppcheck
Git-Dch: Ignore
new quiet level -qq for apt to hide progress output2015-11-04T17:04:03ZDavid Kalnischkiesdavid@kalnischkies.de2015-10-25T11:35:00Zurn:sha1:2b0660b537581e9e65180e4cf1a94d763fd66847
-q is for logging and -qqq (old -qq) basically kills every output expect
errors, so there should be a way of declaring a middleground in which
the output of e.g. 'update' isn't as verbose, but still shows some
things. The test framework was actually making use of by accident as it
ignored the quiet level in output setup for apt before.
Eventually we should figure out some better quiet levels for all tools…
Replace all "press enter" occurrences with "press [Enter]"2015-08-12T09:55:47ZLuca Brunolethalman88@gmail.com2015-08-11T18:08:43Zurn:sha1:94171725b18be91ddcc2530c5fe5f40e78d041c1
Thanks: Andre Felipe Machado for initial patch
Closes: 414848
condense parallel requests with the same hashes to one2015-06-15T21:35:55ZDavid Kalnischkiesdavid@kalnischkies.de2015-06-15T21:06:56Zurn:sha1:9d2a8a7388cf3b0bbbe92f6b0b30a533e1167f40
It shouldn't be too common, but sometimes people have multiple mirrors
in the sources or otherwise repositories with the same content. Now that
we gracefully can handle multiple requests to the same URI, we can also
fold multiple requests with the same expected hashes into one. Note that
this isn't trying to find oppertunities for merging, but just merges if
it happens to encounter the oppertunity for it.
This is most obvious in the new testcase actually as it needs to delay
the action to give the acquire system enough time to figure out that
they can be merged.
show item ID in Hit, Ign and Err lines as well2015-06-15T21:35:55ZDavid Kalnischkiesdavid@kalnischkies.de2015-06-15T14:41:43Zurn:sha1:1eb1836f4b5397497bd34f0cf516e6e4e73117bf
Again, consistency is the main sellingpoint here, but this way it is now
also easier to explain that some files move through different stages and
lines are printed for them hence multiple times: That is a bit hard to
believe if the number is changing all the time, but now that it keeps
consistent.
add a simple unit test for acquire progress2015-04-10T20:29:08ZDavid Kalnischkiesdavid@kalnischkies.de2015-03-15T21:34:54Zurn:sha1:dfad5beea77d75983f6ff8a1b8296b74dd48203e
This isn't testing much of the 'complex' parts,
but its better than nothing for now.
Git-Dch: Ignore
reimplement the last uses of sprintf2015-04-10T18:18:17ZDavid Kalnischkiesdavid@kalnischkies.de2015-03-10T13:11:54Zurn:sha1:b8eba208daebe3e3f235983e44da9c398d6f7a57
Working with strings c-style is complicated and error-prune,
so by converting to c++ style we gain some simplicity and
avoid buffer overflows by later extensions.
Git-Dch: Ignore
don't show ErrorText for Ign by default2014-10-07T19:08:37ZDavid Kalnischkiesdavid@kalnischkies.de2014-10-07T18:51:07Zurn:sha1:d6cf2345a35896448e19bfb294ffe66faab00f86
Some distributions (or repositories) do not have as much
"Ign-discipline" as I would like to, so that could be pretty distracting
for our users if enabled by default. It is handy for testcases though.
Git-Dch: Ignore
display errortext for all Err as well as Ign logs2014-10-07T00:26:58ZDavid Kalnischkiesdavid@kalnischkies.de2014-10-06T23:46:30Zurn:sha1:4dbfe436c60880f2625e4d3a9d0127a83dd6276e
consistently using Item::Failed in all specializec classes helps setting
up some information bits otherwise unset, so some errors had an empty
reason as an error. Ign is upgraded to display the error message we
ignored to further help in understanding what happens.
replace c-string Mode with c++-string ActiveSubprocess2014-09-27T23:57:49ZDavid Kalnischkiesdavid@kalnischkies.de2014-09-27T23:57:49Zurn:sha1:ffbe056dc554b3f1fdf79b4726415a70f6d59dc1
A long-lasting FIXME in the acquire code points out the problem that we
e.g. for decompressors assign c-string representations of c++-strings to
the Mode variable, which e.g. cppcheck points out as very bad.
In practice, nothing major happens as the c++-strings do not run out of
scope until Mode would do, but that is bad style and fragile, so the
obvious proper fix is to use a c++ string for storage to begin with.
The slight complications stems from the fact that progress reporting
code in frontends potentially uses Mode and compares it with NULL, which
can't be done with std::string, so instead of just changing the type we
introduce a new variable and deprecate the old one.
Git-Dch: Ignore