apt/apt-private/acqprogress.cc, branch 2.9.19Debians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=2.9.192024-11-22T20:05:35ZCollect unprinted Ign errors for display in Err output2024-11-22T20:05:35ZDavid Kalnischkiesdavid@kalnischkies.de2024-11-22T17:59:48Zurn:sha1:a732f74400147a9993358b4778335715a0d5e20e
Instead of deciding if the first or the last error in a retry chain is
the best one to display if the entire chain fails in the end we teach
our progress reporting to collect the ignored errors (if it hasn't shown
them) and print them all together in the Err line.
We de-duplicate the collection which makes it harder to match the Ign
line with the error messages, but for these cases its probably better to
enable direct display of the text anyhow – and repeating the same message
multiple times is boring and probably not that helpful for a user
wanting to know why all the downloads failed even they asked apt to
retry 429 times…
References: 841243df877b39dfcb907a7fab9c4e8b4f65d715
Use APT::Configuration::color to apply color to output2024-04-19T14:58:24ZJulian Andres Klodejulian.klode@canonical.com2024-04-19T14:05:08Zurn:sha1:e07450beb5a474ec3c099ff3eb329892b040d04cModernize standard library includes2024-02-20T12:49:04ZJulian Andres Klodejulian.klode@canonical.com2024-02-20T12:43:08Zurn:sha1:40a75722c43ae24cb9a99d6730a3b25b65819c49
This was automated with sed and git-clang-format, and then I had to
fix up the top of policy.cc by hand as git-clang-format accidentally
indented it by two spaces.
Avoid infinite loop on EOF on media change prompt2021-04-23T13:04:32ZJulian Andres Klodejulian.klode@canonical.com2021-04-23T13:01:07Zurn:sha1:94cf53979640ff8a29d445a2b056a6b17c7b3e49
The code missed a break, so it was looping infinitely because
the while loop condition only checked for '\n' and '\r', but not
end of file.
acq: worker: Move CurrentSize, TotalSize, ResumePoint to CurrentItem2019-04-30T15:40:38ZJulian Andres Klodejulian.klode@canonical.com2019-04-29T18:05:38Zurn:sha1:cccef6ca60c2775e918d964fdad1afc1dcad4d0e
These status fields belong to the current item, move them there. This
prepares us for eventually having multiple current items.
acquire: Fold pkgAcquireStatus2 into pkgAcquireStatus2019-02-26T15:31:20ZJulian Andres Klodejulian.klode@canonical.com2019-02-26T11:42:42Zurn:sha1:91e1f7d49830289d8e9d3fdd7ebbe7544a9838b8
Clean up the code, make it neat, lalala
Reformat and sort all includes with clang-format2017-07-12T11:57:51ZJulian Andres Klodejak@debian.org2017-07-12T11:40:41Zurn:sha1:87274d0f22e1dfd99b2e5200e2fe75c1b804eac3
This makes it easier to see which headers includes what.
The changes were done by running
git grep -l '#\s*include' \
| grep -E '.(cc|h)$' \
| xargs sed -i -E 's/(^\s*)#(\s*)include/\1#\2 include/'
To modify all include lines by adding a space, and then running
./git-clang-format.sh.
ask for releaseinfo change interactively in apt2017-06-28T17:18:47ZDavid Kalnischkiesdavid@kalnischkies.de2017-05-28T15:44:11Zurn:sha1:24b5bc4e41ed527799a9fa01dec9c29294d0a3f2
If we have a user sitting around we can let 'apt' ask the user for a
confirmation rather than print errors at the end and require the user to
figure out which commandline flags are needed to confirm the changes
non-interactively.
prevent C++ locale number formatting in text APIs (try 2)2016-07-30T08:14:47ZDavid Kalnischkiesdavid@kalnischkies.de2016-07-30T07:57:50Zurn:sha1:7303e11ff28f920a6277c159aa46f80c007350bb
Followup of b58e2c7c56b1416a343e81f9f80cb1f02c128e25.
Still a regression of sorts of 8b79c94af7f7cf2e5e5342294bc6e5a908cacabf.
Closes: 832044
format multiline errors properly in acquire progress2016-04-25T13:35:52ZDavid Kalnischkiesdavid@kalnischkies.de2016-03-12T17:05:55Zurn:sha1:6563390031a88ffd85308ac3c26ea9d10bc6bc99
Together with the GlobalError change this allows us to add errors
spanning multiple lines, just that we control GlobalError while the
acquire progress is dealt with potentially by individual clients which
might or might not need to be adapted.
This isn't critical through as it either just works as expected anyhow
or is a minor styling thing (after all, all this commit does it add two
spaces to indent the lines a bit…).