apt/apt-private/acqprogress.h, branch 2.9.22Debians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=2.9.222025-01-05T22:16:08ZDrop usage of macro APT_OVERRIDE for simple override2025-01-05T22:16:08ZDavid Kalnischkiesdavid@kalnischkies.de2024-12-26T19:41:53Zurn:sha1:f73593a4034d9eec0ec4466b8e173d4a4daece1f
We were rather inconsistent in using it and as our public headers
contain deduction guides (a c++17 feature) it seems silly to try to hide
a c++11 feature in a macro, so lets stop this charade and drop the
macro and while we are changing all these lines lets apply [[nodiscard]]
(another c++17 feature) and other suggestions from clang-tidy and
formatting for a little more consistency.
Collect unprinted Ign errors for display in Err output2024-11-22T20:05:35ZDavid Kalnischkiesdavid@kalnischkies.de2024-11-22T17:59:48Zurn:sha1:a732f74400147a9993358b4778335715a0d5e20e
Instead of deciding if the first or the last error in a retry chain is
the best one to display if the entire chain fails in the end we teach
our progress reporting to collect the ignored errors (if it hasn't shown
them) and print them all together in the Err line.
We de-duplicate the collection which makes it harder to match the Ign
line with the error messages, but for these cases its probably better to
enable direct display of the text anyhow – and repeating the same message
multiple times is boring and probably not that helpful for a user
wanting to know why all the downloads failed even they asked apt to
retry 429 times…
References: 841243df877b39dfcb907a7fab9c4e8b4f65d715
acquire: Fold pkgAcquireStatus2 into pkgAcquireStatus2019-02-26T15:31:20ZJulian Andres Klodejulian.klode@canonical.com2019-02-26T11:42:42Zurn:sha1:91e1f7d49830289d8e9d3fdd7ebbe7544a9838b8
Clean up the code, make it neat, lalala
Reformat and sort all includes with clang-format2017-07-12T11:57:51ZJulian Andres Klodejak@debian.org2017-07-12T11:40:41Zurn:sha1:87274d0f22e1dfd99b2e5200e2fe75c1b804eac3
This makes it easier to see which headers includes what.
The changes were done by running
git grep -l '#\s*include' \
| grep -E '.(cc|h)$' \
| xargs sed -i -E 's/(^\s*)#(\s*)include/\1#\2 include/'
To modify all include lines by adding a space, and then running
./git-clang-format.sh.
ask for releaseinfo change interactively in apt2017-06-28T17:18:47ZDavid Kalnischkiesdavid@kalnischkies.de2017-05-28T15:44:11Zurn:sha1:24b5bc4e41ed527799a9fa01dec9c29294d0a3f2
If we have a user sitting around we can let 'apt' ask the user for a
confirmation rather than print errors at the end and require the user to
figure out which commandline flags are needed to confirm the changes
non-interactively.
add c++11 override marker to overridden methods2015-08-10T15:27:17ZDavid Kalnischkiesdavid@kalnischkies.de2015-07-08T22:35:40Zurn:sha1:3b3028467ceccca0b73a8f53051c0fa4de313111
C++11 adds the 'override' specifier to mark that a method is overriding
a base class method and error out if not. We hide it in the APT_OVERRIDE
macro to ensure that we keep compiling in pre-c++11 standards.
Reported-By: clang-modernize -add-override -override-macros
Git-Dch: Ignore
show item ID in Hit, Ign and Err lines as well2015-06-15T21:35:55ZDavid Kalnischkiesdavid@kalnischkies.de2015-06-15T14:41:43Zurn:sha1:1eb1836f4b5397497bd34f0cf516e6e4e73117bf
Again, consistency is the main sellingpoint here, but this way it is now
also easier to explain that some files move through different stages and
lines are printed for them hence multiple times: That is a bit hard to
believe if the number is changing all the time, but now that it keeps
consistent.
add a simple unit test for acquire progress2015-04-10T20:29:08ZDavid Kalnischkiesdavid@kalnischkies.de2015-03-15T21:34:54Zurn:sha1:dfad5beea77d75983f6ff8a1b8296b74dd48203e
This isn't testing much of the 'complex' parts,
but its better than nothing for now.
Git-Dch: Ignore
reimplement the last uses of sprintf2015-04-10T18:18:17ZDavid Kalnischkiesdavid@kalnischkies.de2015-03-10T13:11:54Zurn:sha1:b8eba208daebe3e3f235983e44da9c398d6f7a57
Working with strings c-style is complicated and error-prune,
so by converting to c++ style we gain some simplicity and
avoid buffer overflows by later extensions.
Git-Dch: Ignore
enable fvisibility=hidden for our private library2014-03-21T14:54:15ZDavid Kalnischkiesdavid@kalnischkies.de2014-03-21T14:54:15Zurn:sha1:63ff42089863cda53aee240ea0124106e8b4d983
While it is a huge undertaking to enable it for our public libraries as
basically everything we exported so far could be seen as public
interface our private library is new and under our full control, so we
can do whatever we like with it. The benefits are not that big in return
of course, but it reduces the size a bit, so thats great nontheless.
Git-Dch: ignore