apt/apt-private/private-install.cc, branch 2.9.35Debians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=2.9.352025-03-26T15:47:37Zsolver3: Correctly deb822-escape error message in evaluation report2025-03-26T15:47:37ZJulian Andres Klodejulian.klode@canonical.com2025-03-26T15:44:06Zurn:sha1:6e5d8929c06cb645e639022477a14ca65d483e32
The error messages are multi-line now, so need correct escaping.
LP: #2104276
solver3: Avoid empty error message in evaluation crash report2025-03-20T14:18:05ZJulian Andres Klodejulian.klode@canonical.com2025-03-20T14:16:58Zurn:sha1:61b3b1840568b223baad08da1eb9a1fb5d6e7f91
whoopsie does not accept empty values
solver3: Use zstd-compressed, base64-encoded dumps2025-03-20T14:09:56ZJulian Andres Klodejulian.klode@canonical.com2025-03-20T14:03:23Zurn:sha1:a2cb87afcbc89d1f8e770c26121a75d9c1654458
Store the solver dumps with zstd compression and base64-encode
them in the crash report; such that they take up significantly
less space and can fit in cassandra's schema.
Base64 is wrapped at 76 characters as the base64 tool does. Do
some magic std::string_view conversion to avoid string copies
for the substr() used to get 76 characters at a time.
Note we can rely on substr(i, 76) to handle less than 76 characters
just fine; it uses std::min(76, size() - i) characters.
solver evaluation: write minimized solver dumps2025-03-20T09:26:51ZJulian Andres Klodejulian.klode@canonical.com2025-03-13T14:20:49Zurn:sha1:c741e4f3bc7143031f70b5a353aafc004d26c220
These are faster to generate and significantly smaller.
Print --solver 3.0 explanation if both internal and it failed2025-03-09T12:55:23ZJulian Andres Klodejulian.klode@canonical.com2025-03-09T12:55:23Zurn:sha1:6c112f9860c1730237029f4e23d40bf658d73704
This can provide useful additional context.
To avoid updating the whole test suite for it, introduce a new
option `quiet::NoSolver3Explanation` and set it by default. All
the other tests that assert output will already have matching
tests for --solver 3.0 with the correct messages asserted, it
makes no sense to duplicate them.
Evaluate and fall back to the 3.0 solver2025-03-09T12:33:53ZJulian Andres Klodejulian.klode@canonical.com2025-02-18T12:06:32Zurn:sha1:935a9ab334e55a29363f45e7de6338c47337e806
Always run the 3.0 solver after the internal solver. If the internal
solver failed, and the 3.0 solver did not, use the 3.0 result.
If 3.0 solver failed or produced a worse result than the internal
solver, write an apport crash dump.
We exclude situations which we now the solver can't handle, i.e.
removals are forbidden and you requested removals, and stuff like
that.
Measure BootSize as integer2025-02-03T12:40:37ZJulian Andres Klodejulian.klode@canonical.com2025-02-03T12:19:12Zurn:sha1:452586e84ad54ca23dee399bf9809c49e7171f36
I don't know why I used a double here this is awkward.
Acknowledge non-erase usage of remove_if for volatile sources2024-11-22T12:11:13ZDavid Kalnischkiesdavid@kalnischkies.de2024-09-11T16:57:04Zurn:sha1:fa19a9ddbdddeaed44480ce7dade11d526336435
gcc produces a length warning starting with:
| warning: ignoring return value of ‘_FIter std::remove_if(_FIter, _FIter, _Predicate) [with …]’, declared with attribute ‘nodiscard’ [-Wunused-result]
which is usually correct, but in the usage here we don't want to call an
erase as we operate on a c-style new[] array here which contains pointers
into argv and has an explicit sentinel (nullptr) – FileSize() is based
on this sentinel.
Casting to void silences the warning as is standard practice and
hopefully indicates better that this is intended than ignoring the
warning for the casual on-looker.
Show installed version (not candidate version) while removing a package2024-07-05T04:27:32Zsidsidtosh4@gmail.com2024-07-03T09:20:32Zurn:sha1:c575648f41ff09e72988976f8150e9bb51781cd4
Showing a package version which was never installed in removals is
confusing.
Do not save new if we have already installed providers2024-05-16T20:12:51ZDavid Kalnischkiesdavid@kalnischkies.de2024-05-16T14:51:28Zurn:sha1:f404c8e06e07c2a89efb0f1ba997a7f1c0c472db
Companion of the previous commit that uses the same reasoning, but from
the other side of the logic (as we start from reverse deps here) so that
we are dropping the useless NEW from the solution.
Ideally this code would not live in -private, but in -pkg, but there is
not really a pre-existent good central place for this currently as a
sort-of fixup for our default resolver given this is the result of
resolver decision to not do something which had ripple effects that
aren't reverted along with it.
It is a bit unlikely that this is fixing all instances that this bug
has given we have dealt with a few instances of it already as they are
relatively obscure situations to clean up after and the cost of being
wrong (= autoremover generating breaks) is much higher than being
correct (= no pointless install – that is likely installed later anyhow
after the temporary automatic hold is lifted). And by virtue of being
the result of mostly temporary situations its also unlikely to be
debugable in hindsight months later; so if there is another situation,
its better to deal with it in a new bugreport.
Closes: #839546