apt/apt-private/private-json-hooks.cc, branch 2.2.1Debians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=2.2.12019-07-08T13:51:17ZApply various suggestions by cppcheck2019-07-08T13:51:17ZDavid Kalnischkiesdavid@kalnischkies.de2019-07-08T13:48:59Zurn:sha1:2b734a7ec429825c7007c1093883229e069d36c7
Reported-By: cppcheck
Adjust code for missing includes/using std::string2019-06-12T13:02:55ZJulian Andres Klodejulian.klode@canonical.com2019-06-12T11:47:46Zurn:sha1:82b881caafa0c82b20db3900f8b76cebd8a393a4Add 'explicit' to most single argument constructors2019-04-30T15:43:31ZJulian Andres Klodejulian.klode@canonical.com2019-04-30T10:07:07Zurn:sha1:b52c6552c44fcb997b0db9f5e9f17b4674dd5359
This prevents implicit conversions that we do not want, such
as having a FileFd* being converted to a debListParser.
Two cases are not yet handled because they require changes
in code using them:
1. The classes in hashes.h
2. The URI class - this one is used quite a lot
private-json-hooks.cc: deal with EPIPE2019-01-29T09:17:33ZMichael Vogtmvo@ubuntu.com2019-01-29T09:17:33Zurn:sha1:6af48a7f83540c807be1d2777470d23e6b260eb8
While running our CI we noticed that sometimes we see an error
from the new json hooks code. The error message is:
```
E: Could not read response to hello message from hook [ ! -f /usr/bin/snap ] || /usr/bin/snap advise-snap --from-apt 2>/dev/null || true: Broken pipe
```
when purging the snapd package which provides the hook. This indicates
that we should probably also consider EPIPE not an error (just like
we do for ECONNRESET). This PR does exactly this.
Fix typo reported by codespell in code comments2018-11-25T16:38:31ZDavid Kalnischkiesdavid@kalnischkies.de2018-11-25T16:38:31Zurn:sha1:f313e09d167cc7a83846ac9d4d5d72ba10cc2638
No user visible change expect for some years old changelog entries,
so we don't really need to add a new one for this…
Reported-By: codespell
Gbp-Dch: Ignore
Handle JSON hooks that just close the file/exit and fix some other errors2018-06-27T13:09:45ZJulian Andres Klodejulian.klode@canonical.com2018-06-27T09:31:21Zurn:sha1:1d53cffad22c92645090e0e6ddde31fe4f7c3b05
JSON hooks might disappear and the common idiom to work around hooks
disappearing is to check for the hook in the shell snippet that is
in the apt.conf file and if it does not exist, do nothing. This caused
APT to fail however, expecting it to acknowledge the handshake.
Ignoring ECONNRESET on handshakes solves the problem.
The error case, and the other error cases also did not stop execution
of the hook, causing more errors to pile up. Fix this by directly going
to the closing part of the code.
LP: #1776218
Introduce experimental new hooks for command-line tools2018-04-15T19:11:42ZJulian Andres Klodejulian.klode@canonical.com2018-04-13T10:32:35Zurn:sha1:e9796b9c21ee7d8e8f5d6e2a24db43fc4368b557
This allows third-party package managers like snap or flatpak
to hook in and suggest alternatives if packages could not be
found, for example.
This is still highly experimental and the protocol might change
in future versions.