Debians commandline package manager https://git.kalnischkies.de/apt/atom?h=3.1.2 2025-01-05T22:16:08Z 2025-01-05T22:16:08Z David Kalnischkies david@kalnischkies.de 2024-12-26T19:41:53Z urn:sha1:f73593a4034d9eec0ec4466b8e173d4a4daece1f We were rather inconsistent in using it and as our public headers contain deduction guides (a c++17 feature) it seems silly to try to hide a c++11 feature in a macro, so lets stop this charade and drop the macro and while we are changing all these lines lets apply [[nodiscard]] (another c++17 feature) and other suggestions from clang-tidy and formatting for a little more consistency. 2024-12-18T09:25:24Z Julian Andres Klode jak@debian.org 2024-12-16T16:05:40Z urn:sha1:6e260e26e4cd671f781151e24d89a17b29a55530 Automatically show the output of `show`, `policy`, `list`, `search`, `showsrc` in a pager. The pager setup is inspired by git's pager setup. Notably, the pager is found using APT_PAGER and PAGER variables. We wait for the pager to be setup somewhat correctly by using a notify pipe to figure out whether execvp() was succesful - then the pipe will read EOF as the other end got closed by CLOEXEC during exec - or not, then the pipe will contain an errno. We set up the correct handlers for signals and exit to close the fds and wait for the pager. Notably inside the signal handler we cannot flush our streams, only close them, so there is some duplication. We call the InitOutputPager() function from inside the various Do...() functions rather than setting it up generally in InitOutput(). Doing so allows us to first render the progress without a pager, and then setup the pager for the content only which improves user experience. When we setup a pager we also take care to disable standard input, as we should not be prompting users while a pager is running (the pager will be reading from the tty directly). We do this by dup2-ing() a /dev/null over it; if we just close()d the fd, another open() might reuse the fd number and problems could occur. 2020-05-04T11:08:33Z Julian Andres Klode julian.klode@canonical.com 2020-05-04T11:08:33Z urn:sha1:c4f85bcb8bee1b5e647c7e629f616cffc7d12bbc Previously (and still in cacheset), patterns where only allowed to start with ? or ~, which ignores the fact that a pattern might just as well start with a negation, such a !~nfoo. Also, we ignored the --regex flag if it looked like this, which was somewhat bad. Let's change this all: * If --regex is given, arguments are always interpreted as regex * If it is a valid package wildcard (name or * characters), then it will be interpreted as a wildcard - this set of characters is free from meaningful overlap with patterns. * Otherwise, the argument is interpreted as a pattern. For a future version, we need to adapt parsing for cacheset and list to use a common parser, to avoid differences in their interpretation. Likely, this code will go into the pattern parser, such that it generates a pattern given a valid fnmatch argument for example. 2020-02-03T11:55:54Z Julian Andres Klode julian.klode@canonical.com 2020-01-20T13:14:49Z urn:sha1:fd43b1694f1382a3a47f5dc546ebe3d39fcd6e7d Also make pattern detector in cacheset and private's list accept such patterns. We probably should just try to parse and see if it is a (start of a) pattern. 2019-08-15T18:21:34Z Julian Andres Klode julian.klode@canonical.com 2019-08-15T09:47:00Z urn:sha1:08b61197f418883ea20563e2251fb60779c0ba87 This adds a transformation from parse tree into a CacheFilter and connects it with cachesets and the apt list command. 2018-09-15T15:45:16Z David Kalnischkies david@kalnischkies.de 2018-09-15T15:45:16Z urn:sha1:32e0587d1819ca4b09cd146b0114a1c56ce4a8a9 The uniqueness in std::set containers is ensured by the ordering operator we provide, but it was not considering that different versions can have the same description like the different architectures for a version of a package. Closes: #908218 2017-07-12T11:57:51Z Julian Andres Klode jak@debian.org 2017-07-12T11:40:41Z urn:sha1:87274d0f22e1dfd99b2e5200e2fe75c1b804eac3 This makes it easier to see which headers includes what. The changes were done by running git grep -l '#\s*include' \ | grep -E '.(cc|h)$' \ | xargs sed -i -E 's/(^\s*)#(\s*)include/\1#\2 include/' To modify all include lines by adding a space, and then running ./git-clang-format.sh. 2017-07-12T11:56:05Z Julian Andres Klode jak@debian.org 2017-07-12T11:42:18Z urn:sha1:c46f94aa48a9707668c46118b3eec77ff318b78c Including cacheiterators.h before pkgcache.h fails because pkgcache.h depends on cacheiterators.h. 2016-05-20T07:37:24Z David Kalnischkies david@kalnischkies.de 2016-05-20T07:37:24Z urn:sha1:fdf9eef4d96a18d0167708499c993e1174251e88 The report mentions "apt list --upgradable", but there are others which have inconsistent behavior ranging from segfaulting to doing something with the partial (and hence incomplete) data. We had a recent report about sources.list (#818628), this one mentions prefences, the obvious next step is conf files… so the testcase is adapted to check for all three in file and directory versions and run a bunch of commands each time which should all have more or less the same behavior in such a case (aka error out). Closes: 824503 2015-11-05T11:21:33Z David Kalnischkies david@kalnischkies.de 2015-11-04T20:08:55Z urn:sha1:258b9e512c4001e806c5c0966acecd3d742ec6e9 Reported-By: cppcheck Git-Dch: Ignore