apt/apt-private/private-main.cc, branch 3.1.2Debians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=3.1.22024-12-18T09:25:24ZIntroduce automatic pager for read commands2024-12-18T09:25:24ZJulian Andres Klodejak@debian.org2024-12-16T16:05:40Zurn:sha1:6e260e26e4cd671f781151e24d89a17b29a55530
Automatically show the output of `show`, `policy`, `list`,
`search`, `showsrc` in a pager.
The pager setup is inspired by git's pager setup. Notably,
the pager is found using APT_PAGER and PAGER variables.
We wait for the pager to be setup somewhat correctly by
using a notify pipe to figure out whether execvp() was
succesful - then the pipe will read EOF as the other end
got closed by CLOEXEC during exec - or not, then the pipe
will contain an errno.
We set up the correct handlers for signals and exit to close
the fds and wait for the pager. Notably inside the signal
handler we cannot flush our streams, only close them, so
there is some duplication.
We call the InitOutputPager() function from inside the
various Do...() functions rather than setting it up
generally in InitOutput(). Doing so allows us to first
render the progress without a pager, and then setup
the pager for the content only which improves user
experience.
When we setup a pager we also take care to disable
standard input, as we should not be prompting users
while a pager is running (the pager will be reading
from the tty directly). We do this by dup2-ing() a
/dev/null over it; if we just close()d the fd, another
open() might reuse the fd number and problems could
occur.
Add note that redundant 'CLI interface' is intentional2024-07-28T01:54:05ZJulian Andres Klodejulian.klode@canonical.com2024-07-28T01:54:05Zurn:sha1:847c60af9eaa4b1dc3c6c3afa94bf494b721a1b7Insert blank line following simulation note2024-04-19T18:49:05ZJulian Andres Klodejulian.klode@canonical.com2024-04-15T16:19:44Zurn:sha1:cd1183f9965692834fa237be6114db0e6b413c41Modernize standard library includes2024-02-20T12:49:04ZJulian Andres Klodejulian.klode@canonical.com2024-02-20T12:43:08Zurn:sha1:40a75722c43ae24cb9a99d6730a3b25b65819c49
This was automated with sed and git-clang-format, and then I had to
fix up the top of policy.cc by hand as git-clang-format accidentally
indented it by two spaces.
Prepare rred binary for external usage2020-11-07T20:48:21ZDavid Kalnischkiesdavid@kalnischkies.de2020-11-07T20:23:57Zurn:sha1:9e1398b164f55238990907f63dfdef60588d9b24
Merging patches is a bit of non-trivial code we have for client-side
work, but as we support also server-side merging we can export this
functionality so that server software can reuse it.
Note that this just cleans up and makes rred behave a bit more like all
our other binaries by supporting setting configuration at runtime and
supporting --help and --version. If you can make due without this, the
now advertised functionality is provided already in earlier versions.
apt-private: Remove unused InitLocale() variant2019-02-26T15:31:20ZJulian Andres Klodejulian.klode@canonical.com2019-02-26T12:54:32Zurn:sha1:476d999847adf35ec35fd9c9b9233ac8b8aa1a17Reformat and sort all includes with clang-format2017-07-12T11:57:51ZJulian Andres Klodejak@debian.org2017-07-12T11:40:41Zurn:sha1:87274d0f22e1dfd99b2e5200e2fe75c1b804eac3
This makes it easier to see which headers includes what.
The changes were done by running
git grep -l '#\s*include' \
| grep -E '.(cc|h)$' \
| xargs sed -i -E 's/(^\s*)#(\s*)include/\1#\2 include/'
To modify all include lines by adding a space, and then running
./git-clang-format.sh.
eipp: let apt make a plan, not make stuff plane2016-06-29T10:17:41ZDavid Kalnischkiesdavid@kalnischkies.de2016-06-29T07:16:53Zurn:sha1:8e99b22c31eb47d0422e9a69e83dc99bb315ded8
Julian noticed on IRC that I fall victim to a lovely false friend by
calling referring to a 'planer' all the time even through these are
machines to e.g. remove splinters from woodwork ("make stuff plane").
The term I meant is written in german in this way (= with a single n)
but in english there are two, aka: 'planner'.
As that is unreleased code switching all instances without any
transitional provisions. Also the reason why its skipped in changelog.
Thanks: Julian Andres Klode
Gbp-Dch: Ignore
eipp: provide the internal planer as an external one2016-06-27T09:57:12ZDavid Kalnischkiesdavid@kalnischkies.de2016-05-28T13:40:59Zurn:sha1:f74d99c6a78caafdc6e32d8cb135683b7154795c
Testing the current implementation can benefit from being able to be
feed an EIPP request and produce a fully compliant response. It is also
a great test for EIPP in general.
show right binary name in simulation notice2016-06-23T07:02:54ZDavid Kalnischkiesdavid@kalnischkies.de2016-06-23T06:56:22Zurn:sha1:ae2a6be8a2155c136f9535abfbcc750c8c395cd2
Closes: 825216