Debians commandline package manager https://git.kalnischkies.de/apt/atom?h=3.2.0 2025-03-26T14:45:15Z 2025-03-26T14:45:15Z Julian Andres Klode julian.klode@canonical.com 2025-03-26T14:42:57Z urn:sha1:a452d3a9f526f6545981664712b45f709545e6fa Use setenv() to avoid overriding user defined variables. LP: #2103921 2024-12-19T16:56:49Z Julian Andres Klode julian.klode@canonical.com 2024-12-19T16:49:59Z urn:sha1:f6198e45b4cd924f390f977077d96b4545da0c91 There could be | or ; or other stuff in PAGER that needs special handling, let's encode a list of known-good characters instead. This covers all known pagers. You could also try to execvp() PAGER in its entirety and if it fails with ENOENT fall back to the shell but then you don't get correct error handling if the pager really doesn't exist (in which case we should abort trying to page). 2024-12-18T09:25:24Z Julian Andres Klode jak@debian.org 2024-12-16T16:05:40Z urn:sha1:6e260e26e4cd671f781151e24d89a17b29a55530 Automatically show the output of `show`, `policy`, `list`, `search`, `showsrc` in a pager. The pager setup is inspired by git's pager setup. Notably, the pager is found using APT_PAGER and PAGER variables. We wait for the pager to be setup somewhat correctly by using a notify pipe to figure out whether execvp() was succesful - then the pipe will read EOF as the other end got closed by CLOEXEC during exec - or not, then the pipe will contain an errno. We set up the correct handlers for signals and exit to close the fds and wait for the pager. Notably inside the signal handler we cannot flush our streams, only close them, so there is some duplication. We call the InitOutputPager() function from inside the various Do...() functions rather than setting it up generally in InitOutput(). Doing so allows us to first render the progress without a pager, and then setup the pager for the content only which improves user experience. When we setup a pager we also take care to disable standard input, as we should not be prompting users while a pager is running (the pager will be reading from the tty directly). We do this by dup2-ing() a /dev/null over it; if we just close()d the fd, another open() might reuse the fd number and problems could occur. 2024-11-11T20:40:20Z наб nabijaczleweli@nabijaczleweli.xyz 2024-11-11T20:40:07Z urn:sha1:14353ab9a1b03eff5ebb4927f254928ee21a2f90 2024-09-29T12:14:19Z David Kalnischkies david@kalnischkies.de 2024-09-29T12:14:19Z urn:sha1:c4de80035d4164d86ec5f15a7568598993b504b6 In the unlikely case input is not a terminal (but not in some way assumed with command line flags) we should print the string we act on after the prompt so that people can see what is happening rather than having the prompt "mysteriously" hidden on terminals or prepended to the first line of the download progress in logs. 2024-09-29T11:53:48Z David Kalnischkies david@kalnischkies.de 2024-09-29T11:53:48Z urn:sha1:a44bd300f006b74c09a74aff419b43912e114e0c Pressing ENTER for too long lets it end up in the input buffer which the confirmation prompt happily picks up and accepts as confirmation for deleting potentially half your system or doing other silly things. Ironically, this confirmation will also be silent in terms of output as it is likely erased by future progress reporting. Closes: #1082956 2024-07-05T04:27:32Z sid sidtosh4@gmail.com 2024-07-03T09:20:32Z urn:sha1:c575648f41ff09e72988976f8150e9bb51781cd4 Showing a package version which was never installed in removals is confusing. 2024-04-30T08:16:08Z Julian Andres Klode julian.klode@canonical.com 2024-04-30T08:13:51Z urn:sha1:bfa55b7e0516196bace4ea93f4f40bee37393d54 This improves readability a bit more as it's visually easier to tell " " and "-" apart than " " and "-". Closes: #1070064 2024-04-23T18:32:30Z Julian Andres Klode julian.klode@canonical.com 2024-04-23T18:32:17Z urn:sha1:d4889a909632f38418c630f257c00ccc595ba572 2024-04-22T17:31:46Z Julian Andres Klode jak@debian.org 2024-04-22T17:31:46Z urn:sha1:20ab001670226e92ca8a74f1e2308197111a8420 UI changes for 2.9.2 See merge request apt-team/apt!343