apt/apt-private/private-search.cc, branch mainDebians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=main2024-12-18T09:25:24ZIntroduce automatic pager for read commands2024-12-18T09:25:24ZJulian Andres Klodejak@debian.org2024-12-16T16:05:40Zurn:sha1:6e260e26e4cd671f781151e24d89a17b29a55530
Automatically show the output of `show`, `policy`, `list`,
`search`, `showsrc` in a pager.
The pager setup is inspired by git's pager setup. Notably,
the pager is found using APT_PAGER and PAGER variables.
We wait for the pager to be setup somewhat correctly by
using a notify pipe to figure out whether execvp() was
succesful - then the pipe will read EOF as the other end
got closed by CLOEXEC during exec - or not, then the pipe
will contain an errno.
We set up the correct handlers for signals and exit to close
the fds and wait for the pager. Notably inside the signal
handler we cannot flush our streams, only close them, so
there is some duplication.
We call the InitOutputPager() function from inside the
various Do...() functions rather than setting it up
generally in InitOutput(). Doing so allows us to first
render the progress without a pager, and then setup
the pager for the content only which improves user
experience.
When we setup a pager we also take care to disable
standard input, as we should not be prompting users
while a pager is running (the pager will be reading
from the tty directly). We do this by dup2-ing() a
/dev/null over it; if we just close()d the fd, another
open() might reuse the fd number and problems could
occur.
Modernize standard library includes2024-02-20T12:49:04ZJulian Andres Klodejulian.klode@canonical.com2024-02-20T12:43:08Zurn:sha1:40a75722c43ae24cb9a99d6730a3b25b65819c49
This was automated with sed and git-clang-format, and then I had to
fix up the top of policy.cc by hand as git-clang-format accidentally
indented it by two spaces.
private-search: Only use V.TranslatedDescription() if good2020-05-18T20:22:24ZJulian Andres Klodejulian.klode@canonical.com2020-05-13T22:06:56Zurn:sha1:e61886cacbc5411ea027e3a3d1d5c31793ed2b71
When we could not find a translated description, we were
pushing V.TranslatedDescription() to the vector, but that
one might not have been good either.
Add the check so we don't crash later when trying to access
it.
LP: #1877987
Search in all available description translations2019-11-25T09:59:38ZАлексей Шилинrootlexx@mail.ru2019-11-25T09:59:38Zurn:sha1:19033186919b9c6d31ca3aabaacfb069a4b64f88
When multiple translations of package descriptions are available,
perform search in all of them. It allows using search patterns in
any of the configured languages.
Previously, only the first available translation was searched. As
the result, patterns in e.g. English never matched packages which
had their descriptions translated into local language.
Closes: #490000
Support --with-source in show & search commands2018-05-11T15:58:46ZDavid Kalnischkiesdavid@kalnischkies.de2018-04-11T10:59:06Zurn:sha1:bf53f39c9a0221b670ffff74053ed36fc502d5a0Introduce experimental new hooks for command-line tools2018-04-15T19:11:42ZJulian Andres Klodejulian.klode@canonical.com2018-04-13T10:32:35Zurn:sha1:e9796b9c21ee7d8e8f5d6e2a24db43fc4368b557
This allows third-party package managers like snap or flatpak
to hook in and suggest alternatives if packages could not be
found, for example.
This is still highly experimental and the protocol might change
in future versions.
convert various c-style casts to C++-style2017-12-13T22:53:34ZDavid Kalnischkiesdavid@kalnischkies.de2017-12-13T12:26:38Zurn:sha1:957381a0d26ec11a172ebfc64f892d1b31f0c193
gcc was warning about ignored type qualifiers for all of them due to the
last 'const', so dropping that and converting to static_cast in the
process removes the here harmless warning to avoid hidden real issues in
them later on.
Reported-By: gcc
Gbp-Dch: Ignore
clearing object via constructor instead of memset2017-12-13T22:53:15ZDavid Kalnischkiesdavid@kalnischkies.de2017-12-13T11:28:22Zurn:sha1:d812245dd5ac9268ef060a243ac978074504ecca
Reported-By: gcc -Wclass-memaccess
Gbp-Dch: Ignore
Reformat and sort all includes with clang-format2017-07-12T11:57:51ZJulian Andres Klodejak@debian.org2017-07-12T11:40:41Zurn:sha1:87274d0f22e1dfd99b2e5200e2fe75c1b804eac3
This makes it easier to see which headers includes what.
The changes were done by running
git grep -l '#\s*include' \
| grep -E '.(cc|h)$' \
| xargs sed -i -E 's/(^\s*)#(\s*)include/\1#\2 include/'
To modify all include lines by adding a space, and then running
./git-clang-format.sh.
Drop cacheiterators.h include2017-07-12T11:56:05ZJulian Andres Klodejak@debian.org2017-07-12T11:42:18Zurn:sha1:c46f94aa48a9707668c46118b3eec77ff318b78c
Including cacheiterators.h before pkgcache.h fails because
pkgcache.h depends on cacheiterators.h.