apt/apt-private/private-sources.cc, branch 2.2.1Debians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=2.2.12019-04-30T15:43:31ZAdd 'explicit' to most single argument constructors2019-04-30T15:43:31ZJulian Andres Klodejulian.klode@canonical.com2019-04-30T10:07:07Zurn:sha1:b52c6552c44fcb997b0db9f5e9f17b4674dd5359
This prevents implicit conversions that we do not want, such
as having a FileFd* being converted to a debListParser.
Two cases are not yet handled because they require changes
in code using them:
1. The classes in hashes.h
2. The URI class - this one is used quite a lot
Add trailing newline to output of edit-sources.2018-07-01T04:10:08ZJean-Ralph Avilesjeanralph.aviles@gmail.com2018-07-01T04:10:08Zurn:sha1:8a6caaf869ea87ade6043169076bda04a0dc6cb6
Makes the console output cleaner.
Reformat and sort all includes with clang-format2017-07-12T11:57:51ZJulian Andres Klodejak@debian.org2017-07-12T11:40:41Zurn:sha1:87274d0f22e1dfd99b2e5200e2fe75c1b804eac3
This makes it easier to see which headers includes what.
The changes were done by running
git grep -l '#\s*include' \
| grep -E '.(cc|h)$' \
| xargs sed -i -E 's/(^\s*)#(\s*)include/\1#\2 include/'
To modify all include lines by adding a space, and then running
./git-clang-format.sh.
create non-existent files in edit-sources with 644 instead of 6402016-07-22T14:05:09ZDavid Kalnischkiesdavid@kalnischkies.de2016-07-22T11:04:47Zurn:sha1:01047752b34486607665db99afffa595cb2d43ce
If the sources file we want to edit doesn't exist yet GetLock will
create it with 640, which for a generic lockfile might be okay, but as
this is a sources file more relaxed permissions are in order – and
actually required as it wont be readable for unprivileged users causing
warnings/errors in apt calls.
Reported-By: J. Theede (musca) on IRC
report warnings&errors consistently in edit-sources2016-07-22T14:05:09ZDavid Kalnischkiesdavid@kalnischkies.de2016-07-22T10:33:45Zurn:sha1:503c7d594125f963b92047ad2d9d0644f39136c7
After editing the sources it is a good idea to (re)built the caches as
they will be out-of-date and doing so helps in reporting higherlevel
errors like duplicates sources.list entries, too, instead of just
general parsing errors as before.
show globalerrors before asking for confirmation2016-05-16T14:17:54ZDavid Kalnischkiesdavid@kalnischkies.de2016-05-13T14:59:09Zurn:sha1:fd78974020e23679e9e810cf01dc5c8f3012bb8a
Errors cause a kind of automatic no already, but warnings and notices
are only displayed at the end of the apt execution even through they
could effect the choice of saying yes/no to questions: E.g. if a
configuration (file) was ignored you wanted to have an effect or if an
external solver you used generated warnings suggesting that the solution
might be valid, but bogus non-the-less and similar things.
Note that this only moves those messages up to the question if the
answer is interactive – not if e.g. -y is used or no question is asked at
all so this has an effect only on interactive usage of apt(-get), not
script who might be parsing apt output.
avoid using global PendingError to avoid failing too often too soon2015-09-14T13:22:18ZDavid Kalnischkiesdavid@kalnischkies.de2015-09-10T17:00:51Zurn:sha1:95278287f4e1eeaf5d96749d6fc9bfc53fb400d0
Our error reporting is historically grown into some kind of mess.
A while ago I implemented stacking for the global error which is used in
this commit now to wrap calls to functions which do not report (all)
errors via return, so that only failures in those calls cause a failure
to propergate down the chain rather than failing if anything
(potentially totally unrelated) has failed at some point in the past.
This way we can avoid stopping the entire acquire process just because a
single source produced an error for example. It also means that after
the acquire process the cache is generated – even if the acquire
process had failures – as we still have the old good data around we can and
should generate a cache for (again).
There are probably more instances of this hiding, but all these looked
like the easiest to work with and fix with reasonable (aka net-positive)
effects.
cleanup headers and especially #includes everywhere2014-03-13T12:58:45ZDavid Kalnischkiesdavid@kalnischkies.de2014-03-05T21:11:25Zurn:sha1:453b82a388013e522b3a1b9fcd6ed0810dab1f4f
Beside being a bit cleaner it hopefully also resolves oddball problems
I have with high levels of parallel jobs.
Git-Dch: Ignore
Reported-By: iwyu (include-what-you-use)
flock() the file edited in edit-sources2014-01-06T07:12:28ZMichael Vogtmvo@debian.org2014-01-06T07:12:28Zurn:sha1:c189f87d57844a13619ec387916f49aba171c1b3add "APT::String::Endswith" and automatic adding of ".list" in apt edit-source2013-11-29T07:37:54ZMichael Vogtmvo@debian.org2013-11-29T07:35:05Zurn:sha1:cf993341c2067ee091cfd51e5da0e237babce171