apt/apt-private, branch 1.1.10

ensure we got a lock in clean operation

2015-12-23T16:48:16Z

We try to acquired the locks, but we didn't stop if we failed to get it… Closes: 808561

non-existing directories don't need to be cleaned

2015-12-14T02:21:20Z

Trying to clean up directories which do not exist seems rather silly if you think about it, so let apt think about it and stop it. Depends a bit on the caller if this is fixing anything for them as they might try to acquire a lock or doing other clever things as apt does. Closes: 807477

require explicit paths to dsc/control as we do for deb files

2015-12-01T13:26:05Z

Otherwise a user is subject to unexpected content-injection depending on which directory she happens to start apt in. This also cleans up the code requiring less implementation details in build-dep which is always good. Technically, this is an ABI break as we override virtual methods, but that they weren't overridden was a mistake resulting in pure classes, which shouldn't be pure, so they were unusable – and as they are new in 1.1 nobody is using them yet (and hopefully ever as they are borderline implementation details). Closes: 806693

deal with configured build-essential first

2015-12-01T13:25:28Z

There is no need to check configured build-essentials for each package, doing it once at the start ought to be enough. Git-Dch: Ignore

split build-dep satisfier loop out of DoBuildDep

2015-12-01T13:24:48Z

Lets do this non-behaviour change before we modify the source for real as the reflow and moving would otherwise hide all the interesting changes. Git-Dch: Ignore

drop some needlessly public declarations in libapt-private

2015-11-29T16:00:11Z

Git-Dch: Ignore

move 'unmet' handling into libapt-private

2015-11-29T14:49:55Z

Git-Dch: Ignore

do not override exact targetrelease matches with lesser matches

2015-11-29T12:36:28Z

The relevant testcases are in test/integration/test-apt-get-source. There is a test for #731853 that is supposed to "ensure that apt will pick the higher version number" of 0.0.1 (stable) and 0.1 (stable). However, this works by pure chance, as simply reversing the order of the two insertsource lines makes the test fail. So #731853 isn't really fixed, yet. Actually, that's related to the problem I reported, as the underlying issue for both is the same: In the FindSrc function apt chooses a new 'best hit', if either * there is a target release and it matches the release of the package, * or the version of the package is higher than the last best hit. Consider having 1.0 (stable), 2.0 (unstable) and 1.5 (unstable), in this order. Looking for the version in stable, apt first selects 1.0, because the release matches the target release, but then subsequently selects 2.0, because the version is higher. Looking for the version in unstable, apt first selects 2.0, because the release matches the target release, but then subsequently selects 1.5, because the release also matches the target release. The correct way would be to choose a new 'best hit', if either * there is a target release and it matches the release of the package, * or there is no target release and the version is higher than the last best hit. Closes: 746412 Mail-Reference: <565A604B.7090104@googlemail.com> Mail-Archive: https://lists.debian.org/debian-devel/2015/11/msg00470.html

use function pointers instead of weak symbols for cmdline parsing

2015-11-29T12:12:38Z

Passing function pointers around while working on this was very icky, but if weak symbols are too much to ask for… Reverts "do not use "-Wl,-Bsymbolic-functions" during the build to avoid breakage" aka a5fc9be36211a290a7abc3ca2a8bf98943bc1f57.

Revert "Revert "appease adequate with some weak symbols for -private""

2015-11-28T21:36:25Z

This reverts commit 7ac9386cb6e272625490fcf3e8183b45e28bbc43.