Debians commandline package manager https://git.kalnischkies.de/apt/atom?h=1.6_alpha4 2017-10-28T09:54:33Z 2017-10-28T09:54:33Z Julian Andres Klode jak@debian.org 2017-10-28T09:45:28Z urn:sha1:197a813cc87f50262c6faac68916c3e9a60e4d5c It used FindI() > 0, but if it is too big, FindI() would cause an error "Cannot convert %s to integer: out of range", so let's also use FindULL() here. Gbp-Dch: ignore 2017-10-28T09:35:39Z Julian Andres Klode jak@debian.org 2017-10-28T08:59:55Z urn:sha1:a6375472a41af7f1521369d0c22a858d7051ab18 Installed-Size for linux-image-4.13.0-1-amd64-dbg and friends are larger than 4 GB, but read as a signed integer - that's fine so far, as the value is in KB, but it's multiplied with 1024 which overflows. So let's read it as unsigned long long instead. While we're at it, also use unsigned long long for Size, in case that is bigger than 2 GB. 2017-10-05T15:30:25Z David Kalnischkies david@kalnischkies.de 2017-10-05T13:27:58Z urn:sha1:bf6c329cd9f484f9e6b711f157a3b60fb3a8563d cppcheck reports: (portability) Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. We don't ship on any platform which has this as undefined behaviour through – or it would be pretty well defined "bad" behaviour which always works, so even through UB is a trigger word, its hardly noteworthy as a change (and as a bonus the scanners of gcc/clang don't consider it UB). The commonly accepted method of fixing that seems to be (const char*)NULL, but it is in fact much simpler to just switch to the varadic functions C++ provides resolving the warning and reducing code. Reported-By: cppcheck Gbp-Dch: Ignore 2017-07-27T13:47:59Z Julian Andres Klode jak@debian.org 2017-07-27T13:47:59Z urn:sha1:eb0ccb003ceedac0fd78fee05d7b8119dd04c48b The code only used to warn when it came into a situation where something actually had to be forced. Warn directly after parsing the command-line instead, that's more accurate. 2017-07-26T17:09:04Z David Kalnischkies david@kalnischkies.de 2017-07-14T15:07:22Z urn:sha1:8580574ec63fedd39a3ab3b9f0025e08eae5f620 The feature exists for a long while even if we get around to document it properly only now, so we should push for its adoption a bit to avoid the problems its supposed to solve like avoiding usage of non-world readable configuration files as they can cause strange behaviour for the unsuspecting user (like different solutions as root and non-root). 2017-07-26T17:09:04Z David Kalnischkies david@kalnischkies.de 2017-07-14T11:49:33Z urn:sha1:054243fd0febfef5f1ba89f61eed0e6a34c6a25f We detect the effected sources by matching Release info – that has potential by-catch of repositories which have incorrect field values, but those are better fixed now anyhow. The bigger incorrectness is that this message will not only be printed for the Debian services itself but also for all mirrors not under Debian control but serving Debian like more local/private mirrors which will not (directly) shutdown. It is likely through that many of them will follow suite with less visible announcements or break downright if their upstream source disappears, so having false-positives here seems benefitial for the user in the end. 2017-07-12T11:57:51Z Julian Andres Klode jak@debian.org 2017-07-12T11:40:41Z urn:sha1:87274d0f22e1dfd99b2e5200e2fe75c1b804eac3 This makes it easier to see which headers includes what. The changes were done by running git grep -l '#\s*include' \ | grep -E '.(cc|h)$' \ | xargs sed -i -E 's/(^\s*)#(\s*)include/\1#\2 include/' To modify all include lines by adding a space, and then running ./git-clang-format.sh. 2017-07-12T11:56:05Z Julian Andres Klode jak@debian.org 2017-07-12T11:42:18Z urn:sha1:c46f94aa48a9707668c46118b3eec77ff318b78c Including cacheiterators.h before pkgcache.h fails because pkgcache.h depends on cacheiterators.h. 2017-06-28T17:18:47Z David Kalnischkies david@kalnischkies.de 2017-05-28T15:44:11Z urn:sha1:24b5bc4e41ed527799a9fa01dec9c29294d0a3f2 If we have a user sitting around we can let 'apt' ask the user for a confirmation rather than print errors at the end and require the user to figure out which commandline flags are needed to confirm the changes non-interactively. 2017-06-28T17:18:47Z David Kalnischkies david@kalnischkies.de 2017-04-12T15:39:06Z urn:sha1:081fbea14d12f79c8d91ce4fe1f1004c7bc08656 The value of Origin, Label, Codename and co can be used in user configuration from apts own pinning to unattended upgrades. A repository changing this values can therefore have serious effects on the behaviour of apt and other tools using these values. In a first step we will generate error messages for these changes now explaining the need for explicit confirmation and provide config options and commandline flags to accept them.