Debians commandline package manager https://git.kalnischkies.de/apt/atom?h=1.6_alpha6 2018-01-03T17:55:41Z 2018-01-03T17:55:41Z David Kalnischkies david@kalnischkies.de 2017-08-12T14:21:13Z urn:sha1:ef9677831f62a1554a888ebc7b162517d7881116 If a method needs a file to operate like e.g. mirror needs to get a list of mirrors before it can redirect the the actual requests to them. That could easily be solved by moving the logic into libapt directly, but by allowing a method to request other methods to do something we can keep this logic contained in the method and allow e.g. also methods which perform binary patching or similar things. Previously they would need to implement their own acquire system inside the existing one which in all likelyhood will not support the same features and methods nor operate with similar security compared to what we have already running 'above' the requesting method. That said, to avoid methods producing conflicts with "proper" files we are downloading a new directory is introduced to keep the auxiliary files in. [The message magic number 351 is a tribute to the german Grundgesetz article 35 paragraph 1 which defines that all authorities of the state(s) help each other on request.] 2017-12-13T22:53:41Z David Kalnischkies david@kalnischkies.de 2017-12-13T20:39:16Z urn:sha1:1adcf56bec7d2127d83aa423916639740fe8e586 The casts are useless, but the reports show some where we can actually improve the code by replacing them with better alternatives like converting whatever int type into a string instead of casting to a specific one which might in the future be too small. Reported-By: gcc -Wuseless-cast 2017-12-13T22:53:34Z David Kalnischkies david@kalnischkies.de 2017-12-13T12:26:38Z urn:sha1:957381a0d26ec11a172ebfc64f892d1b31f0c193 gcc was warning about ignored type qualifiers for all of them due to the last 'const', so dropping that and converting to static_cast in the process removes the here harmless warning to avoid hidden real issues in them later on. Reported-By: gcc Gbp-Dch: Ignore 2017-12-13T22:53:15Z David Kalnischkies david@kalnischkies.de 2017-12-13T11:28:22Z urn:sha1:d812245dd5ac9268ef060a243ac978074504ecca Reported-By: gcc -Wclass-memaccess Gbp-Dch: Ignore 2017-11-19T17:26:19Z David Kalnischkies david@kalnischkies.de 2017-11-18T02:48:59Z urn:sha1:3f8664036e63d2a2d58120ab6c1e8a0a09937c71 apt usually gets the width of the window from the terminal or failing that has a default value, but especially for testing it can be handy to control the size as you can't be sure that variable sized content will always be linebreaked as expected in the testcases. 2017-10-28T09:54:33Z Julian Andres Klode jak@debian.org 2017-10-28T09:45:28Z urn:sha1:197a813cc87f50262c6faac68916c3e9a60e4d5c It used FindI() > 0, but if it is too big, FindI() would cause an error "Cannot convert %s to integer: out of range", so let's also use FindULL() here. Gbp-Dch: ignore 2017-10-28T09:35:39Z Julian Andres Klode jak@debian.org 2017-10-28T08:59:55Z urn:sha1:a6375472a41af7f1521369d0c22a858d7051ab18 Installed-Size for linux-image-4.13.0-1-amd64-dbg and friends are larger than 4 GB, but read as a signed integer - that's fine so far, as the value is in KB, but it's multiplied with 1024 which overflows. So let's read it as unsigned long long instead. While we're at it, also use unsigned long long for Size, in case that is bigger than 2 GB. 2017-10-05T15:30:25Z David Kalnischkies david@kalnischkies.de 2017-10-05T13:27:58Z urn:sha1:bf6c329cd9f484f9e6b711f157a3b60fb3a8563d cppcheck reports: (portability) Passing NULL after the last typed argument to a variadic function leads to undefined behaviour. We don't ship on any platform which has this as undefined behaviour through – or it would be pretty well defined "bad" behaviour which always works, so even through UB is a trigger word, its hardly noteworthy as a change (and as a bonus the scanners of gcc/clang don't consider it UB). The commonly accepted method of fixing that seems to be (const char*)NULL, but it is in fact much simpler to just switch to the varadic functions C++ provides resolving the warning and reducing code. Reported-By: cppcheck Gbp-Dch: Ignore 2017-07-27T13:47:59Z Julian Andres Klode jak@debian.org 2017-07-27T13:47:59Z urn:sha1:eb0ccb003ceedac0fd78fee05d7b8119dd04c48b The code only used to warn when it came into a situation where something actually had to be forced. Warn directly after parsing the command-line instead, that's more accurate. 2017-07-26T17:09:04Z David Kalnischkies david@kalnischkies.de 2017-07-14T15:07:22Z urn:sha1:8580574ec63fedd39a3ab3b9f0025e08eae5f620 The feature exists for a long while even if we get around to document it properly only now, so we should push for its adoption a bit to avoid the problems its supposed to solve like avoiding usage of non-world readable configuration files as they can cause strange behaviour for the unsuspecting user (like different solutions as root and non-root).