apt/apt-private, branch 2.9.16Debians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=2.9.162024-11-22T20:05:35ZCollect unprinted Ign errors for display in Err output2024-11-22T20:05:35ZDavid Kalnischkiesdavid@kalnischkies.de2024-11-22T17:59:48Zurn:sha1:a732f74400147a9993358b4778335715a0d5e20e
Instead of deciding if the first or the last error in a retry chain is
the best one to display if the entire chain fails in the end we teach
our progress reporting to collect the ignored errors (if it hasn't shown
them) and print them all together in the Err line.
We de-duplicate the collection which makes it harder to match the Ign
line with the error messages, but for these cases its probably better to
enable direct display of the text anyhow – and repeating the same message
multiple times is boring and probably not that helpful for a user
wanting to know why all the downloads failed even they asked apt to
retry 429 times…
References: 841243df877b39dfcb907a7fab9c4e8b4f65d715
Add a virtual destructor to private CacheSet Matcher2024-11-22T12:11:13ZDavid Kalnischkiesdavid@kalnischkies.de2024-09-11T19:52:26Zurn:sha1:0fb71e375363f2b45b033bb2b324e80214325c61
This silences the warning:
| warning: ‘class Matcher’ has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor]
Acknowledge non-erase usage of remove_if for volatile sources2024-11-22T12:11:13ZDavid Kalnischkiesdavid@kalnischkies.de2024-09-11T16:57:04Zurn:sha1:fa19a9ddbdddeaed44480ce7dade11d526336435
gcc produces a length warning starting with:
| warning: ignoring return value of ‘_FIter std::remove_if(_FIter, _FIter, _Predicate) [with …]’, declared with attribute ‘nodiscard’ [-Wunused-result]
which is usually correct, but in the usage here we don't want to call an
erase as we operate on a c-style new[] array here which contains pointers
into argv and has an explicit sentinel (nullptr) – FileSize() is based
on this sentinel.
Casting to void silences the warning as is standard practice and
hopefully indicates better that this is intended than ignoring the
warning for the casual on-looker.
Add a --comment option to record Comment: in history2024-11-18T19:15:08ZJulian Andres Klodejulian.klode@canonical.com2024-11-18T19:07:02Zurn:sha1:1c4fa81cc398e21868ad237509f1ea8e772d76de
Suggested-by: mhoye on IRC
Merge branch 'svequiv' into 'main'2024-11-14T14:54:40ZJulian Andres Klodejak@debian.org2024-11-14T14:54:40Zurn:sha1:82752f6e0c65541244c2607e5dedf437701e07dc
Internally replace APT::StringView with std::string_view where it doesn't affect the ABI, with implementations that support both std::string_view and APT::StringView with new shims. ReportMirrorFailureToCentral: fix use-after-free
See merge request apt-team/apt!394Merge branch 'json-config' into 'main'2024-11-14T14:38:32ZJulian Andres Klodejak@debian.org2024-11-14T14:38:32Zurn:sha1:8f10ee850db3892bc979694864451be3a73ad1e8
JSON: Pass options to hooks in hello message
See merge request apt-team/apt!389apt-private/private-update.cc: APT::StringView -> std::string_view2024-11-12T19:36:17Zнабnabijaczleweli@nabijaczleweli.xyz2024-11-12T16:59:25Zurn:sha1:e33add3c2afa33a6f81b2eaed1fdcd29dc28790fjson: Add "options" array to JSON hooks2024-11-12T13:41:05ZJulian Andres Klodejulian.klode@canonical.com2024-09-02T16:11:28Zurn:sha1:d936557579090fa7a5ce7edaebc61f55b3fa3ab8
See the attached documentation. Note that defaults are missing,
so using this is not particularly easy so far.
Replace std::bind with lambdas2024-11-11T20:40:20Zнабnabijaczleweli@nabijaczleweli.xyz2024-11-11T20:40:07Zurn:sha1:14353ab9a1b03eff5ebb4927f254928ee21a2f90Merge branch 'feature/ignorantprompt' into 'main'2024-10-22T12:35:17ZJulian Andres Klodejak@debian.org2024-10-22T12:35:17Zurn:sha1:8e20203cc68aa39ed5736f46c608f89c523fbf30
Ignore pending input before confirmation prompts
See merge request apt-team/apt!375