Debians commandline package manager https://git.kalnischkies.de/apt/atom?h=2.9.26 2025-01-28T18:48:47Z 2025-01-28T18:48:47Z Julian Andres Klode julian.klode@canonical.com 2025-01-27T16:34:45Z urn:sha1:4059a1544323b945a81e5ef0faea4a3b109f36bf 2025-01-28T18:47:00Z Julian Andres Klode julian.klode@canonical.com 2025-01-27T14:51:24Z urn:sha1:9d7a660611e9e134cd6d74a594bde59cad77c8d8 This handles rewriting .list entries to .sources ones; the only options handled are - signed-by => Signed-By - trusted => Trusted The options to specify architectures, check-valid-until, etc. are not supported as they are not exposed in the code. We probably should refactor the parser at some point so we can actually read the parsed entry rather than the abstract objects we create from it. This can be improved further: - Keyrings from /etc/apt/trusted.gpg.d should be moved to /etc/apt/keyrings. - automatic detection by trying to verify using each keyring in trusted.gpg.d until we find the right one and then using that for Signed-By rather than leave some sources empty. 2025-01-28T18:45:23Z Andreas Rönnquist gusnan@debian.org 2025-01-23T14:33:55Z urn:sha1:a725a4af76fed9c4f06188f022f9a8f28ff333bd 2025-01-21T11:16:34Z Julian Andres Klode julian.klode@canonical.com 2025-01-20T10:57:33Z urn:sha1:c4e57e200ae40db5e9ada6ec0933b53d249e4a97 Warn about the missing field there and suggest the transition to deb822 .sources files if we found any non-deb822 source without signed-by. 2025-01-05T22:16:09Z David Kalnischkies david@kalnischkies.de 2024-12-26T22:14:43Z urn:sha1:1a35028dd9ee4554a1a1f9f77a4dee615fb278ae They were implemented to help a tiny bit in notifying users even if they didn't read the Release notes (or didn't realize it would apply to them) that they likely have to change their sources.list entries, but that transition is now over for a while, so everyone who should have seen it has hopefully reacted to it and so all this code now does is waste space, time and idly waiting for false positives. 2025-01-05T22:16:08Z David Kalnischkies david@kalnischkies.de 2024-12-26T21:57:23Z urn:sha1:12036e1ff02d0c02d0f69050c1f080e8ca947cd5 nodiscard is a C++17 feature and already used (not just due to my recent changes) in our codebase, so lets drop the last remaining holdouts. 2025-01-05T22:16:08Z David Kalnischkies david@kalnischkies.de 2024-12-26T19:41:53Z urn:sha1:f73593a4034d9eec0ec4466b8e173d4a4daece1f We were rather inconsistent in using it and as our public headers contain deduction guides (a c++17 feature) it seems silly to try to hide a c++11 feature in a macro, so lets stop this charade and drop the macro and while we are changing all these lines lets apply [[nodiscard]] (another c++17 feature) and other suggestions from clang-tidy and formatting for a little more consistency. 2024-12-19T17:24:37Z Julian Andres Klode julian.klode@canonical.com 2024-10-29T13:06:51Z urn:sha1:71727c2a761889855b3c1aaf4243649e98032f67 Add new fields `APT-Pin`, `APT-Candidate`, and `APT-Release` to the output, same as in EDSP (limited to one release for now). 2024-12-19T16:56:49Z Julian Andres Klode julian.klode@canonical.com 2024-12-19T16:49:59Z urn:sha1:f6198e45b4cd924f390f977077d96b4545da0c91 There could be | or ; or other stuff in PAGER that needs special handling, let's encode a list of known-good characters instead. This covers all known pagers. You could also try to execvp() PAGER in its entirety and if it fails with ENOENT fall back to the shell but then you don't get correct error handling if the pager really doesn't exist (in which case we should abort trying to page). 2024-12-18T09:25:24Z Julian Andres Klode jak@debian.org 2024-12-16T16:05:40Z urn:sha1:6e260e26e4cd671f781151e24d89a17b29a55530 Automatically show the output of `show`, `policy`, `list`, `search`, `showsrc` in a pager. The pager setup is inspired by git's pager setup. Notably, the pager is found using APT_PAGER and PAGER variables. We wait for the pager to be setup somewhat correctly by using a notify pipe to figure out whether execvp() was succesful - then the pipe will read EOF as the other end got closed by CLOEXEC during exec - or not, then the pipe will contain an errno. We set up the correct handlers for signals and exit to close the fds and wait for the pager. Notably inside the signal handler we cannot flush our streams, only close them, so there is some duplication. We call the InitOutputPager() function from inside the various Do...() functions rather than setting it up generally in InitOutput(). Doing so allows us to first render the progress without a pager, and then setup the pager for the content only which improves user experience. When we setup a pager we also take care to disable standard input, as we should not be prompting users while a pager is running (the pager will be reading from the tty directly). We do this by dup2-ing() a /dev/null over it; if we just close()d the fd, another open() might reuse the fd number and problems could occur.