Debians commandline package manager https://git.kalnischkies.de/apt/atom?h=2.9.4 2024-05-16T20:12:51Z 2024-05-16T20:12:51Z David Kalnischkies david@kalnischkies.de 2024-05-16T14:51:28Z urn:sha1:f404c8e06e07c2a89efb0f1ba997a7f1c0c472db Companion of the previous commit that uses the same reasoning, but from the other side of the logic (as we start from reverse deps here) so that we are dropping the useless NEW from the solution. Ideally this code would not live in -private, but in -pkg, but there is not really a pre-existent good central place for this currently as a sort-of fixup for our default resolver given this is the result of resolver decision to not do something which had ripple effects that aren't reverted along with it. It is a bit unlikely that this is fixing all instances that this bug has given we have dealt with a few instances of it already as they are relatively obscure situations to clean up after and the cost of being wrong (= autoremover generating breaks) is much higher than being correct (= no pointless install – that is likely installed later anyhow after the temporary automatic hold is lifted). And by virtue of being the result of mostly temporary situations its also unlikely to be debugable in hindsight months later; so if there is another situation, its better to deal with it in a new bugreport. Closes: #839546 2024-05-14T09:56:18Z Julian Andres Klode julian.klode@canonical.com 2024-05-06T13:34:33Z urn:sha1:89dcc342e17dd2439d97a5d27200cf5c26ba35bc This is a simple backtracking brute-force solver with heurisitcs, this initial version has the following known gaps: - Errors are not kept from branches, the error reporting after backtracking isn't particularly useful. - We cannot show automatically removed packages - We cannot replace packages with others - We do not have conflict-driven clause learning yet Untested: - Multi-arch This solver is fundamentally different in key aspects: - It solves smaller dependency groups before larger ones, leading us to avoid installing A in A|B if B is installed more often and more consistently. - It only keeps the automatic packages reachable via the strongest path. Currently it only implements autoremoval, but not display of autoremoval as we simply enqueue all automatically installed packages at the end when not doing automatic removal. This will need some translation where we Solve() first, and then Solve() again with the automatically installed packages added such that we can mark them as Garbage for display purposes. - It does not remove manually installed packages. Hook the solver in via the EDSP framework, this allows us to achieve easy initial integration without lots of issues. A lot of this work was planned and executed in my free time and then some leaked into work time I suppose. Implementation notes: - Restore the full backlog of items The annoying thing is that we record only when an item was enqueued and not the level at which it was installed, so when going back a decision level we might have to reinstall packages that were queued at an earlier decision level because they were only installed at a later decision level. - When picking one version, reject the others - Propagate conflicts up to reverse dependencies This will recursively mark every reverse dependency that can no longer be satisfied as MUSTNOT. Also make sure to recursively call Reject(Ver) from Reject(Pkg) to make sure we trigger the Rejections there. This means we now end up having Recursion in the algorithm. An alternative approach would be to push *reject* items to the heap and then do them, but this is not entirely straight forward and it may simply not be necessary. - Sort upgrades before other optional installs containing subsets If I want to upgrade a package A, I schedule A3|A2|A1; if another thing depends specifically on A1; we'd not be installed. Hence we need to sort upgrades first. This only is needed for optional packages; manual packages will figure this out naturally. - Rescoring is lazily implemented. Instead of calling make_heap() after rescoring items, we just mark the items as dirty and reinsert them. We also only rescore from the main solve loop, Reject() marks the heap as needing a rescore due to a Conflict (as some versions will no longer be installable), and RescoreWorkIfNeeded() then will do the rescoring. - Recursive unit propagation: Install() and Reject() recursively call each other to promote decisions across single-version dependencies (or across not-anymore satisfiable reverse-depends). - Make Reason constructors explicit, this enhances readability This makes calls like the one in here be Reject(object, Reason(otherObject)) Ensuring that it's clear that the 2nd argument is a reason at the caller side. - Split Decision into Decision and Hint vs. first draft When branching/deciding, we do not want to override SHOULD and MAY. We do not actually use them yet, and we do actually clean them when backtracking, but let's at least keep the data structure correct. Convert the enum to a 16-bit integer so we can still fit in the same space as before. 2024-04-30T08:16:08Z Julian Andres Klode julian.klode@canonical.com 2024-04-30T08:13:51Z urn:sha1:bfa55b7e0516196bace4ea93f4f40bee37393d54 This improves readability a bit more as it's visually easier to tell " " and "-" apart than " " and "-". Closes: #1070064 2024-04-29T14:33:41Z Julian Andres Klode jak@debian.org 2024-04-29T14:33:41Z urn:sha1:4a76c77d1cd3f07c01d5908cca539ed90d1793d3 showsrc, source, build-dep: Support src:name See merge request apt-team/apt!346 2024-04-29T13:26:25Z Julian Andres Klode julian.klode@canonical.com 2024-04-29T13:14:24Z urn:sha1:84881c1914ca30435ff478b4138cd7559c35c8d1 This has the same behavior as --only-source name. 2024-04-29T12:56:41Z Julian Andres Klode julian.klode@canonical.com 2024-04-29T12:56:41Z urn:sha1:9a29aa8f61530aca8a46d0c6de08ea78c6e57f9e This has the same meaning as --only-source name 2024-04-24T13:16:21Z David Kalnischkies david@kalnischkies.de 2024-04-03T19:12:01Z urn:sha1:e099ee946000797f4c03b8c5075ce7ebba193337 We remove new garbage packages from the solution if we can as installing a new package which is at the same time considered garbage looks silly, but it could also be a new dependency of another garbage package, so we have a second round trying to save such packages. In this round we weren't considering versioned constraints on dependency relations through so even an unsatisfied old recommends could save which it shouldn't. 2024-04-24T13:16:21Z David Kalnischkies david@kalnischkies.de 2024-04-03T12:36:40Z urn:sha1:7d93bcabc3f2c47c093faae7b36b7709f287cce2 Not all commands show kept back packages, so even if it hardly matters, lets not crunch numbers needlessly if we don't need the info which also reduces the lifetime of the involved variables hopefully also reducing the mental requirements for a reader. 2024-04-23T18:32:30Z Julian Andres Klode julian.klode@canonical.com 2024-04-23T18:32:17Z urn:sha1:d4889a909632f38418c630f257c00ccc595ba572 2024-04-22T17:31:46Z Julian Andres Klode jak@debian.org 2024-04-22T17:31:46Z urn:sha1:20ab001670226e92ca8a74f1e2308197111a8420 UI changes for 2.9.2 See merge request apt-team/apt!343