apt/cmdline/apt-cache.cc, branch 1.0.9.5Debians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=1.0.9.52014-09-02T15:25:35ZUse heap to allocate PatternMatch to avoid potential stack overflow2014-09-02T15:25:35ZMichael Vogtmvo@ubuntu.com2014-09-02T15:06:52Zurn:sha1:097248092ea4ff4543dfb17deb4e0d31dd697c71
When apt-cache search with many args (> 130) is given the allocation
of PatternMatch on the stack may fail resulting in a segmentation
fault. By using the heap the max size is much bigger and we also
get a bad_alloc expection instead of a segfault (which we can catch
*if* this ever becomes a pratical problem). No test for the crash
as its not reproducable with the MALLOC_ settings in framework.
Closes: 759612
support Acquire::GzipIndexes in dumpavail2014-06-10T12:12:12ZDavid Kalnischkiesdavid@kalnischkies.de2014-06-10T12:12:12Zurn:sha1:4dde2b4285fc6288e44e915a0d7bc0faac114a2e
Closes: 742835
follow method attribute suggestions by gcc2014-03-13T12:58:45ZDavid Kalnischkiesdavid@kalnischkies.de2014-03-05T23:33:10Zurn:sha1:a02db58fd50ef7fc2f0284852c6b3f98e458a232
Git-Dch: Ignore
Reported-By: gcc -Wsuggest-attribute={pure,const,noreturn}
cleanup headers and especially #includes everywhere2014-03-13T12:58:45ZDavid Kalnischkiesdavid@kalnischkies.de2014-03-05T21:11:25Zurn:sha1:453b82a388013e522b3a1b9fcd6ed0810dab1f4f
Beside being a bit cleaner it hopefully also resolves oddball problems
I have with high levels of parallel jobs.
Git-Dch: Ignore
Reported-By: iwyu (include-what-you-use)
warning: unused parameter ‘foo’ [-Wunused-parameter]2014-03-13T12:58:45ZDavid Kalnischkiesdavid@kalnischkies.de2014-03-01T14:11:42Zurn:sha1:655122418d714f342b5d9789f45f8035f3fe8b9a
Reported-By: gcc -Wunused-parameter
Git-Dch: Ignore
warning: no previous declaration for foobar() [-Wmissing-declarations]2014-03-13T12:58:45ZDavid Kalnischkiesdavid@kalnischkies.de2014-02-27T02:11:54Zurn:sha1:c3ccac9232c2684b15f75fa8622a9a290aeca123
Git-Dch: Ignore
Reported-By: gcc -Wmissing-declarations
fix -Wmissing-field-initializers warnings2014-03-13T12:58:45ZDavid Kalnischkiesdavid@kalnischkies.de2014-02-25T21:22:41Zurn:sha1:67c3067f1a615fd6ff0b332c2a526d052442913d
Reported-By: gcc
Git-Dch: Ignore
squash merge of the feature/apt-binary branch without the changes from experimental2013-08-12T21:24:08ZMichael Vogtmvo@debian.org2013-08-12T21:24:08Zurn:sha1:b917917067e757c4479a344a263ef7cf43c00866use FileFd::Write instead of fwrite for errors2013-07-26T09:42:02ZDavid Kalnischkieskalnischkies@gmail.com2013-07-26T09:42:02Zurn:sha1:d832304e06838275446a0b787899591061f39160
Using the static FileFd::Write method gives us error messages for free
so we use it here to avoid failing silently (with a fail silent error).
Git-Dch: Ignore
fix 'apt-cache search' crash with missing description2013-07-18T19:30:47ZDavid Kalnischkieskalnischkies@gmail.com2013-07-18T17:22:29Zurn:sha1:922f07986b93ce7866f89917e3a475e6a4b3941c
Beside the earlier fixed 'apt-cache show', 'showpkg' and 'search' deal
with descriptions. 'showpkg' was fixed by fixing the cache generation
for 'show', but 'search' still segfaulted.
On the upside, it doesn't segfault any longer, on the downside, if a
package has no description at all (aka: not in the Packages file and not
in a Translation-* file) the package can't be found with 'search', even
if we search only by name. That is a shortcoming in the code, but fixing
it means rewriting it completely for dubious gain at best.
So this commit just skips packages without a description and is done.
Closes: 647590