apt/cmdline/apt-cdrom.cc, branch 1.0.9.4 Debians commandline package manager https://git.kalnischkies.de/apt/atom?h=1.0.9.4 2014-03-13T12:58:45Z remove code duplication for Add & Ident in apt-cdrom 2014-03-13T12:58:45Z David Kalnischkies david@kalnischkies.de 2014-03-09T23:33:38Z urn:sha1:b5ee78aec0b13932bdeb710cbbea148b7041203a The preparation code to deal with auto-detection and co is the same for both methods, so not sharing them would be bad. Deals also with the prevention of side effects triggered by the auto-detection like disabling mounting for the fallback. Git-Dch: Ignore follow method attribute suggestions by gcc 2014-03-13T12:58:45Z David Kalnischkies david@kalnischkies.de 2014-03-05T23:33:10Z urn:sha1:a02db58fd50ef7fc2f0284852c6b3f98e458a232 Git-Dch: Ignore Reported-By: gcc -Wsuggest-attribute={pure,const,noreturn} cleanup headers and especially #includes everywhere 2014-03-13T12:58:45Z David Kalnischkies david@kalnischkies.de 2014-03-05T21:11:25Z urn:sha1:453b82a388013e522b3a1b9fcd6ed0810dab1f4f Beside being a bit cleaner it hopefully also resolves oddball problems I have with high levels of parallel jobs. Git-Dch: Ignore Reported-By: iwyu (include-what-you-use) warning: unused parameter ‘foo’ [-Wunused-parameter] 2014-03-13T12:58:45Z David Kalnischkies david@kalnischkies.de 2014-03-01T14:11:42Z urn:sha1:655122418d714f342b5d9789f45f8035f3fe8b9a Reported-By: gcc -Wunused-parameter Git-Dch: Ignore warning: no previous declaration for foobar() [-Wmissing-declarations] 2014-03-13T12:58:45Z David Kalnischkies david@kalnischkies.de 2014-02-27T02:11:54Z urn:sha1:c3ccac9232c2684b15f75fa8622a9a290aeca123 Git-Dch: Ignore Reported-By: gcc -Wmissing-declarations warning: extra ‘;’ [-Wpedantic] 2014-03-13T12:58:45Z David Kalnischkies david@kalnischkies.de 2014-02-27T00:20:53Z urn:sha1:d3e8fbb395f57954acd7a2095f02ce530a05ec6a Git-Dch: Ignore Reported-By: gcc -Wpedantic apt-cdrom should succeed if any drive succeeds 2014-02-12T01:18:37Z John Ogness john.ogness@linutronix.de 2013-12-13T19:59:31Z urn:sha1:62dcbf84c4aee8cb01e40c594d4c7f3a23b64836 If there are multiple CD-ROM drives, `apt-cdrom add` will abort with an error if any of the drives do not contain a Debian CD which is against the documentation we have saying "a CD-ROM" and also scripts do not expect it this way. This patch modifies apt-cdrom to return success if any of the drives succeeded. If failures occur, apt-cdrom will still continue trying all the drives and report the last failure (if none of them succeeded). The 'ident' command was also changed to match the new 'add' behavior. Closes: 728153 squash merge of the feature/apt-binary branch without the changes from experimental 2013-08-12T21:24:08Z Michael Vogt mvo@debian.org 2013-08-12T21:24:08Z urn:sha1:b917917067e757c4479a344a263ef7cf43c00866 improve error message 2013-08-12T15:42:00Z Michael Vogt mvo@debian.org 2013-08-12T15:41:36Z urn:sha1:7dd5854b48f5d59c02fb0068d850384f3e678c67 fix -Wall errors 2013-08-08T13:40:15Z Michael Vogt mvo@debian.org 2013-08-08T13:40:15Z urn:sha1:f52037d629aea696f938015e7f1ec037eb079af8