Debians commandline package manager https://git.kalnischkies.de/apt/atom?h=1.5_rc1 2017-08-24T14:56:52Z 2017-08-24T14:56:52Z Julian Andres Klode jak@debian.org 2017-08-24T14:55:15Z urn:sha1:0e4ac8334d02ea256f750ad61689f28ff1ebdf6c As a follow up to the last commit, let's replace APT_CONST with APT_PURE everywhere to clean stuff up. 2017-07-26T17:07:55Z David Kalnischkies david@kalnischkies.de 2017-07-15T08:59:11Z urn:sha1:b1165a67b1f47f64082fce9a4af80838a2f5e55c Our test-external-dependency-solver-protocol test sometimes fails on the immediately 'crashing' solver exit1withoutmsg with the message that it got SIGPIPE from the solver. That isn't really possible as the solver produces no output, but on inspection its not this solver getting the signal but the wrapping provided by the dump-solver as the wrapped solver instantly exits. Simply ignoring the signal helps in perhaps extracting the last words of another solver (as this one has none), but at the very least we get the exit code of the wrapped solver we interested in as output. 2017-07-12T11:57:51Z Julian Andres Klode jak@debian.org 2017-07-12T11:40:41Z urn:sha1:87274d0f22e1dfd99b2e5200e2fe75c1b804eac3 This makes it easier to see which headers includes what. The changes were done by running git grep -l '#\s*include' \ | grep -E '.(cc|h)$' \ | xargs sed -i -E 's/(^\s*)#(\s*)include/\1#\2 include/' To modify all include lines by adding a space, and then running ./git-clang-format.sh. 2017-07-12T11:56:05Z Julian Andres Klode jak@debian.org 2017-07-12T11:42:18Z urn:sha1:c46f94aa48a9707668c46118b3eec77ff318b78c Including cacheiterators.h before pkgcache.h fails because pkgcache.h depends on cacheiterators.h. 2017-06-26T21:31:15Z David Kalnischkies david@kalnischkies.de 2017-06-04T16:14:13Z urn:sha1:fc2055e1e08e4e3b662b0c5f67a0d0a57267acd3 Changes nothing on the program front and as the datatypes are sufficently comparable fixes no bug either, but problems later on if we ever change the types of those and prevent us using types which are too large for the values we want to store waste (a tiny bit of) resources. Gbp-Dch: Ignore 2016-12-31T02:50:06Z David Kalnischkies david@kalnischkies.de 2016-12-31T02:50:06Z urn:sha1:9544398fce600fb62762c05a8a84231fd1a365b4 On Travis and co the default gpg implementation is gpg1 which for some reason fails if a secret key which was already imported is imported again. We would prefer it to be a NOP like gpg2 handles it so we crudely check the error message. apt-key usually doesn't deal with secret keys – it only learned to do it for manual testing and the integration framework usage, so no public interface is effected. Triggered-By: 4ce2f35248123ff2366c8c365ad6a94945578d66 Gbp-Dch: Ignore 2016-12-21T18:36:10Z David Kalnischkies david@kalnischkies.de 2016-12-18T16:42:17Z urn:sha1:4ce2f35248123ff2366c8c365ad6a94945578d66 Importing a new secret key into gpg(2) can be increadibly slow which prolongs the test runs significantly – by caching the homedir we gain a significant speedbonus as reimporting already present keys seems like a far less costly operation. Git-Dch: Ignore 2016-11-24T23:15:12Z David Kalnischkies david@kalnischkies.de 2016-11-13T19:52:18Z urn:sha1:2906182db398419a9c59a928b7ae73cf7c7aa307 Having binary files in /etc is kinda annoying – not that the armored files are much better – but it is hard to keep tabs on which format the file has ("simple" or "keybox") and different gnupg versions have different default binary formats which can be confusing for users to work with (beside that it is binary). Adding support for this now will enable us in some distant future to move to armored later on, much like we added trusted.gpg.d years before the world picked it up. 2016-11-23T23:21:35Z David Kalnischkies david@kalnischkies.de 2016-11-12T22:22:33Z urn:sha1:8e438ede2f179f2f66268308c24d62952ac06fa4 We report warnings from apt-key this way already since 29c590951f812d9e9c4f17706e34f2c3315fb1f6, so reporting errors seems like a good addition. Most of those errors aren't really from apt-key through, but from the code setting up and actually calling it which used to just print to stderr which might or might not intermix them with (other) progress lines in update calls. Having them as proper error messages in the system means that the errors are actually collected later on for the list instead of ending up with our relatively generic but in those cases bogus hint regarding "is gpgv installed?". The effective difference is minimal as the errors apply mostly to systems which have far worse problems than a not as nice looking error message, which makes this pretty hard to test – but at least now the hint that your system is broken can be read in proper order (= there aren't many valid cases in which the permissions of /tmp are messed up…). LP: #1522988 2016-08-26T22:31:03Z Julian Andres Klode jak@debian.org 2016-08-26T22:31:03Z urn:sha1:6a68315e938eb2611806658828ecea86805822e7