apt/methods/basehttp.cc, branch 3.1.2

http: use Retry-After HTTP header to optimize retries

2024-11-18T12:44:49Z

Some mirrors like snapshot.debian.org apply strict http rate limits. While apt already has an exponential backoff mechanism implemented, this is not sufficient due to the following reasons: 1. all retries happen roughly at the same time 2. the retry-after information from the server is not used We fix this by improving the algorithm: First, if present, the timestamp or duration of the Retry-After header is added to the exponential backoff, optimizing for success-on-second-try. Second, a random delay is added (delay += [0, delay]) to distribute the retries to not immediately run into the limit again. To avoid super-long delays, this is capped by the configured maximum delay. This logic only becomes active if the option Acquire::Retries::HandleRetryAfter is enabled. Signed-off-by: Felix Moessbauer

Modernize standard library includes

2024-02-20T12:49:04Z

This was automated with sed and git-clang-format, and then I had to fix up the top of policy.cc by hand as git-clang-format accidentally indented it by two spaces.

basehttp: Rename HaveContent's Tristate

2021-11-23T19:19:23Z

Darwin systems define TRUE and FALSE as preprocessor macros for use with bool. This conflicts with the enum values causing the compilation to fail.

Merge branch 'pu/content-length-0' into 'main'

2021-10-18T13:42:56Z

basehttp: Turn HaveContent into a TriState See merge request apt-team/apt!179

Disable HTTP Range usage if varnish < 6.4 is involved

2021-09-16T20:40:00Z

Debian buster (oldstable) ships 6.1 while bullseye (stable) ships 6.5 and so the later is 'fixed'. Upstream declares 6.0 still as supported. It might be still a while we encounter "bad" versions in the wild, so if we can detect and work around the issue at runtime automatically we can save some users from running into "persistent" partial files. References: https://varnish-cache.org/docs/6.4/whats-new/changes-6.4.html#changes-in-behavior

Add AllowRange option to disable HTTP Range usage

2021-09-16T20:38:46Z

apt makes heavy usage of HTTP1.1 features including Range and If-Range. Sadly it is not obvious if the involved server(s) (and proxies) actually support them all. The Acquire::http::AllowRange option defaults to true as before, but now a user can disable Range usage if it is known that the involved server is not dealing with such requests correctly.

Set haveContent to FALSE on `Content-Length: 0`

2021-07-01T13:47:48Z

Set haveContent to HaveContent::FALSE when Content-Length is 0, and change remaining code to only set it to TRUE if it has not been set so far. Closes: #990281

basehttp: Turn HaveContent into a TriState

2021-07-01T13:35:21Z

We need to be able to set HaveContent to false if the Content-Length is 0, and not have that overriden just because a later header is Content-Type.

Fix downloads of unsized files that are largest in pipeline

2021-04-13T14:00:41Z

The maximum request size is accidentally set to any sized file, so if an unsized file is present, and it turns out to be larger than the maximum size we set, we'd error out when checking if its size is smaller than the maximum request size. LP: #1921626

Ensure HTTP status code text has sensible content

2021-02-04T10:00:00Z

We use the code in error messages, so at least for that edgecase we should ensure that it has sensible content. Note that the acquire system aborts on non-sensible message content in SendMessage, so you can't really exploit this.