apt/methods/cdrom.cc, branch 1.2.1Debians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=1.2.12015-08-10T15:27:17Zadd c++11 override marker to overridden methods2015-08-10T15:27:17ZDavid Kalnischkiesdavid@kalnischkies.de2015-07-08T22:35:40Zurn:sha1:3b3028467ceccca0b73a8f53051c0fa4de313111
C++11 adds the 'override' specifier to mark that a method is overriding
a base class method and error out if not. We hide it in the APT_OVERRIDE
macro to ensure that we keep compiling in pre-c++11 standards.
Reported-By: clang-modernize -add-override -override-macros
Git-Dch: Ignore
call URIStart in cdrom and file method2015-06-15T21:35:54ZDavid Kalnischkiesdavid@kalnischkies.de2015-06-15T11:36:11Zurn:sha1:ff86d7df6a53ff6283de4b9a858c1dad98ed887f
All other methods call it, so they should follow along even if the work
they do afterwards is hardly breathtaking and usually results in a
URIDone pretty soon, but the acquire system tells the individual item
about this via a virtual method call, so even through none of our
existing items contains any critical code in these, maybe one day they
might. Consistency at least once…
Which is also why this has a good sideeffect: file: and cdrom: requests
appear now in the 'apt-get update' output. Finally - it never made sense
to hide them for me. Okay, I guess it made before the new hit behavior,
but now that you can actually see the difference in an update it makes
sense to see if a file: repository changed or not as well.
calculate only expected hashes in methods2015-04-18T23:13:09ZDavid Kalnischkiesdavid@kalnischkies.de2015-03-30T18:47:13Zurn:sha1:9224ce3d4d1ea0428a70e75134998e08aa45b1e6
Methods get told which hashes are expected by the acquire system, which
means we can use this list to restrict what we calculate in the methods
as any extra we are calculating is wasted effort as we can't compare it
with anything anyway.
Adding support for a new hash algorithm is therefore 'free' now and if a
algorithm is no longer provided in a repository for a file, we
automatically stop calculating it.
In practice this results in a speed-up in Debian as we don't have SHA512
here (so far), so we practically stop calculating it.
cleanup headers and especially #includes everywhere2014-03-13T12:58:45ZDavid Kalnischkiesdavid@kalnischkies.de2014-03-05T21:11:25Zurn:sha1:453b82a388013e522b3a1b9fcd6ed0810dab1f4f
Beside being a bit cleaner it hopefully also resolves oddball problems
I have with high levels of parallel jobs.
Git-Dch: Ignore
Reported-By: iwyu (include-what-you-use)
warning: extra ‘;’ [-Wpedantic]2014-03-13T12:58:45ZDavid Kalnischkiesdavid@kalnischkies.de2014-02-27T00:20:53Zurn:sha1:d3e8fbb395f57954acd7a2095f02ce530a05ec6a
Git-Dch: Ignore
Reported-By: gcc -Wpedantic
try to avoid direct usage of .Fd() if possible and do read()s and co2011-12-17T22:53:31ZDavid Kalnischkieskalnischkies@gmail.com2011-12-17T22:53:31Zurn:sha1:109eb1511d0cdfa4af3196105cada30bcbb77bc8
on the FileFd instead
use forward declaration in headers if possible instead of includes2011-09-19T17:14:19ZDavid Kalnischkieskalnischkies@gmail.com2011-09-19T17:14:19Zurn:sha1:472ff00ef2e48383805d281c6364ec27839e3f4dmerge with debian/experimental2011-09-13T15:52:22ZDavid Kalnischkieskalnischkies@gmail.com2011-09-13T15:52:22Zurn:sha1:74b220028595342028e3309002e4ec359af328f9reorder includes: add <config.h> if needed and include it at first2011-09-13T08:09:00ZDavid Kalnischkieskalnischkies@gmail.com2011-09-13T08:09:00Zurn:sha1:ea54214002c09eeb4dd498d97a564471ec9993c5follow the recommendation of cppcheck to make some method methods (scnr)2011-08-11T21:30:09ZDavid Kalnischkieskalnischkies@gmail.com2011-08-11T21:30:09Zurn:sha1:f5a34606b4a910e7b7b984940fb2d12681a2dd3b
const and initial mostly Debug member values in the constructors