apt/methods/connect.cc, branch 1.9.1

Merge tag '1.8.2'

2019-06-11T12:16:18Z

apt Debian release 1.8.2

methods: https: handle requests for TLS re-handshake

2019-05-21T12:53:01Z

When accessing repository protected by TLS mutual auth, apt may receive a "re-handshake" request from the server, which must be handled in order for download to proceed. This situation arises when the server requests a client certificate based on the resource path provided in the GET request, after the inital handshake in UnwrapTLS() has already occurred, and a secure connection has been established. This issue has been observed with Artifactory-backed Debian repository. To address the issue, split TLS handshake code out into its own method in TlsFd, and call it when GNUTLS_E_REHANDSHAKE error is received. Signed-off-by: Michael Zhivich (merged from Debian/apt#93) LP: #1829861

Fix new gcc-9 warning -Wpessimizing-move

2019-04-16T10:59:54Z

warning: moving a local object in a return statement prevents copy elision [-Wpessimizing-move] Reported-By: gcc-9 Gbp-Dch: Ignore

Handle a missed case of timed out ip addresses

2018-05-24T12:26:16Z

Correctly register timed out IP addresses from a timed out select() call as a bad address so we do not try it again. LP: #1766542

Reword error for timed out read/write on SOCKS proxy

2018-05-19T19:39:08Z

Closes: #898886

Remove obsolete RCS keywords

2018-05-07T11:41:31Z

Prompted-by: Jakub Wilk

Correctly report transient errors again

2018-01-03T15:33:36Z

Commit 47c0bdc310c8cd62374ca6e6bb456dd183bdfc07 ("report transient errors as transient error") accidentally changed some connection failures to become non-transient, because the result of the error checks where being ignored and then fatal error was returned if an error was pending - even if that error was trivial. After the merge of pu/happy-eyeballs2a this becomes a lot clearer, and easy to fix. Gbp-Dch: ignore Regression-Of: 47c0bdc310c8cd62374ca6e6bb456dd183bdfc07

Add rapid "happy eyeballs" connection fallback (RFC 8305)

2018-01-03T14:31:36Z

Try establishing connections in alternating address families in rapid intervals of 250 ms, adding more connections to the wait list until one succeeds (RFC 8305, happy eyeballs 2). It is important that WaitAndCheckErrors() waits until it has a successful connection, a time out, or all connections failed - otherwise the timing between tries might be wrong, and the final long wait might exit early because one connection failed without trying the others. Timing wise, this only works correctly on Linux, as select() counts down there. But we rely on that in some other places too, so this is not the time to fix that. Timeouts are only reported in the final long wait - the short inner waits are expected to time out more often, and multiple times, we do not want to report them. Closes: #668948 LP: #1308200 Gbp-Dch: paragraph

connect: Extract Connection::CheckError() method

2018-01-03T14:26:51Z

Extracting the error checking method allows us to reuse it in different places, so we can move the waiting and checking out of DoConnect() eventually. Gbp-Dch: ignore

connect: Store the IP used when picking a connection

2018-01-03T14:26:51Z

There's no real point in storing the IP address while resolving it - failure messages include the IP address in any case. Do this when picking the connection for actual use instead.