Debians commandline package manager https://git.kalnischkies.de/apt/atom?h=2.9.25 2025-01-14T10:26:31Z 2025-01-14T10:26:31Z Julian Andres Klode julian.klode@canonical.com 2025-01-14T10:26:31Z urn:sha1:cb2c0dbc70b1432173d8a02d8c46a4b9f107fe52 2025-01-14T08:26:23Z Julian Andres Klode jak@debian.org 2025-01-14T08:26:23Z urn:sha1:ce452d40f499fa56f6ddc15e8871b1262d4e1418 Drop unused and obsolete macros as well as documentation See merge request apt-team/apt!428 2025-01-08T18:22:36Z Julian Andres Klode julian.klode@canonical.com 2025-01-08T18:17:42Z urn:sha1:20c9b6894790ef5f9b763e429dbd8f51c2e091e2 SSL_read() and SSL_write may return 0 for errors, whereas our callers only expect -1 for errors and 0 for closed connections, so map this accordingly. 2025-01-08T18:22:34Z Julian Andres Klode julian.klode@canonical.com 2025-01-08T18:13:37Z urn:sha1:a8be42ef4de786b4dacdc175419df92ab0193ed9 The OpenSSL docs say: > For socket I/O on Unix systems, consult errno for details but also: > This value can also be returned for other errors, > check the error queue for details. This means it's possible errno isn't set, in which case we may appear to have reached an EOF when we did not. 2025-01-05T22:16:08Z David Kalnischkies david@kalnischkies.de 2024-12-26T19:41:53Z urn:sha1:f73593a4034d9eec0ec4466b8e173d4a4daece1f We were rather inconsistent in using it and as our public headers contain deduction guides (a c++17 feature) it seems silly to try to hide a c++11 feature in a macro, so lets stop this charade and drop the macro and while we are changing all these lines lets apply [[nodiscard]] (another c++17 feature) and other suggestions from clang-tidy and formatting for a little more consistency. 2024-12-22T22:45:15Z Julian Andres Klode julian.klode@canonical.com 2024-12-21T14:26:34Z urn:sha1:7b1fb90b93ced7c0772d726e512da01fad456852 OpenSSL is mandatory now, it is no longer possible to build without https support either. 2024-12-22T21:55:39Z Julian Andres Klode julian.klode@canonical.com 2024-12-18T18:37:40Z urn:sha1:90270f0959d490d56db891809d83c91b3d4b9bf0 Introduce an OpenSSL::Crypto backend for the hashes library and an OpenSSL::SSL backend for the TLS support in our https method. Many thanks to curl for showing the way with how to handle a CRL file. There are some memory leaks here with the TlsFd itself as well as the proxy support; and we should reorganize the code to generate the ssl object as late as possible. A peculiar aspect of OpenSSL is that SSL_has_pending() returns 1 even if SSL_read() will fail to read anything and return the equivalent of EAGAIN. We work around this here by also peeking ahead 1 byte. I was running a very high RTT connection from Germany to Australia for testing, and with the peeking it's using negligible amounts of CPU; before that, it was busy looping at 100%. Bad OpenSSL! 2024-11-22T12:13:25Z David Kalnischkies david@kalnischkies.de 2024-11-19T22:42:44Z urn:sha1:8c760266c8c736bff62055c008ab74d78f3ed82a gcc reports `warning: Declaring type ‘class X’ final would enable devirtualization of Y calls [-Wsuggest-final-types]`. Not that this would massively improve performance, but it shouldn't hurt telling the compiler what is obvious for a human. 2024-03-03T07:23:51Z Steve Langasek steve.langasek@canonical.com 2024-03-03T07:10:14Z urn:sha1:9044806c2adc6118399349c70a6c5746cedcc374 Once in a generation, it may be necessary to bootstrap apt in an environment where gnutls is not yet available. This makes gnutls support in apt optional. You may also want a configure flag to force gnutls to be required from outside the buildsystem (e.g. debian/rules). 2024-02-20T12:49:04Z Julian Andres Klode julian.klode@canonical.com 2024-02-20T12:43:08Z urn:sha1:40a75722c43ae24cb9a99d6730a3b25b65819c49 This was automated with sed and git-clang-format, and then I had to fix up the top of policy.cc by hand as git-clang-format accidentally indented it by two spaces.