apt/methods/file.cc, branch 3.1.5

Drop usage of macro APT_OVERRIDE for simple override

2025-01-05T22:16:08Z

We were rather inconsistent in using it and as our public headers contain deduction guides (a c++17 feature) it seems silly to try to hide a c++11 feature in a macro, so lets stop this charade and drop the macro and while we are changing all these lines lets apply [[nodiscard]] (another c++17 feature) and other suggestions from clang-tidy and formatting for a little more consistency.

Merge branch 'fix/partialfilemirror' into 'main'

2024-11-22T16:12:34Z

Support uncompressed indexes from partial file:/ mirrors See merge request apt-team/apt!235

Look at non by-hash paths in copy and file methods

2024-11-22T12:40:10Z

Ideally copy and file mirrors would support by-hash as well, but its harder to setup and maintain especially if you want to cache an online mirror who has by-hash enabled. We can avoid unneeded roundtrips (in the best case) and entire cache misses (in the usual worst case) by "just" telling methods that the URI we passed it has the requested file perhaps also in other paths. This is done in pseudo-relative paths as we would otherwise need to teach redirection code to rewrite those URIs as well. A method like http can easily ignore this value and await explicit instructions to look at that file, but inspecting the path in local sources via file or copy is (comparatively) free, so we just do it immediately. If that ends up being the wrong version of the file as by-hash would have protected us from we are in this feature branch now falling back to other mirrors which are like the ones online and in support of by-hash.

Alternatively calculate alternative file hashes in file method

2024-11-22T12:21:24Z

If we do not have the requested file we haven't calculated the hashes for it either and it is likely that the alternative file will be used, so to save the main thread from being busy with calculating hashes we do the calculation here in the method.

Tag hidden acquire classes as final for devirtualization

2024-11-22T12:13:25Z

gcc reports `warning: Declaring type ‘class X’ final would enable devirtualization of Y calls [-Wsuggest-final-types]`. Not that this would massively improve performance, but it shouldn't hurt telling the compiler what is obvious for a human.

Implement encoded URI handling in all methods

2020-12-18T18:31:19Z

Every method opts in to getting the encoded URI passed along while keeping compat in case we are operated by an older acquire system. Effectively this is just a change for the http-based methods as the others just decode the URI as they work with files directly.

Apply various suggestions by cppcheck

2019-07-08T13:51:17Z

Reported-By: cppcheck

apt-pkg: URI: Add 'explicit' to single argument constructor

2019-04-30T15:43:56Z

This needs a fair amount of changes elsewhere in the code, hence this is separate from the previous commits.

Remove obsolete RCS keywords

2018-05-07T11:41:31Z

Prompted-by: Jakub Wilk

Sandbox methods with seccomp-BPF; except cdrom, gpgv, rsh

2017-10-22T21:38:31Z

This reduces the number of syscalls to about 140 from about 350 or so, significantly reducing security risks. Also change prepare-release to ignore the architecture lists in the build dependencies when generating the build-depends package for travis. We might want to clean up things a bit more and/or move it somewhere else.