apt/methods/ftp.cc, branch 1.1.9Debians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=1.1.92015-11-05T11:21:33Zallow acquire method specific options via Binary scope2015-11-05T11:21:33ZDavid Kalnischkiesdavid@kalnischkies.de2015-11-04T13:48:36Zurn:sha1:23e64f6d0facf9610c1042326ad9850e071e8349
Allows users who know what they are getting themselves into with this
trick to e.g. disable privilege dropping for e.g. file:// until they can
fix up the permissions on those repositories. It helps also the test
framework and people with a similar setup (= me) to run in less modified
environments.
wrap every unlink call to check for != /dev/null2015-11-04T17:42:28ZDavid Kalnischkiesdavid@kalnischkies.de2015-11-02T17:49:52Zurn:sha1:ce1f3a2c616b86da657c1c796efa5f4d18c30c39
Unlinking /dev/null is bad, we shouldn't do that. Also, we should print
at least a warning if we tried to unlink a file but didn't manage to
pull it of (ignoring the case were the file is /dev/null or doesn't
exist in the first place).
This got triggered by a relatively unlikely to cause problem in
pkgAcquire::Worker::PrepareFiles which would while temporary
uncompressed files (which are set to keep compressed) figure out that to
files are the same and prepare for sharing by deleting them. Bad move.
That also shows why not printing a warning is a bad idea as this hide
the error for in non-root test runs.
Git-Dch: Ignore
fix various typos reported by codespell2015-08-27T09:27:44ZDavid Kalnischkiesdavid@kalnischkies.de2015-08-22T14:22:08Zurn:sha1:3a8776a37af38127fb04565959e8e0e449eb04a4
Reported-By: codespell
Make apt compile with clang++ again2015-08-14T17:44:25ZMichael Vogtmvo@debian.org2015-08-14T17:44:25Zurn:sha1:f8043f219f077b1cfc6c5ad2263c4caa4709a00d
This allows us to run the clang static analyzer and to run the
testsuite with the clang MemorySanitizer.
add c++11 override marker to overridden methods2015-08-10T15:27:17ZDavid Kalnischkiesdavid@kalnischkies.de2015-07-08T22:35:40Zurn:sha1:3b3028467ceccca0b73a8f53051c0fa4de313111
C++11 adds the 'override' specifier to mark that a method is overriding
a base class method and error out if not. We hide it in the APT_OVERRIDE
macro to ensure that we keep compiling in pre-c++11 standards.
Reported-By: clang-modernize -add-override -override-macros
Git-Dch: Ignore
calculate only expected hashes in methods2015-04-18T23:13:09ZDavid Kalnischkiesdavid@kalnischkies.de2015-03-30T18:47:13Zurn:sha1:9224ce3d4d1ea0428a70e75134998e08aa45b1e6
Methods get told which hashes are expected by the acquire system, which
means we can use this list to restrict what we calculate in the methods
as any extra we are calculating is wasted effort as we can't compare it
with anything anyway.
Adding support for a new hash algorithm is therefore 'free' now and if a
algorithm is no longer provided in a repository for a file, we
automatically stop calculating it.
In practice this results in a speed-up in Debian as we don't have SHA512
here (so far), so we practically stop calculating it.
reimplement the last uses of sprintf2015-04-10T18:18:17ZDavid Kalnischkiesdavid@kalnischkies.de2015-03-10T13:11:54Zurn:sha1:b8eba208daebe3e3f235983e44da9c398d6f7a57
Working with strings c-style is complicated and error-prune,
so by converting to c++ style we gain some simplicity and
avoid buffer overflows by later extensions.
Git-Dch: Ignore
Fix backward compatiblity of the new pkgAcquireMethod::DropPrivsOrDie()2014-10-13T09:29:47ZMichael Vogtmvo@ubuntu.com2014-10-13T08:57:30Zurn:sha1:9983999d294887046abf386adc31190700d89b61
Do not drop privileges in the methods when using a older version of
libapt that does not support the chown magic in partial/ yet. To
do this DropPrivileges() now will ignore a empty Apt::Sandbox::User.
Cleanup all hardcoded _apt along the way.
Send "Fail-Reason: MaximumSizeExceeded" from the method2014-10-07T20:36:09ZMichael Vogtmvo@ubuntu.com2014-10-07T20:36:09Zurn:sha1:ee27950632c149bb14c9c490e92147579ba4fc2a
Communicate the fail reason from the methods to the parent
and Rename() failed files.
make expected-size a maximum-size check as this is what we want at this point2014-10-07T15:47:30ZMichael Vogtmvo@ubuntu.com2014-10-07T15:47:30Zurn:sha1:c48eea97b93920062ea26001081d4fdf7eb967e3