apt/methods/ftp.cc, branch 2.9.0

Modernize standard library includes

2024-02-20T12:49:04Z

This was automated with sed and git-clang-format, and then I had to fix up the top of policy.cc by hand as git-clang-format accidentally indented it by two spaces.

Ignore return of .c_str() in preemptive call for signal handler

2023-01-29T12:59:30Z

Reported-By: gcc-13 -Wunused-result Gbp-Dch: Ignore

Implement encoded URI handling in all methods

2020-12-18T18:31:19Z

Every method opts in to getting the encoded URI passed along while keeping compat in case we are operated by an older acquire system. Effectively this is just a change for the http-based methods as the others just decode the URI as they work with files directly.

apt-pkg: URI: Add 'explicit' to single argument constructor

2019-04-30T15:43:56Z

This needs a fair amount of changes elsewhere in the code, hence this is separate from the previous commits.

Lower default timeout from 120s to 30s

2018-05-24T12:31:31Z

120s is an insanely high default time out, lower it to 30s to make things a bit nicer.

Remove obsolete RCS keywords

2018-05-07T11:41:31Z

Prompted-by: Jakub Wilk

report transient errors as transient errors

2017-12-13T22:56:29Z

The Fail method for acquire methods has a boolean parameter indicating the transient-nature of a reported error. The problem with this is that Fail is called very late at a point where it is no longer easily identifiable if an error is indeed transient or not, so some calls were and some weren't and the acquire system would later mostly ignore the transient flag and guess by using the FailReason instead. Introducing a tri-state enum we can pass the information about fatal or transient errors through the callstack to generate the correct fails.

Sandbox methods with seccomp-BPF; except cdrom, gpgv, rsh

2017-10-22T21:38:31Z

This reduces the number of syscalls to about 140 from about 350 or so, significantly reducing security risks. Also change prepare-release to ignore the architecture lists in the build dependencies when generating the build-depends package for travis. We might want to clean up things a bit more and/or move it somewhere else.

allow the auth.conf to be root:root owned

2017-07-26T17:09:04Z

Opening the file before we drop privileges in the methods allows us to avoid chowning in the acquire main process which can apply to the wrong file (imagine Binary scoped settings) and surprises users as their permission setup is overridden. There are no security benefits as the file is open, so an evil method could as before read the contents of the file, but it isn't worse than before and we avoid permission problems in this setup.

reimplement and document auth.conf

2017-07-26T17:09:04Z

We have support for an netrc-like auth.conf file since 0.7.25 (closing 518473), but it was never documented in apt that it even exists and netrc seems to have fallen out of usage as a manpage for it no longer exists making the feature even more arcane. On top of that the code was a bit of a mess (as it is written in c-style) and as a result the matching of machine tokens to URIs also a bit strange by checking for less specific matches (= without path) first. We now do a single pass over the stanzas. In practice early adopters of the undocumented implementation will not really notice the differences and the 'new' behaviour is simpler to document and more usual for an apt user. Closes: #811181