apt/methods/http.cc, branch 2.9.18Debians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=2.9.182024-11-22T12:13:25ZTag hidden acquire classes as final for devirtualization2024-11-22T12:13:25ZDavid Kalnischkiesdavid@kalnischkies.de2024-11-19T22:42:44Zurn:sha1:8c760266c8c736bff62055c008ab74d78f3ed82a
gcc reports `warning: Declaring type ‘class X’ final would
enable devirtualization of Y calls [-Wsuggest-final-types]`.
Not that this would massively improve performance, but it
shouldn't hurt telling the compiler what is obvious for a human.
methods/http.cc: APT::StringView -> std::string_view2024-11-12T19:36:20Zнабnabijaczleweli@nabijaczleweli.xyz2024-11-12T18:50:56Zurn:sha1:b430a53e45b6d676142af7da78564de3bd97ef5fSupport building without gnutls2024-03-03T07:23:51ZSteve Langaseksteve.langasek@canonical.com2024-03-03T07:10:14Zurn:sha1:9044806c2adc6118399349c70a6c5746cedcc374
Once in a generation, it may be necessary to bootstrap apt in an
environment where gnutls is not yet available. This makes gnutls
support in apt optional.
You may also want a configure flag to force gnutls to be required from
outside the buildsystem (e.g. debian/rules).
Modernize standard library includes2024-02-20T12:49:04ZJulian Andres Klodejulian.klode@canonical.com2024-02-20T12:43:08Zurn:sha1:40a75722c43ae24cb9a99d6730a3b25b65819c49
This was automated with sed and git-clang-format, and then I had to
fix up the top of policy.cc by hand as git-clang-format accidentally
indented it by two spaces.
Ignore return of .c_str() in preemptive call for signal handler2023-01-29T12:59:30ZDavid Kalnischkiesdavid@kalnischkies.de2023-01-29T12:54:02Zurn:sha1:0ac3afe29cfc71c657853f06961c6c8ba9c09e5c
Reported-By: gcc-13 -Wunused-result
Gbp-Dch: Ignore
Use https config on https proxies for http servers2021-09-13T14:09:19ZDavid Kalnischkiesdavid@kalnischkies.de2021-09-12T22:54:38Zurn:sha1:4e04cbafe7db326b52ee650a4f4ccc3444da6890
The settings used for unwrapping TLS connections depend on the access
and hostname we connect to more than what we eventually unwrap. The
bugreport mentions CaInfo, but all other https-settings should also
apply (regardless of generic or hostname specific) to an https proxy,
even if the connection we proxy through it is http-only.
Closes: #990555
Implement encoded URI handling in all methods2020-12-18T18:31:19ZDavid Kalnischkiesdavid@kalnischkies.de2020-07-09T22:02:25Zurn:sha1:97d6c3b2d05fe0d965657197adf56cc78f9edf81
Every method opts in to getting the encoded URI passed along while
keeping compat in case we are operated by an older acquire system.
Effectively this is just a change for the http-based methods as the
others just decode the URI as they work with files directly.
Rewrite HttpServerState::Die()2020-08-11T11:42:41ZJulian Andres Klodejulian.klode@canonical.com2020-08-11T11:09:14Zurn:sha1:8b35e2a3dd7b863639a8909fa2361ed4fd217bc3
The old code was fairly confusing, and contradictory. Notably, the
second `if` also only applied to the Data state, whereas we already
terminated the Data state earlier. This was bad.
The else fallback applied in three cases:
(1) We reached our limit
(2) We are Persistent
(3) We are headers
Now, it always failed as a transient error if it had
nothing left in the buffer. BUT: Nothing left in the buffer
is the correct thing to happen if we were fetching content.
Checking all combinations for the flags, we can compare the results
of Die() between 2.1.7 - the last "known-acceptable-ish" version
and this version:
2.1.7 this
Data !Persist !Space !Limit OK (A) OK
Data !Persist !Space Limit OK (A) OK
Data !Persist Space !Limit OK (C) OK
Data !Persist Space Limit OK OK
Data Persist !Space !Limit ERR ERR *
Data Persist !Space Limit OK (B) OK
Data Persist Space !Limit ERR ERR
Data Persist Space Limit OK OK
=> Data connections are OK if they have not reached their limit,
or are persistent (in which case they'll probably be chunked)
Header !Persist !Space !Limit ERR ERR
Header !Persist !Space Limit ERR ERR
Header !Persist Space !Limit OK OK
Header !Persist Space Limit OK OK
Header Persist !Space !Limit ERR ERR
Header Persist !Space Limit ERR ERR
Header Persist Space !Limit OK OK
Header Persist Space Limit OK OK
=> Common scheme here is that header connections are fine if they have
read something into the input buffer (Space). The rest does not matter.
(A) Non-persistent connections with !space always enter the else clause, hence success
(B) no Space means we enter the if/else, we go with else because IsLimit(), and we succeed because we don't have space
(C) Having space we do enter the while (WriteSpace()) loop, but we never reach IsLimit(),
hence we fall through. Given that our connection is not persistent, we fall through to the
else case, and there we win because we have data left to write.
http: Fully flush local file both before/after server read2020-08-11T11:09:04ZJulian Andres Klodejulian.klode@canonical.com2020-08-11T08:55:09Zurn:sha1:73780d7f664a4ea1da55527d726b4c9c7753f1fb
We do not want to end up in a code path while reading content
from the server where we have local data left to write, which
can happen if a previous read included both headers and content.
Restructure Flush() to accept a new argument to allow incomplete
flushs (which do not match our limit), so that it can flush as
far as possible, and modify Go() and use that before and after
reading from the server.
http: Do not use non-blocking local I/O2020-08-11T11:09:04ZJulian Andres Klodejulian.klode@canonical.com2020-08-11T09:42:15Zurn:sha1:13ab2317451931f055855f1aeaec6c8b28b14ce2
This causes some more issues, really.