apt/methods/http.h, branch 1.4_beta4Debians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=1.4_beta42016-12-31T01:29:21Zrename ServerMethod to BaseHttpMethod2016-12-31T01:29:21ZDavid Kalnischkiesdavid@kalnischkies.de2016-12-09T14:13:09Zurn:sha1:d8617331afc39281d5925033975b6097128786f4
This 'method' is the abstract base for http and https and should as such
be called out like this rather using an easily confused name.
Gbp-Dch: Ignore
separating state variables regarding server/request2016-12-31T01:29:21ZDavid Kalnischkiesdavid@kalnischkies.de2016-11-09T11:25:44Zurn:sha1:13a9f08de18dea0dfc1951992b0ddeda9c2fa2dd
Having a Reset(bool) method to partially reset certain variables like
the download size always were strange, so this commit splits the
ServerState into an additional RequestState living on the stack for as
long as we deal with this request causing an automatic "reset".
There is much to do still to make this code look better, but this is a
good first step which compiles cleanly and passes all tests, so keeping
it as history might be beneficial and due to avoiding explicit memory
allocations it ends up fixing a small memory leak in https, too.
Closes: #440057
reorganize server-states resetting in http/https2016-08-16T16:49:37ZDavid Kalnischkiesdavid@kalnischkies.de2016-08-11T14:59:13Zurn:sha1:ebdb6f1810a20ac240b5b2192dc2e6532ff149d2
We keep various information bits about the server around, some only
effecting the currently handled file (like sizes) while others
should be persistent (like pipeline detections). http used to reset all
file-related manually, which is a bit silly if we already have a Reset()
method – which does reset all through –, so extending it with a
parameter for reuse and calling it from https too (as this was
previously resetting by just creating a new state struct – it uses no
value of the persistent state-keeping yet as it supports no pipelining).
Gbp-Dch: Ignore
implement socks5h proxy support for http method2016-08-10T21:19:44ZDavid Kalnischkiesdavid@kalnischkies.de2016-08-04T06:45:38Zurn:sha1:61db48241f2d46697a291bfedaf398a1ca9a70e3
Socks support is a requested feature in sofar that the internet is
actually believing Acquire::socks::Proxy would exist. It doesn't and
this commit isn't adding it as that isn't how our configuration works,
but it allows Acquire::http::Proxy="socks5h://…". The HTTPS method was
changed already to support socks proxies (all versions) via curl. This
commit implements only SOCKS5 (RFC1928) with no auth or pass&user auth
(RFC1929), but not GSSAPI which is required by the RFC. The 'h' in the
protocol name further indicates that DNS resolution is delegated to the
socks proxy rather than performed locally.
The implementation works and was tested with Tor as socks proxy for
which implementing socks5h only can actually be considered a feature.
Closes: 744934
implement generic config fallback for methods2016-08-10T21:19:44ZDavid Kalnischkiesdavid@kalnischkies.de2016-07-31T16:05:56Zurn:sha1:30060442025824c491f58887ca7369f3c572fa57
The https method implemented for a long while now a hardcoded fallback
to the same options in http, which, while it works, is rather inflexible
if we want to allow the methods to use another name to change their
behavior slightly, like apt-transport-tor does to https – most of the
diff being s#https#tor#g which then fails to do the full circle
fallthrough tor -> https -> http for https sources. With this config
infrastructure this could be implemented now.
use the same redirection handling for http and https2016-08-10T21:19:44ZDavid Kalnischkiesdavid@kalnischkies.de2016-08-02T12:49:58Zurn:sha1:4bba5a88d0f6afde4414b586b64c48a4851d5324
cURL which backs our https implementation can handle redirects on its
own, but by dealing with them on our own we gain finer control over which
redirections will be performed (we don't like https → http) and by whom
so that redirections to other hosts correctly spawn a new https method
dealing with these instead of letting the current one deal with it.
detect redirection loops in acquire instead of workers2016-08-10T21:19:44ZDavid Kalnischkiesdavid@kalnischkies.de2016-08-02T20:44:50Zurn:sha1:57401c48fadc0c78733a67294f9cc20a57e527c9
Having the detection handled in specific (http) workers means that a
redirection loop over different hostnames isn't detected. Its also not a
good idea have this implement in each method independently even if it
would work
avoid 416 response teardown binding to null pointer2016-07-05T18:44:45ZDavid Kalnischkiesdavid@kalnischkies.de2016-07-05T11:07:29Zurn:sha1:4460551841d909d3ee9c1de00156ed3cdf8b1665
methods/http.cc:640:13: runtime error: reference binding to null pointer
of type 'struct FileFd'
This reference is never used in the cases it has a nullptr, so the
practical difference is non-existent, but its a bug still.
Reported-By: gcc -fsanitize=undefined
use std::locale::global instead of setlocale2016-05-28T16:12:02ZDavid Kalnischkiesdavid@kalnischkies.de2016-05-28T11:22:38Zurn:sha1:8b79c94af7f7cf2e5e5342294bc6e5a908cacabf
We use a wild mixture of C and C++ ways of generating output, so having
a consistent world-view in both styles sounds like a good idea and
should help in preventing regressions.
apply various suggestions made by cppcheck2015-11-05T11:21:33ZDavid Kalnischkiesdavid@kalnischkies.de2015-11-04T20:08:55Zurn:sha1:258b9e512c4001e806c5c0966acecd3d742ec6e9
Reported-By: cppcheck
Git-Dch: Ignore