apt/methods/https.cc, branch 1.2.9Debians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=1.2.92015-12-27T00:20:41ZConvert most callers of isspace() to isspace_ascii()2015-12-27T00:20:41ZJulian Andres Klodejak@debian.org2015-12-26T23:51:59Zurn:sha1:74dedb4ae28fd4f7c89bf769708d4f7edc7ed79a
This converts all callers that read machine-generated data,
callers that might work with user input are not converted.
apply various suggestions made by cppcheck2015-11-05T11:21:33ZDavid Kalnischkiesdavid@kalnischkies.de2015-11-04T20:08:55Zurn:sha1:258b9e512c4001e806c5c0966acecd3d742ec6e9
Reported-By: cppcheck
Git-Dch: Ignore
wrap every unlink call to check for != /dev/null2015-11-04T17:42:28ZDavid Kalnischkiesdavid@kalnischkies.de2015-11-02T17:49:52Zurn:sha1:ce1f3a2c616b86da657c1c796efa5f4d18c30c39
Unlinking /dev/null is bad, we shouldn't do that. Also, we should print
at least a warning if we tried to unlink a file but didn't manage to
pull it of (ignoring the case were the file is /dev/null or doesn't
exist in the first place).
This got triggered by a relatively unlikely to cause problem in
pkgAcquire::Worker::PrepareFiles which would while temporary
uncompressed files (which are set to keep compressed) figure out that to
files are the same and prepare for sharing by deleting them. Bad move.
That also shows why not printing a warning is a bad idea as this hide
the error for in non-root test runs.
Git-Dch: Ignore
set failreasons similar to connect.cc based on curl errors2015-11-04T17:04:01ZDavid Kalnischkiesdavid@kalnischkies.de2015-10-12T20:26:36Zurn:sha1:bce8e59b81e5bdfa46501c25bc1b3fca60a69cb8
Detecting network errors has some benefits in the acquire system as if
we can't connect to a host trying it for a million files is pointless.
http and co which use connect.cc deal with this, but https which uses
curl had connection failures as "normal" errors which could potentially
be worked around (like trying Release instead of the failed InRelease).
Git-Dch: Ignore
fix two memory leaks reported by gcc2015-09-14T13:22:18ZDavid Kalnischkiesdavid@kalnischkies.de2015-09-11T19:02:19Zurn:sha1:830a1b8c9e9a26dc1101167ac66a75c444902c4d
Reported-By: gcc -fsanitize=address -fno-sanitize=vptr
Git-Dch: Ignore
Merge branch 'debian/sid' into debian/experimental2015-05-22T15:01:03ZMichael Vogtmvo@ubuntu.com2015-05-22T15:01:03Zurn:sha1:4fc6b7570c3e97b65c118b58cdf6729fa94c9b03
Conflicts:
apt-pkg/pkgcache.h
debian/changelog
methods/https.cc
methods/server.cc
test/integration/test-apt-download-progress
Update methods/https.cc now that ServerState::Size is renamed2015-05-22T14:30:29ZMichael Vogtmvo@ubuntu.com2015-05-22T14:27:08Zurn:sha1:65759e00eff0513c34f584b99420b72fe0e5073e
Git-Dch: ignore
Merge remote-tracking branch 'upstream/debian/jessie' into debian/sid2015-05-22T14:17:08ZMichael Vogtmvo@ubuntu.com2015-05-22T14:17:08Zurn:sha1:0f3150e7040f45565b459a1390606bc2f714f6a8
Conflicts:
apt-pkg/deb/dpkgpm.cc
Rename "Size" in ServerState to TotalFileSize2015-05-22T13:40:18ZMichael Vogtmvo@ubuntu.com2015-05-22T13:40:18Zurn:sha1:6291f60e86718697f261519a6818e1d5ee433216
The variable "Size" was misleading and caused bug #1445239. To
avoid similar issues in the future, rename it to make the meaning
more obvious.
git-dch: ignore
detect Releasefile IMS hits even if the server doesn't2015-05-13T14:09:12ZDavid Kalnischkiesdavid@kalnischkies.de2015-05-13T14:09:12Zurn:sha1:8eafc759544298211cd0bfaa3919afc0fadd47d1
Not all servers we are talking to support If-Modified-Since and some are
not even sending Last-Modified for us, so in an effort to detect such
hits we run a hashsum check on the 'old' compared to the 'new' file, we
got the hashes for the 'new' already for "free" from the methods anyway
and hence just need to calculated the old ones.
This allows us to detect hits even with unsupported servers, which in
turn means we benefit from all the new hit behavior also here.