apt/methods/https.h, branch 1.3_pre1Debians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=1.3_pre12016-07-05T18:44:45Zavoid 416 response teardown binding to null pointer2016-07-05T18:44:45ZDavid Kalnischkiesdavid@kalnischkies.de2016-07-05T11:07:29Zurn:sha1:4460551841d909d3ee9c1de00156ed3cdf8b1665
methods/http.cc:640:13: runtime error: reference binding to null pointer
of type 'struct FileFd'
This reference is never used in the cases it has a nullptr, so the
practical difference is non-existent, but its a bug still.
Reported-By: gcc -fsanitize=undefined
use std::locale::global instead of setlocale2016-05-28T16:12:02ZDavid Kalnischkiesdavid@kalnischkies.de2016-05-28T11:22:38Zurn:sha1:8b79c94af7f7cf2e5e5342294bc6e5a908cacabf
We use a wild mixture of C and C++ ways of generating output, so having
a consistent world-view in both styles sounds like a good idea and
should help in preventing regressions.
apply various suggestions made by cppcheck2015-11-05T11:21:33ZDavid Kalnischkiesdavid@kalnischkies.de2015-11-04T20:08:55Zurn:sha1:258b9e512c4001e806c5c0966acecd3d742ec6e9
Reported-By: cppcheck
Git-Dch: Ignore
allow acquire method specific options via Binary scope2015-11-05T11:21:33ZDavid Kalnischkiesdavid@kalnischkies.de2015-11-04T13:48:36Zurn:sha1:23e64f6d0facf9610c1042326ad9850e071e8349
Allows users who know what they are getting themselves into with this
trick to e.g. disable privilege dropping for e.g. file:// until they can
fix up the permissions on those repositories. It helps also the test
framework and people with a similar setup (= me) to run in less modified
environments.
fix two memory leaks reported by gcc2015-09-14T13:22:18ZDavid Kalnischkiesdavid@kalnischkies.de2015-09-11T19:02:19Zurn:sha1:830a1b8c9e9a26dc1101167ac66a75c444902c4d
Reported-By: gcc -fsanitize=address -fno-sanitize=vptr
Git-Dch: Ignore
add c++11 override marker to overridden methods2015-08-10T15:27:17ZDavid Kalnischkiesdavid@kalnischkies.de2015-07-08T22:35:40Zurn:sha1:3b3028467ceccca0b73a8f53051c0fa4de313111
C++11 adds the 'override' specifier to mark that a method is overriding
a base class method and error out if not. We hide it in the APT_OVERRIDE
macro to ensure that we keep compiling in pre-c++11 standards.
Reported-By: clang-modernize -add-override -override-macros
Git-Dch: Ignore
detect 416 complete file in partial by expected hash2015-05-11T22:30:16ZDavid Kalnischkiesdavid@kalnischkies.de2015-05-11T22:30:16Zurn:sha1:dcbb364fc69e1108b3fea3adb12a7ba83d9af467
If we have the expected hashes we can check with them if the file we
have in partial we got a 416 for is the expected file. We detected this
with same-size before, but not every server sends a good Content-Range
header with a 416 response.
calculate hashes while downloading in https2015-04-18T23:13:09ZDavid Kalnischkiesdavid@kalnischkies.de2015-04-11T08:23:52Zurn:sha1:34faa8f7ae2526f46cd1f84bb6962ad06d841e5e
We do this in HTTP already to give the CPU some exercise while the disk
is heavily spinning (or flashing?) to store the data avoiding the need
to reread the entire file again later on to calculate the hashes – which
happens outside of the eyes of progress reporting, so you might ended up
with a bunch of https workers 'stuck' at 100% while they were busy
calculating hashes.
This is a bummer for everyone using apt as a connection speedtest as the
https method works slower now (not really, it just isn't reporting done
too early anymore).
calculate only expected hashes in methods2015-04-18T23:13:09ZDavid Kalnischkiesdavid@kalnischkies.de2015-03-30T18:47:13Zurn:sha1:9224ce3d4d1ea0428a70e75134998e08aa45b1e6
Methods get told which hashes are expected by the acquire system, which
means we can use this list to restrict what we calculate in the methods
as any extra we are calculating is wasted effort as we can't compare it
with anything anyway.
Adding support for a new hash algorithm is therefore 'free' now and if a
algorithm is no longer provided in a repository for a file, we
automatically stop calculating it.
In practice this results in a speed-up in Debian as we don't have SHA512
here (so far), so we practically stop calculating it.
improve https method queue progress reporting2015-04-18T23:13:08ZDavid Kalnischkiesdavid@kalnischkies.de2015-03-27T14:53:43Zurn:sha1:27925d82dd0cbae74d48040363fe6f6c2bae5215
The worker expects that the methods tell him when they start or finish
downloading a file. Various information pieces are passed along in this
report including the (expected) filesize. https was using a "global"
struct for reporting which made it 'reuse' incorrect values in some
cases like a non-existent InRelease fallbacking to Release{,.gpg}
resulting in a size-mismatch warning. Reducing the scope and redesigning
the setting of the values we can fix this and related issues.
Closes: 777565, 781509
Thanks: Robert Edmonds and Anders Kaseorg for initial patchs