apt/methods/https.h, branch 1.4_beta3Debians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=1.4_beta32016-12-31T01:29:21Zrename ServerMethod to BaseHttpMethod2016-12-31T01:29:21ZDavid Kalnischkiesdavid@kalnischkies.de2016-12-09T14:13:09Zurn:sha1:d8617331afc39281d5925033975b6097128786f4
This 'method' is the abstract base for http and https and should as such
be called out like this rather using an easily confused name.
Gbp-Dch: Ignore
separating state variables regarding server/request2016-12-31T01:29:21ZDavid Kalnischkiesdavid@kalnischkies.de2016-11-09T11:25:44Zurn:sha1:13a9f08de18dea0dfc1951992b0ddeda9c2fa2dd
Having a Reset(bool) method to partially reset certain variables like
the download size always were strange, so this commit splits the
ServerState into an additional RequestState living on the stack for as
long as we deal with this request causing an automatic "reset".
There is much to do still to make this code look better, but this is a
good first step which compiles cleanly and passes all tests, so keeping
it as history might be beneficial and due to avoiding explicit memory
allocations it ends up fixing a small memory leak in https, too.
Closes: #440057
implement generic config fallback for methods2016-08-10T21:19:44ZDavid Kalnischkiesdavid@kalnischkies.de2016-07-31T16:05:56Zurn:sha1:30060442025824c491f58887ca7369f3c572fa57
The https method implemented for a long while now a hardcoded fallback
to the same options in http, which, while it works, is rather inflexible
if we want to allow the methods to use another name to change their
behavior slightly, like apt-transport-tor does to https – most of the
diff being s#https#tor#g which then fails to do the full circle
fallthrough tor -> https -> http for https sources. With this config
infrastructure this could be implemented now.
detect redirection loops in acquire instead of workers2016-08-10T21:19:44ZDavid Kalnischkiesdavid@kalnischkies.de2016-08-02T20:44:50Zurn:sha1:57401c48fadc0c78733a67294f9cc20a57e527c9
Having the detection handled in specific (http) workers means that a
redirection loop over different hostnames isn't detected. Its also not a
good idea have this implement in each method independently even if it
would work
fail on unsupported http/https proxy settings2016-08-10T21:19:44ZDavid Kalnischkiesdavid@kalnischkies.de2016-08-03T19:17:26Zurn:sha1:ece81b7517b1af6f86aff733498f6c11d5aa814f
Closes: #623443
avoid 416 response teardown binding to null pointer2016-07-05T18:44:45ZDavid Kalnischkiesdavid@kalnischkies.de2016-07-05T11:07:29Zurn:sha1:4460551841d909d3ee9c1de00156ed3cdf8b1665
methods/http.cc:640:13: runtime error: reference binding to null pointer
of type 'struct FileFd'
This reference is never used in the cases it has a nullptr, so the
practical difference is non-existent, but its a bug still.
Reported-By: gcc -fsanitize=undefined
use std::locale::global instead of setlocale2016-05-28T16:12:02ZDavid Kalnischkiesdavid@kalnischkies.de2016-05-28T11:22:38Zurn:sha1:8b79c94af7f7cf2e5e5342294bc6e5a908cacabf
We use a wild mixture of C and C++ ways of generating output, so having
a consistent world-view in both styles sounds like a good idea and
should help in preventing regressions.
apply various suggestions made by cppcheck2015-11-05T11:21:33ZDavid Kalnischkiesdavid@kalnischkies.de2015-11-04T20:08:55Zurn:sha1:258b9e512c4001e806c5c0966acecd3d742ec6e9
Reported-By: cppcheck
Git-Dch: Ignore
allow acquire method specific options via Binary scope2015-11-05T11:21:33ZDavid Kalnischkiesdavid@kalnischkies.de2015-11-04T13:48:36Zurn:sha1:23e64f6d0facf9610c1042326ad9850e071e8349
Allows users who know what they are getting themselves into with this
trick to e.g. disable privilege dropping for e.g. file:// until they can
fix up the permissions on those repositories. It helps also the test
framework and people with a similar setup (= me) to run in less modified
environments.
fix two memory leaks reported by gcc2015-09-14T13:22:18ZDavid Kalnischkiesdavid@kalnischkies.de2015-09-11T19:02:19Zurn:sha1:830a1b8c9e9a26dc1101167ac66a75c444902c4d
Reported-By: gcc -fsanitize=address -fno-sanitize=vptr
Git-Dch: Ignore