apt/methods/mirror.cc, branch 1.1.9Debians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=1.1.92015-11-19T16:56:07Zignore lost+found in private directory cleanup2015-11-19T16:56:07ZDavid Kalnischkiesdavid@kalnischkies.de2015-11-19T15:19:15Zurn:sha1:6aef1942f441e6e667982b92802907026d8cc7c6
In ce1f3a2c we started warning about failing unlinking, which we
consistently do for directories. That isn't a problem as directories
usually aren't in the places we do want to clean up – with the potential
exeception of "lost+found", so lets ignore it like we ignore our own
partial/ subdirectory.
Closes: 805424
wrap every unlink call to check for != /dev/null2015-11-04T17:42:28ZDavid Kalnischkiesdavid@kalnischkies.de2015-11-02T17:49:52Zurn:sha1:ce1f3a2c616b86da657c1c796efa5f4d18c30c39
Unlinking /dev/null is bad, we shouldn't do that. Also, we should print
at least a warning if we tried to unlink a file but didn't manage to
pull it of (ignoring the case were the file is /dev/null or doesn't
exist in the first place).
This got triggered by a relatively unlikely to cause problem in
pkgAcquire::Worker::PrepareFiles which would while temporary
uncompressed files (which are set to keep compressed) figure out that to
files are the same and prepare for sharing by deleting them. Bad move.
That also shows why not printing a warning is a bad idea as this hide
the error for in non-root test runs.
Git-Dch: Ignore
cleanup headers and especially #includes everywhere2014-03-13T12:58:45ZDavid Kalnischkiesdavid@kalnischkies.de2014-03-05T21:11:25Zurn:sha1:453b82a388013e522b3a1b9fcd6ed0810dab1f4f
Beside being a bit cleaner it hopefully also resolves oddball problems
I have with high levels of parallel jobs.
Git-Dch: Ignore
Reported-By: iwyu (include-what-you-use)
warning: unused parameter ‘foo’ [-Wunused-parameter]2014-03-13T12:58:45ZDavid Kalnischkiesdavid@kalnischkies.de2014-03-01T14:11:42Zurn:sha1:655122418d714f342b5d9789f45f8035f3fe8b9a
Reported-By: gcc -Wunused-parameter
Git-Dch: Ignore
warning: extra ‘;’ [-Wpedantic]2014-03-13T12:58:45ZDavid Kalnischkiesdavid@kalnischkies.de2014-02-27T00:20:53Zurn:sha1:d3e8fbb395f57954acd7a2095f02ce530a05ec6a
Git-Dch: Ignore
Reported-By: gcc -Wpedantic
Fix typos in documentation (codespell)2014-02-22T17:34:33ZMichael Vogtmvo@debian.org2014-02-22T17:34:33Zurn:sha1:1e3f4083db29bba600b9725e9456b0e140975c99correct some style/performance/warnings from cppcheck2014-01-16T21:19:49ZDavid Kalnischkiesdavid@kalnischkies.de2014-01-16T21:19:49Zurn:sha1:9ce3cfc9309c55cc01018c88c1ca82779fd74431
The most "visible" change is from utime to utimensat/futimens
as the first one isn't part of POSIX anymore.
Reported-By: cppcheck
Git-Dch: Ignore
Fix double free (closes: #711045)2013-06-06T16:20:35ZMichael Vogtmvo@debian.org2013-06-06T16:20:35Zurn:sha1:245ba2c306e663fb311b7796fdf13a7ae7073a4d
* Fix double free (closes: #711045)
* Fix crash when the "mirror" method does not find any entry
(closes: #699303)
* methods/mirror.cc:2012-05-14T16:27:37ZRaphael Geissertgeissert@debian.org2012-05-14T16:27:37Zurn:sha1:046e104e1371584251ad2568a11090fe4ed9a42e
- generate an equal sign also for the first arch (Closes: #669142)
* methods/rred.cc:2012-03-20T18:23:32ZDavid Kalnischkieskalnischkies@gmail.com2012-03-20T18:23:32Zurn:sha1:319790f4f86f595724fb2bd5aa6274d345469010
- check return of writev() as gcc recommends
* methods/mirror.cc:
- check return of chdir() as gcc recommends
* apt-pkg/deb/dpkgpm.cc:
- check return of write() a gcc recommends
* apt-inst/deb/debfile.cc:
- check return of chdir() as gcc recommends
* apt-inst/deb/dpkgdb.cc:
- check return of chdir() as gcc recommends