apt/methods/rred.cc, branch 1.1.exp11Debians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=1.1.exp112015-08-10T15:27:17Zadd c++11 override marker to overridden methods2015-08-10T15:27:17ZDavid Kalnischkiesdavid@kalnischkies.de2015-07-08T22:35:40Zurn:sha1:3b3028467ceccca0b73a8f53051c0fa4de313111
C++11 adds the 'override' specifier to mark that a method is overriding
a base class method and error out if not. We hide it in the APT_OVERRIDE
macro to ensure that we keep compiling in pre-c++11 standards.
Reported-By: clang-modernize -add-override -override-macros
Git-Dch: Ignore
replace ULONG_MAX with c++ style std::numeric_limits2015-06-09T13:15:33ZDavid Kalnischkiesdavid@kalnischkies.de2015-06-09T13:15:33Zurn:sha1:c69e8370947d765dd94f142d18dc11d5a76af443
For some reason travis seems to be unhappy about it claiming it
is not defined. Well, lets not think to deeply about it…
Git-Dch: Ignore
support hashes for compressed pdiff files2015-06-09T10:57:36ZDavid Kalnischkiesdavid@kalnischkies.de2015-06-07T22:06:41Zurn:sha1:4f51fd8636592a96aecf17c8bf4cfdb3ea2207cc
At the moment we only have hashes for the uncompressed pdiff files, but
via the new '$HASH-Download' field in the .diff/Index hashes can be
provided for the .gz compressed pdiff file, which apt will pick up now
and use to verify the download. Now, we "just" need a buy in from the
creators of repositories…
add more parsing error checking for rred2015-06-09T10:57:36ZDavid Kalnischkiesdavid@kalnischkies.de2015-06-07T00:17:15Zurn:sha1:6d3e5bd8e08564c5eb12ecd869de5bd71e25f59d
The rred parser is very accepting regarding 'invalid' files. Given that
we can't trust the input it might be a bit too relaxed. In any case,
checking for more errors can't hurt given that we support only a very
specific subset of ed commands.
check patch hashes in rred worker instead of in the handler2015-06-09T10:57:36ZDavid Kalnischkiesdavid@kalnischkies.de2015-06-06T17:16:45Zurn:sha1:3679515479136179e0d95325a6559fcc6d0af7f8
rred is responsible for unpacking and reading the patch files in one go,
but we currently only have hashes for the uncompressed patch files, so
the handler read the entire patch file before dispatching it to the
worker which would read it again – both with an implicit uncompress.
Worse, while the workers operate in parallel the handler is the central
orchestration unit, so having it busy with work means the workers do
(potentially) nothing.
This means rred is working with 'untrusted' data, which is bad. Yet,
having the unpack in the handler meant that the untrusted uncompress was
done as root which isn't better either. Now, we have it at least
contained in a binary which we can harden a bit better. In the long run,
we want hashes for the compressed patch files through to be safe.
calculate only expected hashes in methods2015-04-18T23:13:09ZDavid Kalnischkiesdavid@kalnischkies.de2015-03-30T18:47:13Zurn:sha1:9224ce3d4d1ea0428a70e75134998e08aa45b1e6
Methods get told which hashes are expected by the acquire system, which
means we can use this list to restrict what we calculate in the methods
as any extra we are calculating is wasted effort as we can't compare it
with anything anyway.
Adding support for a new hash algorithm is therefore 'free' now and if a
algorithm is no longer provided in a repository for a file, we
automatically stop calculating it.
In practice this results in a speed-up in Debian as we don't have SHA512
here (so far), so we practically stop calculating it.
Assert statement calls a function which may have desired side effects: 'pos_is_okay'2014-11-08T13:26:00ZDavid Kalnischkiesdavid@kalnischkies.de2014-11-05T17:33:07Zurn:sha1:9dd940ed722e8235c615e79b7eb688eb427e9a23
It does not have any desired sideeffect, so we just mark it as const to
properly advertise this fact to developer, compiler and linter alike.
Reported-By: cppcheck
Git-Dch: Ignore
cleanup headers and especially #includes everywhere2014-03-13T12:58:45ZDavid Kalnischkiesdavid@kalnischkies.de2014-03-05T21:11:25Zurn:sha1:453b82a388013e522b3a1b9fcd6ed0810dab1f4f
Beside being a bit cleaner it hopefully also resolves oddball problems
I have with high levels of parallel jobs.
Git-Dch: Ignore
Reported-By: iwyu (include-what-you-use)
fix -Wformat= warnings about size_t != %lu on e.g. armel2014-03-13T12:58:45ZDavid Kalnischkiesdavid@kalnischkies.de2014-02-25T21:30:39Zurn:sha1:6298ff8b6492e2071a8f2ca7669a3aeef0fb29c7
Git-Dch: Ignore
Reported-By: gcc
use utimes instead of utimensat/futimens2014-02-11T01:28:27ZDavid Kalnischkiesdavid@kalnischkies.de2014-02-10T20:52:38Zurn:sha1:246bbb611d4cd5e2a13ecffb6cbe0e76390eae6f
cppcheck complains about the obsolete utime as it was removed in
POSIX1.2008 and recommends usage of utimensat/futimens instead
as those are in POSIX and so commit 9ce3cfc9 switched to them.
It is just that they aren't as portable as the standard suggests:
At least our kFreeBSD and Hurd ports stumble over it at runtime.
So to make both, the ports and cppcheck happy, we use utimes instead.
Closes: 738567