apt/methods/rsh.cc, branch 2.1.13

Apply various suggestions by cppcheck

2019-07-08T13:51:17Z

Reported-By: cppcheck

apt-pkg: URI: Add 'explicit' to single argument constructor

2019-04-30T15:43:56Z

This needs a fair amount of changes elsewhere in the code, hence this is separate from the previous commits.

Lower default timeout from 120s to 30s

2018-05-24T12:31:31Z

120s is an insanely high default time out, lower it to 30s to make things a bit nicer.

Remove obsolete RCS keywords

2018-05-07T11:41:31Z

Prompted-by: Jakub Wilk

Reformat and sort all includes with clang-format

2017-07-12T11:57:51Z

This makes it easier to see which headers includes what. The changes were done by running git grep -l '#\s*include' \ | grep -E '.(cc|h)$' \ | xargs sed -i -E 's/(^\s*)#(\s*)include/\1#\2 include/' To modify all include lines by adding a space, and then running ./git-clang-format.sh.

implement generic config fallback for methods

2016-08-10T21:19:44Z

The https method implemented for a long while now a hardcoded fallback to the same options in http, which, while it works, is rather inflexible if we want to allow the methods to use another name to change their behavior slightly, like apt-transport-tor does to https – most of the diff being s#https#tor#g which then fails to do the full circle fallthrough tor -> https -> http for https sources. With this config infrastructure this could be implemented now.

use std::locale::global instead of setlocale

2016-05-28T16:12:02Z

We use a wild mixture of C and C++ ways of generating output, so having a consistent world-view in both styles sounds like a good idea and should help in preventing regressions.

disable privilege dropping for rsh/ssh method by default

2015-11-28T15:09:42Z

ssh expects various configuration bits to be usable like known hosts, possibly keys and co. Setting this up needs some user work for probably not a whole lot of benefits, so instead of forcing it upon users on upgrade disable dropping for it by default. Closes: 806511

fix program name detection in rsh method

2015-11-28T14:46:31Z

Regression intoduced in 23e64f6d0facf9610c1042326ad9850e071e8349

allow acquire method specific options via Binary scope

2015-11-05T11:21:33Z

Allows users who know what they are getting themselves into with this trick to e.g. disable privilege dropping for e.g. file:// until they can fix up the permissions on those repositories. It helps also the test framework and people with a similar setup (= me) to run in less modified environments.