apt/methods/server.cc, branch 1.2.10Debians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=1.2.102016-01-26T14:32:15Zact on various suggestions from cppcheck2016-01-26T14:32:15ZDavid Kalnischkiesdavid@kalnischkies.de2016-01-25T21:13:52Zurn:sha1:2651f1c071927b7fc440ec7a638ecad7ccf04a2e
Reported-By: cppcheck
Git-Dch: Ignore
Only enable pipelining if server is HTTP/1.12016-01-12T22:40:59ZJulian Andres Klodejak@debian.org2016-01-12T14:18:12Zurn:sha1:b6d88f39aceda2e093e1bf8751f07236b7d9e483
Just enabling it for anyone breaks with HTTP/1.0 servers and
proxies sometimes.
Closes: #810796
Convert most callers of isspace() to isspace_ascii()2015-12-27T00:20:41ZJulian Andres Klodejak@debian.org2015-12-26T23:51:59Zurn:sha1:74dedb4ae28fd4f7c89bf769708d4f7edc7ed79a
This converts all callers that read machine-generated data,
callers that might work with user input are not converted.
allow acquire method specific options via Binary scope2015-11-05T11:21:33ZDavid Kalnischkiesdavid@kalnischkies.de2015-11-04T13:48:36Zurn:sha1:23e64f6d0facf9610c1042326ad9850e071e8349
Allows users who know what they are getting themselves into with this
trick to e.g. disable privilege dropping for e.g. file:// until they can
fix up the permissions on those repositories. It helps also the test
framework and people with a similar setup (= me) to run in less modified
environments.
wrap every unlink call to check for != /dev/null2015-11-04T17:42:28ZDavid Kalnischkiesdavid@kalnischkies.de2015-11-02T17:49:52Zurn:sha1:ce1f3a2c616b86da657c1c796efa5f4d18c30c39
Unlinking /dev/null is bad, we shouldn't do that. Also, we should print
at least a warning if we tried to unlink a file but didn't manage to
pull it of (ignoring the case were the file is /dev/null or doesn't
exist in the first place).
This got triggered by a relatively unlikely to cause problem in
pkgAcquire::Worker::PrepareFiles which would while temporary
uncompressed files (which are set to keep compressed) figure out that to
files are the same and prepare for sharing by deleting them. Bad move.
That also shows why not printing a warning is a bad idea as this hide
the error for in non-root test runs.
Git-Dch: Ignore
fix two memory leaks reported by gcc2015-09-14T13:22:18ZDavid Kalnischkiesdavid@kalnischkies.de2015-09-11T19:02:19Zurn:sha1:830a1b8c9e9a26dc1101167ac66a75c444902c4d
Reported-By: gcc -fsanitize=address -fno-sanitize=vptr
Git-Dch: Ignore
fix various typos reported by codespell2015-08-27T09:27:44ZDavid Kalnischkiesdavid@kalnischkies.de2015-08-22T14:22:08Zurn:sha1:3a8776a37af38127fb04565959e8e0e449eb04a4
Reported-By: codespell
Merge branch 'debian/sid' into debian/experimental2015-05-22T15:01:03ZMichael Vogtmvo@ubuntu.com2015-05-22T15:01:03Zurn:sha1:4fc6b7570c3e97b65c118b58cdf6729fa94c9b03
Conflicts:
apt-pkg/pkgcache.h
debian/changelog
methods/https.cc
methods/server.cc
test/integration/test-apt-download-progress
Rename "Size" in ServerState to TotalFileSize2015-05-22T13:40:18ZMichael Vogtmvo@ubuntu.com2015-05-22T13:40:18Zurn:sha1:6291f60e86718697f261519a6818e1d5ee433216
The variable "Size" was misleading and caused bug #1445239. To
avoid similar issues in the future, rename it to make the meaning
more obvious.
git-dch: ignore
Fix endless loop in apt-get update that can cause disk fillup2015-05-22T13:28:53ZMichael Vogtmvo@ubuntu.com2015-05-22T13:28:53Zurn:sha1:ceafe8a6edc815df2923ba892894617829e9d3c2
The apt http code parses Content-Length and Content-Range. For
both requests the variable "Size" is used and the semantic for
this Size is the total file size. However Content-Length is not
the entire file size for partital file requests. For servers that
send the Content-Range header first and then the Content-Length
header this can lead to globbing of Size so that its less than
the real file size. This may lead to a subsequent passing of a
negative number into the CircleBuf which leads to a endless
loop that writes data.
Thanks to Anton Blanchard for the analysis and initial patch.
LP: #1445239