apt/methods/server.cc, branch 1.3_pre2Debians commandline package managerhttps://git.kalnischkies.de/apt/atom?h=1.3_pre22016-06-27T09:43:09Zclose server if parsing of header field failed2016-06-27T09:43:09ZDavid Kalnischkiesdavid@kalnischkies.de2016-06-25T10:32:11Zurn:sha1:cc0a4c82b3c132abba9b9ec35fd61bc8b45a1b80
Seen in #828011 if we fail to parse a header field like Last-Modified we
end up interpreting the data as response header for coming requests in
case we don't rotate to a new server in DNS rotation.
use std::locale::global instead of setlocale2016-05-28T16:12:02ZDavid Kalnischkiesdavid@kalnischkies.de2016-05-28T11:22:38Zurn:sha1:8b79c94af7f7cf2e5e5342294bc6e5a908cacabf
We use a wild mixture of C and C++ ways of generating output, so having
a consistent world-view in both styles sounds like a good idea and
should help in preventing regressions.
prevent C++ locale number formatting in text APIs2016-05-27T17:14:38ZDavid Kalnischkiesdavid@kalnischkies.de2016-05-27T16:10:39Zurn:sha1:b58e2c7c56b1416a343e81f9f80cb1f02c128e25
Setting the C++ locale via std::locale::global(std::locale("")); which
would otherwise default to the default C locale (aka: unaffected by
setlocale) effects the formatting of numeric types in IO streams, which
for output for humans is perfectly sensible, but breaks our many text
interfaces used and parsed by us and others without expecting the
numbers to be formatted.
Closes: #825396
don't ask server if we have entire file in partial/2016-04-25T13:35:52ZDavid Kalnischkiesdavid@kalnischkies.de2016-04-07T15:48:17Zurn:sha1:742f67eaede80d2f9b3631d8697ebd63b8f95427
We have this situation in cases were parts of the transaction are
refused (e.g. in a hashsum mismatch) and rerun the update (e.g. in the
hope that we get a mirror which is synced this time).
Previously we would ask the server with an if-range and in the best case
recieve a 416 in response (less featureful server might end up giving us
the entire file again or we get the wrong file this time giving us a
hashsum mismatch…), which is a waste of time if we know already by
checking the hashsums that we got the complete and correct file.
act on various suggestions from cppcheck2016-01-26T14:32:15ZDavid Kalnischkiesdavid@kalnischkies.de2016-01-25T21:13:52Zurn:sha1:2651f1c071927b7fc440ec7a638ecad7ccf04a2e
Reported-By: cppcheck
Git-Dch: Ignore
Only enable pipelining if server is HTTP/1.12016-01-12T22:40:59ZJulian Andres Klodejak@debian.org2016-01-12T14:18:12Zurn:sha1:b6d88f39aceda2e093e1bf8751f07236b7d9e483
Just enabling it for anyone breaks with HTTP/1.0 servers and
proxies sometimes.
Closes: #810796
Convert most callers of isspace() to isspace_ascii()2015-12-27T00:20:41ZJulian Andres Klodejak@debian.org2015-12-26T23:51:59Zurn:sha1:74dedb4ae28fd4f7c89bf769708d4f7edc7ed79a
This converts all callers that read machine-generated data,
callers that might work with user input are not converted.
allow acquire method specific options via Binary scope2015-11-05T11:21:33ZDavid Kalnischkiesdavid@kalnischkies.de2015-11-04T13:48:36Zurn:sha1:23e64f6d0facf9610c1042326ad9850e071e8349
Allows users who know what they are getting themselves into with this
trick to e.g. disable privilege dropping for e.g. file:// until they can
fix up the permissions on those repositories. It helps also the test
framework and people with a similar setup (= me) to run in less modified
environments.
wrap every unlink call to check for != /dev/null2015-11-04T17:42:28ZDavid Kalnischkiesdavid@kalnischkies.de2015-11-02T17:49:52Zurn:sha1:ce1f3a2c616b86da657c1c796efa5f4d18c30c39
Unlinking /dev/null is bad, we shouldn't do that. Also, we should print
at least a warning if we tried to unlink a file but didn't manage to
pull it of (ignoring the case were the file is /dev/null or doesn't
exist in the first place).
This got triggered by a relatively unlikely to cause problem in
pkgAcquire::Worker::PrepareFiles which would while temporary
uncompressed files (which are set to keep compressed) figure out that to
files are the same and prepare for sharing by deleting them. Bad move.
That also shows why not printing a warning is a bad idea as this hide
the error for in non-root test runs.
Git-Dch: Ignore
fix two memory leaks reported by gcc2015-09-14T13:22:18ZDavid Kalnischkiesdavid@kalnischkies.de2015-09-11T19:02:19Zurn:sha1:830a1b8c9e9a26dc1101167ac66a75c444902c4d
Reported-By: gcc -fsanitize=address -fno-sanitize=vptr
Git-Dch: Ignore