Debians commandline package manager https://git.kalnischkies.de/apt/atom?h=1.3_pre2 2016-07-05T18:44:45Z 2016-07-05T18:44:45Z David Kalnischkies david@kalnischkies.de 2016-07-05T11:07:29Z urn:sha1:4460551841d909d3ee9c1de00156ed3cdf8b1665 methods/http.cc:640:13: runtime error: reference binding to null pointer of type 'struct FileFd' This reference is never used in the cases it has a nullptr, so the practical difference is non-existent, but its a bug still. Reported-By: gcc -fsanitize=undefined 2016-05-28T16:12:02Z David Kalnischkies david@kalnischkies.de 2016-05-28T11:22:38Z urn:sha1:8b79c94af7f7cf2e5e5342294bc6e5a908cacabf We use a wild mixture of C and C++ ways of generating output, so having a consistent world-view in both styles sounds like a good idea and should help in preventing regressions. 2016-01-12T22:40:59Z Julian Andres Klode jak@debian.org 2016-01-12T14:18:12Z urn:sha1:b6d88f39aceda2e093e1bf8751f07236b7d9e483 Just enabling it for anyone breaks with HTTP/1.0 servers and proxies sometimes. Closes: #810796 2015-11-05T11:21:33Z David Kalnischkies david@kalnischkies.de 2015-11-04T13:48:36Z urn:sha1:23e64f6d0facf9610c1042326ad9850e071e8349 Allows users who know what they are getting themselves into with this trick to e.g. disable privilege dropping for e.g. file:// until they can fix up the permissions on those repositories. It helps also the test framework and people with a similar setup (= me) to run in less modified environments. 2015-09-14T13:22:18Z David Kalnischkies david@kalnischkies.de 2015-09-11T19:02:19Z urn:sha1:830a1b8c9e9a26dc1101167ac66a75c444902c4d Reported-By: gcc -fsanitize=address -fno-sanitize=vptr Git-Dch: Ignore 2015-08-10T15:27:17Z David Kalnischkies david@kalnischkies.de 2015-07-08T22:35:40Z urn:sha1:3b3028467ceccca0b73a8f53051c0fa4de313111 C++11 adds the 'override' specifier to mark that a method is overriding a base class method and error out if not. We hide it in the APT_OVERRIDE macro to ensure that we keep compiling in pre-c++11 standards. Reported-By: clang-modernize -add-override -override-macros Git-Dch: Ignore 2015-05-22T15:01:03Z Michael Vogt mvo@ubuntu.com 2015-05-22T15:01:03Z urn:sha1:4fc6b7570c3e97b65c118b58cdf6729fa94c9b03 Conflicts: apt-pkg/pkgcache.h debian/changelog methods/https.cc methods/server.cc test/integration/test-apt-download-progress 2015-05-22T13:40:18Z Michael Vogt mvo@ubuntu.com 2015-05-22T13:40:18Z urn:sha1:6291f60e86718697f261519a6818e1d5ee433216 The variable "Size" was misleading and caused bug #1445239. To avoid similar issues in the future, rename it to make the meaning more obvious. git-dch: ignore 2015-05-22T13:28:53Z Michael Vogt mvo@ubuntu.com 2015-05-22T13:28:53Z urn:sha1:ceafe8a6edc815df2923ba892894617829e9d3c2 The apt http code parses Content-Length and Content-Range. For both requests the variable "Size" is used and the semantic for this Size is the total file size. However Content-Length is not the entire file size for partital file requests. For servers that send the Content-Range header first and then the Content-Length header this can lead to globbing of Size so that its less than the real file size. This may lead to a subsequent passing of a negative number into the CircleBuf which leads to a endless loop that writes data. Thanks to Anton Blanchard for the analysis and initial patch. LP: #1445239 2015-04-18T23:13:09Z David Kalnischkies david@kalnischkies.de 2015-04-11T08:23:52Z urn:sha1:34faa8f7ae2526f46cd1f84bb6962ad06d841e5e We do this in HTTP already to give the CPU some exercise while the disk is heavily spinning (or flashing?) to store the data avoiding the need to reread the entire file again later on to calculate the hashes – which happens outside of the eyes of progress reporting, so you might ended up with a bunch of https workers 'stuck' at 100% while they were busy calculating hashes. This is a bummer for everyone using apt as a connection speedtest as the https method works slower now (not really, it just isn't reporting done too early anymore).